The 'rewrite 1 core api class every day' Thread

Question

as we all know, if you want something doing properly, you've gotta do it yourself
in light of this - I thought rewriting Javas entire core api (so it was done properly) would make quite a fun Thread :P
now, this being a Game Development forum - I thought a good place to start would be in a graphics oriented class that everyone will have used....
* @(#)DisplayMode.java     1.3 01/12/03
* Copyright 2002 Sun Microsystems, Inc. All rights reserved.
* SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
package java.awt;
public final class DisplayMode
    private Dimension size;
    private int bitDepth;
    private int refreshRate;
    public DisplayMode(int width, int height, int bitDepth, int refreshRate)
        this.size = new Dimension(width, height);
        this.bitDepth = bitDepth;
        this.refreshRate = refreshRate;
    public int getHeight()
        return size.height;
    public int getWidth()
        return size.width;
    public final static int BIT_DEPTH_MULTI = -1;
    public int getBitDepth()
        return bitDepth;
    public final static int REFRESH_RATE_UNKNOWN = 0;
    public int getRefreshRate()
        return refreshRate;
    public boolean equals(DisplayMode dm)
        return (getHeight() == dm.getHeight()
            && getWidth() == dm.getWidth()
            && getBitDepth() == dm.getBitDepth()
            && getRefreshRate() == dm.getRefreshRate());
    public int hashCode()
        return getWidth() + getHeight() + getBitDepth() * 7 + getRefreshRate() * 13;
//and the smaller, faster version...
package java.awt;
public final class DisplayMode
    public final int width;
    public final int height;
    public final int bitDepth;
    public final int refreshRate;
    public DisplayMode(int width, int height, int bitDepth, int refreshRate)
        this.width = width;
        this.height = height;
        this.bitDepth = bitDepth;
        this.refreshRate = refreshRate;
    public int getHeight()
        return height;
    public int getWidth()
        return width;
    public final static int BIT_DEPTH_MULTI = -1;
    public int getBitDepth()
        return bitDepth;
    public final static int REFRESH_RATE_UNKNOWN = 0;
    public int getRefreshRate()
        return refreshRate;
    public boolean equals(DisplayMode dm)
        return (height == dm.height
            && width == dm.width
            && bitDepth == dm.bitDepth
            && refreshRate == dm.refreshRate);
    public int hashCode()
        return width + height + bitDepth*7 + refreshRate*13;
}25th Jan 2003
abu,

Answer 1

m'kay...
i suppose you could do that...
anyway, i'm not good with this 'keyword' stuff and
all.../me wonders why you are posting here at all :D
but wouldn't final mean that you cannot change taht
variables value later...yup
of course you could say that you don't want to, and
that nobody needs to...well yeah... when classes are immutable (as the DisplayMode class is)
its values are, by definition, unchangable.
but why are ther these set methods then?there are no 'set' methods - DisplayMode is an immutable class.
>
this public thing i'm also not sure about.
in this class you may go public, but some classes user
should NOT have ability to set value of variable
directly.the only reason they are public, is because they are final (or should be atleast :P).
I wouldn't make them public otherwise.
Also, the only reason the getXXX methods exist, is it conform to the original spec. of the DisplayMode class. (and the 'standard' or having get methods for public attributes - Dimension,Rectangle,Point etc all do it)
maybe it would be better to stick with protected... ?as markuskidd has pointed out - this class is final, it cannot be extended, hence protected means nothing.
>
othervise it's a good idea.
if you get a bunch of classes that have been
perfected, then maybe sun will one day revise your
classes and replace these old crapier ones.gotta find 1 to do 2morrow now :P (though I doubt this will make any difference to Sun, they simply don't care about correct code)