Trigger error

Question

hi barbara
i had dought
i created a simple trigger.But when i am inserting the records
in the specific table this trigger is not firing or inserting the records
what may be the error is it my simple mistake.how to write more good way
with regards
ramya
CREATE OR REPLACE TRIGGER BD_EXOS_insert_entl_hr_update
AFTER INSERT or update OF EE_EMPNO ON EE
FOR EACH ROW
BEGIN
insert into ele_fin(ele_fin_empno,ele_fin_year,ele_fin_entitlement)
select empno,'2004',0 from hr_update
WHERE EMPNO =:NEW.EE_EMPNO;
insert into hr_update(empno,name,dp,sec,title,grade,nation,doj)
select ee_empno,substr(ee_sname,1,25),ee_dept,ee_division,ee_telephone_no,
ee_job_grade,ee_supervisor,ee_stdate
from ee
where ee_empno=:NEW.EE_EMPNO;
END;

Answer 1

You cannot select from the same table that the trigger is on, from within the trigger. So, since the trigger is on table ee, then you cannot select from ee within the trigger. However, if the values of ee_empno are unique, so that there is only one row such that ee_empno = :new.ee_empno, then you can just use all of the :new values for that row for your insert into hr_update, instead of selecting from the ee table. Please see the corrected code below.
CREATE OR REPLACE TRIGGER BD_EXOS_insert_entl_hr_update
  AFTER INSERT or update OF EE_EMPNO ON EE
  FOR EACH ROW
BEGIN
  insert into ele_fin
    (ele_fin_empno, ele_fin_year, ele_fin_entitlement)
  select empno, '2004', 0
  from   hr_update
  WHERE  EMPNO = :NEW.EE_EMPNO;
  insert into hr_update
    (empno, name, dp, sec, title, grade, nation, doj)
  values (:NEW.ee_empno, substr (:NEW.ee_sname, 1, 25), :NEW.ee_dept,
          :NEW.ee_division, :NEW.ee_telephone_no, :NEW.ee_job_grade,
          :NEW.ee_supervisor, :NEW.ee_stdate);
END BD_EXOS_insert_entl_hr_update;