Update New Record

Question

T1::
C1
C2
C3
T1
C1   C2    C3
A    100   1
A    108   2
B    104   1
B    106   2
Insert New record
Insert Into T1(C1,C2,C3)
Values(A,105,NULL);
Insert Into T2(C1,C2,C3)
Values(A,105,NULL);
Declare
Begin
For i in (select T1.C1 from T1,T2 Where T1.C1=T2.C1)
Loop
Update T1
Set C3=(Seelct Rn From
select ROW_NUMBER() OVER(Partition By C1 oder by C2 ) Rn from T1 where 1=i.C1
Where C1=i.C1
And C2=i.C2;
End loop;
End;
Is this update correct to make above sample data to
T1
C1   C2    C3
A    105   1         ---------------------> Inserted New Updated with 1
A    100   2         ---------------------> Old with C3=1 Now C3=2
A    108   3
B    104   1
B    106   2

Answer 1

Or for the update part, you could do this:
update t1 set c3=(case when c3 is not null then c3+1
                        when c3 is null then 1 end)
          where c1 =:c1;You are 'oder by C2' while C2 is not really in the order (105, 100, 108).
Here is the detail:
create table t1 (c1 varchar2(1), c2 number(3), c3 number(3));
insert into t1 values ('A',100, 1);
insert into t1 values ('A',105, NULL);
insert into t1 values ('A',108, 2);
insert into t1 values ('B',104, 1);
insert into t1 values ('B',106, 2);
insert into t1 values ('B',110, null);
CREATE OR REPLACE PROCEDURE TEST AS
  CURSOR c1
  IS
    SELECT DISTINCT C1 FROM T1;
BEGIN
  FOR item IN c1
  LOOP
    UPDATE t1
    SET c3=(
      CASE
        WHEN c3 IS NOT NULL
        THEN c3+1
        WHEN c3 IS NULL
        THEN 1
      end)
    WHERE c1 =item.C1;
  END LOOP;
END TEST;
select * from T1 ORDER BY C1, C3;
A     105     1
A     100     2
A     108     3
B     110     1
B     104     2
B     106     3Edited by: PhoenixBai on Aug 30, 2010 12:47 PM