Update table based on a select with a where clause

Question

I am trying to update a table only for records where i have a status of changed.
Using the following code the update changes all the records putting in blank data if it is outwith the where clause.
ideas?
-- Update changed records
UPDATE IP_SURVEY_ACTIVITY_REG_NO old
SET (
old.SLPN,
old.SURVEY_DATE,
old.SEQUENTIAL_REF_NUMBER,
old.TOTAL_NUM_OF_SAMPLES,
old.TOTAL_NUM_OF_ASSOC_SAMPLES,
old.AIR_TESTS,
old.REMARKS,
old.SURVEY_DETAILS,
old.FURTHER_SURVEY_DETAILS,
old.GENERAL_COMMENTS) =
(SELECT
new.SLPN,
new.SURVEY_DATE,
new.SEQUENTIAL_REF_NUMBER,
new.TOTAL_NUM_OF_SAMPLES,
new.TOTAL_NUM_OF_ASSOC_SAMPLES,
new.AIR_TESTS,
new.REMARKS,
new.SURVEY_DETAILS,
new.FURTHER_SURVEY_DETAILS,
new.GENERAL_COMMENTS
FROM IP_SURVEY_ACTIVITY_REG_NO_INT new
WHERE new.load_id = v_load_id
AND new.status = 'CHANGED'
AND new.sarn = old.sarn);
cheers bjorn

Answer 1

The EXISTS claue just needs to be added to your original query as a predicate on the ip_survey_activity_reg_no table. somethign like:
UPDATE ip_survey_activity_reg_no old
SET (old.slpn, old.survey_date, old.sequential_ref_number,
     old.total_num_of_samples, old.total_num_of_assoc_samples,
     old.air_tests, old.remarks, old.survey_details,
     old.further_survey_details, old.general_comments) =
                     (SELECT new.slpn, new.survey_date,
                             new.sequential_ref_number,
                             new.total_num_of_samples,
                             new.total_num_of_assoc_samples, new.air_tests,
                             new.remarks, new.survey_details,
                             new.further_survey_details,new.general_comments
                      FROM ip_survey_activity_reg_no_int new
                      WHERE new.load_id = v_load_id and
                            new.status = 'CHANGED' and
                            new.sarn = old.sarn)
WHERE EXISTS (SELECT 1 FROM ip_survey_activity_reg_no_int new
              WHERE new.load_id = v_load_id and
                    new.status = 'CHANGED' and
                    new.sarn = old.sarn)An updateable join view is similar, except you just join the two tables. Assuming that sarn is the primary key of ip_survey_activity_reg_no_int, or is at least declared as unique in that table, then the update of the join would look something like:
UPDATE (SELECT old.slpn oslpn, old.survey_date osurvey_date,
               old.sequential_ref_number osequential_ref_number,
               old.total_num_of_samples ototal_num_of_samples,
               old.total_num_of_assoc_samples ototal_num_of_assoc_samples,
               old.air_tests oair_tests, old.remarks oremarks,
               old.survey_details osurvey_details,
               old.further_survey_details ofurther_survey_details,
               old.general_comments ogeneral_comments,
               new.slpn nslpn, new.survey_date nsurvey_date,
               new.sequential_ref_number nsequential_ref_number,
               new.total_num_of_samples ntotal_num_of_samples,
               new.total_num_of_assoc_samples ntotal_num_of_assoc_samples,
               new.air_tests nair_tests, new.remarks nremarks,
               new.survey_details nsurvey_details,
               new.further_survey_details nfurther_survey_details,
               new.general_comments ngeneral_comments
        FROM ip_survey_activity_reg_no old, ip_survey_activity_reg_no_int new
        WHERE new.sarn = old.sarn and
              new.status = 'CHANGED' and
              new.load_id = v_load_id)
SET oslpn = nslpn,
    osurvey_date = nsurvey_date,
    osequential_ref_number = nsequential_ref_number,
    ototal_num_of_samples = ntotal_num_of_samples,
    ototal_num_of_assoc_samples = ntotal_num_of_assoc_samples,
    oair_tests = nair_tests,
    oremarks = nremarks,
    osurvey_details = nsurvey_details,
    ofurther_survey_details = nfurther_survey_details,
    ogeneral_comments = ngeneral_commentsHTH
John
Message was edited by:
John Spencer
Honest, Eric wasn't there when I posted :-)