Using Thread in Helper Class Used By MDB

Question

Using Thread in Helper Class Used By MDB
I am writting one Message driven bean (MDB) which will be deployed on
weblogic 6.1.
In MDB.onMessage I create instance of helper class.
call it's method HelperClass.doSomething(s1,s2)
in doSomething I start new thread
checks if thread is alive
when thread is dead return flag
run method of helper class does following
1. opens socket connection to some server
2. writes some data to it
3. read some data from it
4. depending on response set flag
I want to know whether this approach is corect.
Specially when weblogic recommends not to use threads (or be extreamly
careful about thread handling) .
Following is code..
MessageDrivenBeanClass{
     puboic void onMessage(Message msg){
          String s1 = "s1";
          String s2 = "s2";
          HelperClass helper = new HelperClass();
          boolean flg = helper.doSomething(s1,s2);
HelperClass implements Runnable {
     String s1;
     String s2;
     boolean flg = false;
     public void HelperClass(){}
     public boolean doSomething(String s1, String s2){
          this.s1 = s1;
          this.s2 = s2;
          Thread t1 = new Thread(this);
          t1.start();
          while(true)
          if(!t1.isAlive())
               break;
          return flg;
     public void run(){
          // do actual processing
          if(something)
               flg = true;
          else
               flg = false;

Answer 1

What is the purpose of creating an extra thread in this scenario (if your
code is going to wait until thread terminates anyway) ?
Also, creating new threads can be expensive, so it is always better to use
thread pool and not to create new thread every time.
And,
Thread t1 = new Thread(this);
t1.start();
while(true)
if(!t1.isAlive())
break;
is going to waste ALOT of CPU time. t1.join() will work much better.
sk <[email protected]> wrote:
Using Thread in Helper Class Used By MDB
I am writting one Message driven bean (MDB) which will be deployed on
weblogic 6.1.
In MDB.onMessage I create instance of helper class.
call it's method HelperClass.doSomething(s1,s2)
in doSomething I start new thread
checks if thread is alive
when thread is dead return flag
run method of helper class does following
1. opens socket connection to some server
2. writes some data to it
3. read some data from it
4. depending on response set flag
I want to know whether this approach is corect.
Specially when weblogic recommends not to use threads (or be extreamly
careful about thread handling) .
Following is code..
MessageDrivenBeanClass{
     puboic void onMessage(Message msg){
          String s1 = "s1";
          String s2 = "s2";
          HelperClass helper = new HelperClass();
          boolean flg = helper.doSomething(s1,s2);
HelperClass implements Runnable {
     String s1;
     String s2;
     boolean flg = false;
     public void HelperClass(){}
     public boolean doSomething(String s1, String s2){
          this.s1 = s1;
          this.s2 = s2;
          Thread t1 = new Thread(this);
          t1.start();
          while(true)
          if(!t1.isAlive())
               break;
          return flg;
     public void run(){
          // do actual processing
          if(something)
               flg = true;
          else
               flg = false;