1 record 2 tables. Identity duplication issue

Question

Hi,
I have to add a file info in two different tables: the first one is the dictionary and the second one is used to store the file.
The issue is the IDs set in the second table is not correct. Could you please let me know if you see anything wrong in the following SQL:
-- Insert in the dicctionary
INSERT INTO DB1.[dbo].[FilesDictionary]
(FileRef,
FileDescription)
VALUES (@FileRef,
@FileDescription);
--Get the diccionary ID
SELECT @FileDictionaryID = SCOPE_IDENTITY()
-- Save the file in the second table using the dictionary ID as reference
INSERT INTO DB2.[dbo].[FilesStore]
(FileDictionaryID
,FileAttachment)
SELECT FileDictionaryID
, @FileAttachment
FROM DB1.[dbo].[FilesDictionary]
WHERE FileDictionaryID = @FileDictionaryID
Issue: System is saving the info like this sometimes:
Table:DB1.[dbo].[FilesDictionary]
FileDictionaryID       FileDescription
123                         Test
124                         Test
DB2.[dbo].[FilesStore] -- Files are saved in another DB for storage limitation and the FileDiccionaryID is the link between both DBs
FileDicionaryID        FileAttachment
124                         --file string
<-- this id should have been 123 instead of 124
124                         --file string
Should I use @@identity instead of scope_identity()? Is there any other issue? I think scope_identity()  is correct based on the theory but just to be sure.
Thanks for your help

Answer 1

Hi,
Thanks both for your replies. I really appreciate it.
FilesDictionaryID is the primary key in the FilesDictionary table but not in the FilesStore table. So FilesDiccionaryID is always unique in the FilesDictionary table but could be duplicated in the FilesStore table (it shouldn't, based on the previous code).
Those tables are updated by the application which is calling this SP so no one could set this manually.
I am working with SQL Server 2008 so Jn_ds could be right but I am already using the OUTPUT when the variable @FilesDictionaryID is declared so...
It’s hard to test this because I couldn't reproduce the issue but DB data shows this issue is happening…
I am going to investigate about the SQL Server 2008 bug but any suggestion in the meantime is welcome :) Thanks!