2 different select statements

Question

I'm needing to use a if statement in a sql query. I have written an if statement to handle it but it won't work I think due to the 2 statements return different values. How would I make this work:
ALTEr PROCEDURE [dbo].[spBookings]
@callAgentID VARCHAR(3),
@optionReg nvarchar (20),
@optionRank nvarchar(20),
@optionBook nvarchar(20)
--@TaxID VARCHAR(50)
AS
Begin
if @optionReg= 'All' AND @optionRank='All' AND @optionBook='Not Booked'
BEGIN
(SELECT ID, RegNo, OwnerName AS OwnName, OwnerSurname AS OwnSurname, OwnerCell As OwnCell, DriverName As DriveName, DriverSurname
As DriveSurname, DriverCell,TaxiRanks AS Rank, Region, Area, Model,Reward FROM Taxis WHERE callAgentID = @callAgentID AND Value2<
GETDATE()
OR callAgentID = @callAgentID AND Value2 IS NULL
OR callAgentID = @callAgentID AND Value2='')
ORDER BY Taxis.ID
END
if @optionReg != 'All' AND @optionRank='All' AND @optionBook='Booked Boet'
BEGIN
SELECT
Taxis.ID,
Taxis.RegNo,
Taxis.OwnerName AS OwnName,
Taxis.OwnerSurname As OwnSur,
Taxis.OwnerCell As OwnCell,
Taxis.DriverName As DriveName,
Taxis.DriverSurname AS DriveSur,
Taxis.DriverCell,
Taxis.TaxiRanks As Rank,
Taxis.Region,
Bookings.Complete AS Comp,
Bookings.CampaignID AS CampID,
Bookings.ID AS JobNum,
Taxis.RankBookedAt,
Bookings.SlotDate As Date,
Bookings.SlotTime As Time,
Bookings.SmsStatus AS Sms,
Bookings.Reward
FROM Taxis INNER JOIN Bookings ON Bookings.TaxiID=Taxis.ID
WHERE Taxis.callAgentID = @callAgentID AND Taxis.Value2> GETDATE() AND Bookings.Active='y')
Order By Taxis.ID
END
END

Answer 1

Try the below:
ALTEr PROCEDURE [dbo].[spBookings]
@callAgentID VARCHAR(3),
@optionReg nvarchar (20),
@optionRank nvarchar(20),
@optionBook nvarchar(20)
--@TaxID VARCHAR(50)
AS
Begin
if (@optionReg= 'All' AND @optionRank='All' AND @optionBook='Not Booked')
BEGIN
SELECT ID, RegNo, OwnerName AS OwnName, OwnerSurname AS OwnSurname, OwnerCell As OwnCell, DriverName As DriveName, DriverSurname
As DriveSurname, DriverCell,TaxiRanks AS Rank, Region, Area, Model,Reward FROM Taxis WHERE callAgentID = @callAgentID AND Value2<
GETDATE()
OR callAgentID = @callAgentID AND Value2 IS NULL
OR callAgentID = @callAgentID AND Value2=''
ORDER BY Taxis.ID
END
if (@optionReg != 'All' AND @optionRank='All' AND @optionBook='Booked Boet')
BEGIN
SELECT
Taxis.ID,
Taxis.RegNo,
Taxis.OwnerName AS OwnName,
Taxis.OwnerSurname As OwnSur,
Taxis.OwnerCell As OwnCell,
Taxis.DriverName As DriveName,
Taxis.DriverSurname AS DriveSur,
Taxis.DriverCell,
Taxis.TaxiRanks As Rank,
Taxis.Region,
Bookings.Complete AS Comp,
Bookings.CampaignID AS CampID,
Bookings.ID AS JobNum,
Taxis.RankBookedAt,
Bookings.SlotDate As Date,
Bookings.SlotTime As Time,
Bookings.SmsStatus AS Sms,
Bookings.Reward
FROM Taxis INNER JOIN Bookings ON Bookings.TaxiID=Taxis.ID
WHERE Taxis.callAgentID = @callAgentID AND Taxis.Value2> GETDATE() AND Bookings.Active='y'
Order By Taxis.ID
END
END
The conditions separated by OR has to be wrapped within barckets otherwise it wont work as intended
ie like below
.....WHERE callAgentID = @callAgentID AND Value2<
GETDATE()
OR (callAgentID = @callAgentID AND Value2 IS NULL)
OR (callAgentID = @callAgentID AND Value2='')
ORDER BY Taxis.ID....
Please Mark This As Answer if it helps to solve the issue Visakh ---------------------------- http://visakhm.blogspot.com/ https://www.facebook.com/VmBlogs