Access and Dates

Question

Hi all I am having trouble retreiving data from an access dataabse and displaying the result in a jTextArea.
1) The first problem that I encounter is that I want to query on a specific date. Yet due my date being a string in my code and a date/time in access in gives me a type mismatch error? How do I resolve this?
2) The next error might be due to the above error. When I run the query without the date parameter it only displays the last line of my recordset and I cant figure out why!
heres the code
public void getDate()
    SimpleTimeZone tz = new SimpleTimeZone(0 * 60 * 60 * 1000, "GMT");
    tz.setStartRule(Calendar.APRIL, 1, Calendar.SUNDAY, 2 * 60 * 60 * 1000);
    tz.setEndRule(Calendar.OCTOBER, -1, Calendar.SUNDAY, 2 * 60 * 60 * 1000);
    SimpleDateFormat formatter = new SimpleDateFormat("dd/MM/yyyy");
    formatter.setTimeZone(tz);
    date = formatter.format(new Date());
    dateLabel.setText(date);
    getCurrentLeaders();
    this.getContentPane().add(jTextArea1,  new XYConstraints(15, 41, 312, 201));
    this.getContentPane().add(jButton2,   new XYConstraints(234, 253, 94, 22));
    this.getContentPane().add(jButton1, new XYConstraints(139, 253, 94, 22));
    getCurrentLeaders();
  public void getCurrentLeaders()
    String query = "SELECT Date,PayNo,Full_Name,DeptNo,Current_Points FROM qryDailyLeagueTable";
/* I had this line here: WHERE Date  = '" + date+ "'"
date is set above, yet this cause an error*/
    try
      results = statement.executeQuery(query);
      while (results.next())
        String payNo = results.getString("PayNo");
        String Full_Name = results.getString("Full_Name");
        String DeptNo = results.getString("DeptNo");
        int Current_Points = results.getInt("Current_Points");
        jTextArea1.append("\n" + payNo + "\t" + Full_Name+ "\t " + DeptNo + "\t" + Current_Points);
    catch (SQLException e)
      e.printStackTrace();
  }Please please help as I am really stuck!
Thanks in advance,
Z.

Answer 1

Your Access column should be a Date/Time type.
You should use PreparedStatement and its setDate method - that's the only DB-independent way to escape Dates properly:
Your code is awful for a few other reasons, though.
You've got database and UI code mingled together. Ever heard of MVC separation? There's no sensible reason to do this.
Looks like you're declaring connection, statement and results as data members. Better to have them as local variables.
You don't close your statement or result set when you're done with them. That's trouble, especially with Access. It might work out for a query, but the moment you try to do an INSERT/UPDATE/DELETE you'll be another person posting about how your changes don't "stick" in Access.
You have a column named "Date" in your table? Not only is it unclear, but it's asking for trouble. Making keywords table or column names are sure to confuse the parser and any programmer who might read your code later.
I'd write it like this:
// static - no need to evaluate more than once
// Note column name change
private static final String SELECT_LEADERS
= "SELECT  "
+ "ChangeDate,PayNo,Full_Name,DeptNo,Current_Points "
+ "FROM qryDailyLeagueTable "
+ "WHERE ChangeDate  = ?";
public List getCurrentLeaders(Connection connection, Date thisDate) throws SQLException
    List currentLeaders = new ArrayList();
    Statement statement = null;
     ResultSet rs = null;
     try
           statement = connection.prepareStatement(SELECT_LEADERS);
           statement.setDate(1, thisDate);
           results = statement.executeQuery();
           while (results.next())
              String payNo = results.getString("PayNo");
              String fullName = results.getString("Full_Name");
              String deptNo = results.getString("DeptNo");
              int currentPoints = results.getInt("Current_Points");
               // Note: you'll have to write this class
               Leader leader = new Leader(payNo, fullName, deptNo, currentPoints);
               currentLeaders.add(leader);  
     // No need to catch - you weren't doing anything with a SQLException, anyway. 
     // Let the calling class deal with it.
     finally
           try { if (rs != null) rs.close(); } catch (SQLException e) {}
           try { if (statement != null) statement.close(); } catch (SQLException e) {}
      return currentLeaders;
}Now have your UI call this method, get the List of leaders, and then display it. The UI shouldn't have any database code in it, and the data access classes shouldn't have any UI in them.
%