Another thread problem

Question

in the below code, a thread is created which waits for new clients to connect, then giving them a thread of which to communicate with the server. Now, instead of say creating 2 threads for 2 clients, everytime a message is sent a new thread is created. Any ideas on how to stop this?
class ClientWorker implements Runnable {
  Socket client;
     ServerSocket server = null;
     ClientWorker(Socket client) {
   this.client = client;
public void whiletruemethod() {
while(true){
      ClientWorker w;
      try{
        w = new ClientWorker(server.accept());
        t = new Thread(w);
        t.start();
      } catch (IOException e) {
        System.out.println("Accept failed: 4444");
        System.exit(-1);
public void threadtmethod() {
BufferedReader in = null;
PrintWriter out = null;
    try{
      in = new BufferedReader(new InputStreamReader(client.getInputStream()));
      out = new PrintWriter(client.getOutputStream(), true);
    } catch (IOException e) {
      System.out.println("in or out failed");
      System.exit(-1);
          dontgo = "2";
          String line;
    while(true){
          System.out.println("RUN");
            try{
        line = in.readLine();
                    if(line != null) {
                    //Send data back to client
         out.println(line);
                         messlistArea.append("BLAH " + line + "\n");
       } catch (IOException e) {
         System.out.println("Read failed");
         System.exit(-1);
                                   try { Thread.sleep(2000); }
               catch(InterruptedException e) {}
  public void run(){
     if (t.equals(Thread.currentThread()) )
               System.out.println("Running t Thread");
               threadtmethod();
  if (whiletrue.equals(Thread.currentThread()) )
               System.out.println("Running Thread");
               whiletruemethod();
  public void listenSocket(){
     thisserver = 1;
    try{
      server = new ServerSocket(4444);
    } catch (IOException e) {
      System.out.println("Could not listen on port 4444");
      System.exit(-1);
     whiletrue = new Thread(this);
     whiletrue.start();
     }

Answer 1

Have you thought of using the PoolExecutor by Dough Lea, to handle your thread creation and execution ?
Its nice and easy to use, and most important works...!