ApEx collection problem

Question

Hi there,
I'm trying to create a collection within an ApEx process. My intention is to create a cursor (only 1 in the example but I want to add more in the future) and fill the collection with the data the cursor finds.
However the application gives the following error: ORA-06550: line 29, column 51: PL/SQL: ORA-00917: missing comma ORA-06550: line 28, column 1: PL/SQL: SQL Statement ignored. I know that the error probably is found somewhere else in the code. Can someone help me?
declare
cursor skill1_cur is
SELECT emp_id, esk_lvl_id
FROM stf_employees
JOIN stf_emp_skill ON emp_id = esk_emp_id
WHERE esk_skl_id = :P4000_SKILL_1
AND esk_lvl_id between :P4000_LVLF_1 AND :P4000_LVLT_1;
begin
if apex_collection.collection_exists('storevalues') then
apex_collection.delete_collection(p_collection_name => 'storevalues');
end if;
apex_collection.create_collection('storevalues');
for l_skill1_cur1 in skill1_cur loop
insert into
apex_collection.add_member(p_collection_name => 'storevalues',
p_c001 => skill1_cur.emp_id,
p_c001 => skill1_cur.esk_lvl_id);
end loop;
end;
Best regards
Apex version: Application Express 4.2.1.00.08

Answer 1

It is usefull to use a formating tool for your code since it tells you imediatelly if your code has the right syntax. Here is a code which may help:
DECLARE
   CURSOR skill1_cur
   IS
      SELECT emp_id, esk_lvl_id
        FROM stf_employees JOIN stf_emp_skill ON emp_id = esk_emp_id
       WHERE esk_skl_id = :p4000_skill_1
         AND esk_lvl_id BETWEEN :p4000_lvlf_1 AND :p4000_lvlt_1;
   v_collection_name   VARCHAR2 (30) := 'STOREVALUES';
BEGIN
   IF apex_collection.collection_exists (v_collection_name)
   THEN
      apex_collection.delete_collection
                                      (p_collection_name      => v_collection_name);
   END IF;
   apex_collection.create_collection (v_collection_name);
   FOR l_skill1_cur1 IN skill1_cur
   LOOP
      apex_collection.add_member (p_collection_name      => v_collection_name,
                                  p_c001                 => skill1_cur.emp_id,
                                  p_c002                 => skill1_cur.esk_lvl_id
   END LOOP;
END;A couple of things to consider:
1. Collection Name has to be capitalized
2. You don't need an insert into when inserting data into a collection - there is a procedure which does that
3. you have an error in calling the add_member procedure - you used the parameter p_c001 twice
I am not sure if this works for you since I have no access to the objects underneath your code.
Denes Kubicek
http://deneskubicek.blogspot.com/
http://www.apress.com/9781430235125
http://apex.oracle.com/pls/apex/f?p=31517:1
http://www.amazon.de/Oracle-APEX-XE-Praxis/dp/3826655494
-------------------------------------------------------------------