Arrays.equals doesnt seem to be working

Question

Hi
i have an app that copys the contents of an object array into another, then reruns and compares its contents to the previous copy. they should be equal, but i get a not equal message. i have tried printing out the objects in a loop to see whats happening, i get this:
(code)
for(int i = 0; i < count; i++)
System.out.println(TestPcContainer);
System.out.println(TestPcContainerCopy[i];
output:
Thread[Thread-20,5,main] (orig element 0)
Thread[Thread-15,5,main] (copy element 0)
Thread[Thread-21,5,main] (orig element 1
Thread[Thread-16,5,main] (copy element 1)
Thread[Thread-22,5,main] (orig element 2)
Thread[Thread-17,5,main] (copy element 2)
i dont understand why i keep getting its not equal. i have copied the arrays using : System.arraycopy(TestPcContainer, 0, TestPcContainerCopy, 0, count);
and i compare by doing: if(Arrays.equals(TestPcContainer, TestPcContainerCopy)) { System.out.println("equal");}else not ......
thanx for any help on this
ness

Answer 1

ok,heres the code:
ckage tmhealthproject;
import com.xyratex.utils.EventHandler;
import com.xyratex.utils.EventInterface;
import com.xyratex.xyrmi.io.XYRMIMessageHandler;
import com.xyratex.xyrmi.io.XYRMIObjectInterface;
import com.xyratex.xyrmi.tcp.XYRMIClient;
import java.io.*;
import java.net.UnknownHostException;
import jicmp.*;
import java.util.*;
* <p>Title: TMHealthStatusTestPc </p>
* <p>Description: Class reads in ip addresses from IpAddress.txt, then creates 16 new
* TMHealthStatusTestPc objects, allocating each one an ip address from the txt file. Each object represents
* a tm, and holds 3 fields of data: ipaddress, Morb and TM. These attributes are set to 1 or a zero depending
* on whether the tm is on or offline, its orb is running and the TestManager software is running. Once these
* checks have been done, the data is sent to the calling application, either terminal or applet.
* <p>Copyright: Copyright (c) 2003</p>
* <p>Company: Xyratex</p>
* @author Vanessa Radford
* @version 1.0
public class TestPc extends Thread implements XYRMIMessageHandler, EventInterface
FileReader filereader;
BufferedReader bufferedreader;
String ipaddress = new String();
int count;
TestPc TestPcContainer[];
TestPc TestPcContainerCopy[];
TestPc testpc = null;
int ipvalid = 0;
int morbvalid = 0;
int tmvalid = 0;
int result = 0;
String tmname = new String();
String host = "127.0.0.1";
String className = "className";
String objectName = "broadCast";
int port = 9765;
String object = new String("Object:");
XYRMIClient Orblink;
XYRMIClient Orblink1[];
XYRMIClient Orblink2[];
String initalMessage1 = (objectName + " " + className + "1 ");
String initalMessage2 = (objectName + " " + className + "2 ");
String initialMessage3 = (objectName + " " + className + "3 ");
EventHandler StatusRequestTimer = null;
EventHandler StatusResponseTimer = null;
int counter = 0;
String viewMessage = (objectName + " StatusView " + "status " + "numberoftms:");
*</p> This method opens the TMipaddress.txt file, reads in each line, creates a
* TMHealthStatusTestPc object for each line that is read in, and assign it an ip address.
* These objects are then stored into a container called TestPcContainer</p>
public void initializeObjects()
counter ++;
//set a count variable to zero. this variable sets the sizes of the Container and Orblink arrays
count = 0;
//try to find the file TMipaddress.txt
try
filereader = new FileReader("TMipaddress.txt");
bufferedreader = new BufferedReader(filereader);
//count how many ip addresses it holds
while ((ipaddress = bufferedreader.readLine()) != null)
count ++;
catch(IOException ioexception)
System.out.println(ioexception.getMessage());
//open the file again and read each line
//now we have the number of tms in the txt file, call the setArraySizes method
//and send it the count variable. This will inialize the containers and arrays to the correct size
setArraySizes(count);
TestPcContainer = new TestPc[count];
try
filereader = new FileReader("TMipaddress.txt");
bufferedreader = new BufferedReader(filereader);
for(int i = 0; i < count; i++)
//for each ip address create a new testpc object
testpc = new TestPc();
//read in each line from the txt file
ipaddress = bufferedreader.readLine();
//create a tokenizer object for each line, and ignore any tabs, spaces or newlines
StringTokenizer str = new StringTokenizer(ipaddress, " \n\t\r,");
//send to the setTmName method the first part of the line which holds the tm name
testpc.setTmName(str.nextToken());
//send to toe setIp method the second part of the line whcih holds the ip address
testpc.setIp(str.nextToken());
//add the object to the container
TestPcContainer[i] = testpc;
catch(IOException e)
//call the method that checks the ip addresses
checkIp();
*<p>This method creates a new ICMPPing object in a loop, and passes in a TestPc object
* as an argument to its constructor. The ICMPPing object extracts the TestPcs host ip
* address and conducts an ICMP ping on it. The result of this is passed back into setIPValid.
* The loop ends when all of the TestPc objects stored in the container have been passed in.
* There is then a 10 second sleep for the data to be collected, then the morb is done </p>
*@param pc Takes a TMHealthStatusTestPc object as its argument
public void checkIp()
for(int i = 0; i < count; i++)
//create a new ICMPPing object and pass in each object in the container
ICMPPing checkIPAddress = new ICMPPing(TestPcContainer);
try
//sleep so that the data can be collected
Thread.sleep(2000);
catch(Exception e)
System.out.println("message in checkip is " + e.getMessage());
//call the morb check
System.out.println("checking morbavail");
checkMorbAvail();
public int doSomething()
if(counter != 1)
if(Arrays.equals(TestPcContainer, TestPcContainerCopy))
StatusRequestTimer();
else
sendRMI();
StatusRequestTimer();
if(counter ==1)
sendRMI();
StatusRequestTimer();
return 1;
public void setArraySizes(int count)
TestPcContainer = null;
if(TestPcContainerCopy == null)
TestPcContainerCopy = new TestPc[count];
if(Orblink1== null)
Orblink1 = new XYRMIClient[count];
if(Orblink2 == null)
Orblink2 = new XYRMIClient[count];
*<p>Method to send RMI message to StatusView applet. Checks to see if an OrbLink has already been created,
* if so uses XYRMIMessageHandler to forward message. Otherwise registers with the Orb of the TM and forwards
* message within registration</p>
*@return int
public int sendRMI()
StringBuffer ipbuffer = new StringBuffer();
for (int t = 0; t < count; t++)
t++;
ipbuffer.append(" Object" + t + ":");
t--;
ipbuffer.append("\"" + TestPcContainer[t].getTmName() + ",");
if(TestPcContainer[t].ipvalid == 1)
if(TestPcContainer[t].morbvalid == 1)
if(TestPcContainer[t].tmvalid == 1)
ipbuffer.append("OK\"");
else
ipbuffer.append("NoTestMan\"");
else
ipbuffer.append("NoOrb\"");
else
ipbuffer.append("TimedOut\"");
String result = ipbuffer.toString();
try
if(counter != 1)
Orblink.XYRMIMessageHandler(viewMessage + "\"" + count + "\"" + result);
else
Orblink = new XYRMIClient(this, host, port, viewMessage + "\"" + count + "\"" + result);
Orblink.SetIdentity(className, objectName);
Orblink.start();
catch(Exception e)
System.out.println("error in sendrmi " + e.getMessage());
return 1;
*<p>This method runs the applicatoin every 60 seconds, so that accurate data is recorded</p>
public void StatusRequestTimer()
StatusRequestTimer = new EventHandler(this, "message");
StatusRequestTimer.initialise();
StatusRequestTimer.startEvent(90);
public void eventMessage(Object obj, String s)
if(obj == StatusRequestTimer)
System.arraycopy(TestPcContainer, 0, TestPcContainerCopy, 0, count);
TestPcContainer = null;
testpc = null;
initializeObjects();
*<p>method to set an ip address </p>
*@param ipadd IP address
public void setIp(String ipadd)
ipaddress = ipadd;
public void setTmName(String tm)
tmname = tm;
*<p>method to get an ip address</p>
*@return string ip address
public String getIp()
return ipaddress;
public String getTmName()
return tmname;
*<p>method to get whether the tm was valid, meaning it responded or not. /p>
*@return string ip address
public int getTmValid()
return tmvalid;
*<p>method to get whether the ip address was valid, meaning online or not, 1 for valid, 0 for not</p>
*@return string ip address
public int getIpValid()
return ipvalid;
*<p>method to get whether the morb on the TestPc is running or not, 1 for valid, 0 for invalid</p>
*@return int morbValid
public int getMorbValid()
return morbvalid;
*<p>method to set validity of the ip addres, recieves result from TMHealthStatusICMPcheck</p>
*@param result passed in result of validity check on ip address, 1 for valid, 0 for invalid</p>
public void setIPValid(int result)
ipvalid = result;
*<p>method to set validity of the Morb to the result</p>
*@param result passed in result of validity check on morb, 1 for valid, 0 for invalid</p>
public void setMorbValid(int result)
morbvalid = result;
*<p>method to set validity of the Morb to the result</p>
*@param result passed in result of validity check on morb, 1 for valid, 0 for invalid</p>
public void setTmValid(int result)
tmvalid = result;
*<p>method to create new XYRMIClient object, pass to it a TMHealthStatusTestPc object, extract
* its ip address, then send an rmi message to the orb of that machine. Used to check if the TestPc's
* Orb is runnning.
*@param pc TMHealthStatusTestPc object
public int checkMorbAvail()
for(int q = 0; q < count; q++)
if(TestPcContainer[q].getIpValid() == 1)
host = TestPcContainer[q].getIp();
if(counter != 1)
Orblink1[q].XYRMIMessageHandler(initalMessage2 + host);
}//close if
else
try
Orblink1[q] = new XYRMIClient(this, host, port, initalMessage2 + host);
Orblink1[q].SetIdentity(className + "2", objectName);
Orblink1[q].start();
} //close try
catch(Exception e)
System.out.println("error in checkmorbavail" + e.getMessage());
}//close catch
}//close if
try
Thread.sleep(30000);
catch(Exception e)
System.out.println("errror here");
checkTmAvail();
return 1;
*<p>method to register with the Orb and send a message to its TestManager. If successful sends
* initial message consisting of the ip address of the TestPc plus "tm" attached to the end.
* Used to check whether the TestManager software is running on that machine</p>
*@param pc takes a TMHealthStatusTestPc object as argument
public int checkTmAvail()
for(int r = 0; r < count; r++)
if(TestPcContainer[r].getMorbValid() == 1)
host = TestPcContainer[r].getIp();
if(counter != 1)
Orblink2[r].XYRMIMessageHandler(initialMessage3 + host + "tm");
else
try
Orblink2[r] = new XYRMIClient(this, host, port, initialMessage3 + host + "tm");
Orblink2[r].SetIdentity(className + "3", objectName);
Orblink2[r].start();
catch(Exception e)
System.out.println("error in checktm is " + e.getMessage());
else
System.out.println("not valid");
try
Thread.sleep(1000);
catch(Exception e)
doSomething();
StatusRequestTimer();
return 1;
*<p>method to create a new XYRMIObjectInterface to handle incoming messages. Checks to see
*whether the incoming meesage has the method name of the ipaddress of each tm meaning that its morb
*has been successfully registered with. Also checks to see if the method has the method name of
*the ipaddress of the tm plus "tm" attached to the end, meaing that the tm has successfully received
*the message and is returning with conformation. </p>
*@return int
*@param s Takes as a parameter a string
public synchronized int XYRMIMessageHandler(String s)
XYRMIObjectInterface msg = null;
XYRMIObjectInterface msg1 = null;
msg1 = new XYRMIObjectInterface(s);
if(msg1.IsMethodName("RequestTestManagerStatus"))
System.out.println("got requesttestmanstatus, sending rmi");
sendRMI();
else
for (int i = 0; i < count; i ++)
msg = new XYRMIObjectInterface(s);
try
if(msg.IsMethodName(TestPcContainer[i].getIp()))
TestPcContainer[i].setMorbValid(1);
System.out.println("setting morb valid");
if(msg.IsMethodName(TestPcContainer[i].getIp() + "tm"))
TestPcContainer[i].setTmValid(1);
System.out.println("setting tmvalid");
catch(Exception e)
System.out.println("message in xyrmimesagehandler is " + e.getMessage());
return 1;