Avoid procedure or function calls between a SQL operation and an implicit cursor test

Question

when i analyse this code with code expert

Answer 1

atpidgeon wrote:
when i analyse this code with code expert
                        UPDATE P_PM_CONTROL_COUNT
                        SET AVAIL_SEG = AVAIL_SEG -1,
                            ALLOCATION = ALLOCATION -1
                        WHERE PM_UNIT_TYPE_ID = vrectab(1)
                        AND USAGE_DATE = vrectab(2)
                        AND SEGMENT_CODE = vrectab(5)
                        AND ALLOCATION - UNITS_RESERVED > 0;
                        IF sql%rowcount = 0 then --Added block and exception to prevent invetory going negative when placing multi units in same unit type out of service.
                            vErrMsg := 'Could not process your out of service request because your selection for unit '|| vrectab(3) || ' at ' || pvPropertyId || ' for ' || vrectab(2) || ' would cause segment ' || vrectab(5) || ' to be over allocated.';
                            RAISE SegOverAllocated;
                        END IF;
i get "Avoid procedure or function calls between a SQL operation and an implicit cursor test.",as far has i know
iff you're doing a sql%rowcount    after an update.. trying to see how many rows were updated...  you dont want procedure or function calls between the update and the sql% line
correct me if im wrong and how would i fix it?or maybe i shouldnt
You correct it by NOT executing function calls as part of the UPDATE statement.
1. Issue the function calls BEFORE the update statement
2. save the function results into variables
3. use those variables in the UPDATE statement.
v_rectab1 := vrectab(1);
v_rectab2 := vrectab(21);
v_rectab5 := vrectab(5);
UPDATE P_PM_CONTROL_COUNT 
                        SET AVAIL_SEG = AVAIL_SEG -1,
                            ALLOCATION = ALLOCATION -1
                        WHERE PM_UNIT_TYPE_ID = v_rectab1
                        AND USAGE_DATE = v_rectab2
                        AND SEGMENT_CODE = v_rectab5
                        AND ALLOCATION - UNITS_RESERVED > 0;