Bad coding

i'm in a web design class, and the coding for the project i'm doing is bad and i can't figure it out. will someone please tell me what's wrong with the coding?
<HTML>
<HEAD>
     <TITLE>Fun with Phonics</TITLE>
</HEAD>
<BODY>
<CENTER><IMG SRC="fun.jpg" HSPACE=5 VSPACE=5 HEIGHT=64 WIDTH=129></CENTER>
<CENTER><HR Width="75%"></CENTER>
<script language="javascript">
<!--Hide from old browsers
    document.bgColor="red"
    document.bgColor="white"
    document.bgColor="blue"
    document.bgColor="white"
    document.bgColor="green"
    document.bgColor="white"
    document.bgColor="pink"
   var tNow = new Date()
    var tlocDate =
tnow.toLocaleString()
    var tDate =
tlocDate.substring(0,10)
    document.write("<H2><center> Welcome, Today is "+tDate+"</center></h2>")
    var intro1 = "Hi, thanks for visiting our Web site, but we have moved. Please make a note "
    var intro2 = "of our new URL (www.funphonics.com) and notify the WEbmaster about our new "
   var intro3 = "location. Click<a href='http://www.scsite.com/'> here </a> or wait 15 seconds "
    var intro4 = "to be moved automatically to our new site."
    var introMesg = intro+intro2+intro3+intro4
    document.write("<h4><font color='firebrick'>"+introMsg+"/h4></font>")
</BODY>
</HTML>thank you

You should consider posting your question on a forum more appropriate to web design. This forum should be used for Java questions.
Thanks!

Similar Messages

A simple question about bad coding

Hi, to cut a long story short i am coding a small section that changes the colour of a panel depending on the hour of the day, however i don't want to write 24 if statements to check what the hour is, now i have been coding all day and am having a bit of a mental block....can anybody think of another solution?
If not, would it be bad practice to have 24 if statements in a method to check such a trivial attribute?
Thanks for your help in advance

It depends on if there's a nice relationship between the condition and what is to be done depending on the condition. For instance, it would be bad to do this:
int y;
if (x == 0)
y = 5;
else if (x == 1)
y = 10;
else if (x == 2)
y = 15;
// etcbecause obviously there's a simple relationship: y = 5 * (x + 1)
I imagine in your case you could at least stick 24 values (colors or whatever) in an array, and simply index into that array, if there isn't a simple relationship like the above.

Suns standard classes use of constants - bad coding convention

Wasn't sure where to post this, it didn't quite fit into Java Runtime Environment or Java Virtual Machine forums.
I was browsing through The Java Standard classes and was amazed by their use of constants. Throughout the codes there is inserted direct constants in the code without any use of global constant declarations.
Eg: java.lang.StringCoding:
All over the code is inserted "ISO-8859-1" (used as default encoding) directly instead of using a declared constant DEFAULTENCODING. What if Sun want to change default encoding?
Seems strange to me that such coding conventions are used by Sun. Any reason for this or just sloppy programing?
Gil

Looks like sloppy programming to me. I see no possible
reason for it. You're not the first person to
criticise Sun's source code. Maybe they outsourced it
to http://www.newtechusa.com/PPI/main.asp (I can never
remember how to format links, no matter how often
people tell me!)
RObinThere's logic in getting primates to program.
Based on the popular theory that an infinite number of monkeys could
randomly produce the works of Shakespeare, they could also produce the perfect software implementation of any given problem. The downside being that the printed documentation will be smeared liberally with faeces.
regards,
Owen

Is this bad coding style?

I have come across a price- winning GUI library for java (JSuite from Infragistics).
A lot of high quality GUI- components... Now, I am trying to understand the code.
Here are three of the code- lines
if(m_iCurM > 0) iDay |= ((m_iCurY << 9) | ((m_iCurM - 1) << 5));
if(bar != 1000 || (r.width -= w0) < 2) return;
while(++i < m_days.size()) if((j = ((PVDay)m_days.elementAt(i)).m_id0) >= 0) return get(j);Its all like that! Short names, non- descriptive names, long lines and magic values.
If I wrote code like that, my boss would kill me.

Well, I guess I should give you more that three lines...
and the m_ is not the problem! If someone adds information to the code, like m_... meaning this is a member, or m_i... meaning this is a member integer, that is all nice.
But,     void drag(MouseEvent e)
          PVDay d = null, d0 = (PVDay)e.getSource(), old = dayAt(m_z1);
          Rectangle r = d0.getBounds();
          int x = e.getX() + r.x, y = e.getY(), num = getNumberOfDays() + 1;
          int i = num * getNumberOfWeeks();
          while((d = dayAt(--i)) != null)
               if(d.getBounds().contains(x, y + r.y)) break;
          // 0x0000007f - ? ** (id for PVWeek)
          // id of day under mouse
          i = (d == null) ? 0 : (d.m_2 & 0x0000007f);the local identifiers d, d0, r, x and i could have longer and more descriptive names...
And the line while(++i < m_days.size()) if((j = ((PVDay)m_days.elementAt(i)).m_id0) >= 0) return get(j); is just the same aswhile(++i < m_days.size())
   j = ((PVDay)m_days.elementAt(i)).m_id0;
   if(j >= 0)
      return get(j);
}, so why not use the later? It compiles to the same result!
And this is not obfuscated. This is the code they are selling. Its even commented (as you can see), and thats helping a little bit, but still!
And its not an inner loop heavy super-optimized algorithm. All the code is like this. Thousands of lines...

About BADI Coding

Hello Experts,
1. I have to update a Table (Ztable) using SD_COND_SAVE_A for any changes to pricig conditions PB00 entered through TCODE VK11, VK12, VK31, VK32.
I have also to mapp this Z table with Material Master & Condition Record.
How to code for this.
Please help me in details. <removed_by_moderator>
Regards,
Anshuman
Edited by: Julius Bussche on Oct 20, 2008 1:45 PM

You have parameters in CONDITION_SAVE_EXIT like:
CT_KONH_NEW
CT_TIME
CT_KONPDB_NEW..and so on
see in debugger(by writing Break-point) , values in these structure are already filled by VK** transaction, by using these structure values you may update your Ztable as same as we do in report programs.

Bad Coding Hell

I'm converting 90+ character-mode Forms 6 forms (many of which were originally written in Forms 2!) to Forms 9i. I've been here since the Big Move To Forms 3, so I know the forms pretty well at least.
However, there is so much strange code in here it worries me. Most of it is probably due to programmers new to Forms at the time of design and the lack of some of the triggers we know and love today.
My main problems are:
i. Validation on navigation triggers (there's literally thousands of these triggers, so I've been tidying them up since Forms 4.5).
ii. Non-database items that are then moved into database items (because, for instance, an amount is held on the database as a negative figure yet entered as a positive one!).
My current bug-bear is how to ensure KEY-NEXT-ITEM is pressed from a non-database item as I can press KEY-NXTBLK from this item and bypass a lot of things. I used to use the POST-CHANGE trigger for some things but this is no longer recommended by Oracle. How best to acheive this? The WHEN-VALIDATE -ITEM triggers are, logically, more suited to database items.
Professor Yaffle

I seem to recall having validation issues with non-database items that have a WHEN-VALIDATE-ITEM trigger, although I wouldn't bet my house on it.
In answer to a question above, character-mode forms is how Forms 3 and before used to be exclusively deployed prior to the wonder of GUI - its use is removed from Forms 9, so this has forced our hand to go the GUI way (the users actually wanted to retain it as it actually affords faster input for a transaction-heavy environment).
The downside of character-mode was that it made our (Forms 6) system look very old to (even older) senior managers who didn't know any better! And it had to be run via a terminal emulator as it was deployed to a UNIX server. Forms 9i seems noticeably slower, but it certainly looks better and allows us to slowly incorporate GUI enhancements (I was desperate to do this since Forms 4.5, but development resources and mandatory work meant we've bypassed GUI. Until now.
I'd already disabled the mouse due to the aforementioned mis-use of navigation triggers for validation and we do not have any conventional menus.
My main issue remains how to test ensure KEY-NEXT-ITEM is pressed without having to untangle the trigger to seperate the navigation code from the validation code (there being thousands of triggers - I'll rewrite in slower time).

TS1702 How can i report an app for their coding

Hi, i just wonder how can i report space ape for making bad game? Their samurai siege constantly have bad coding, one instance where they advice their users to change the device clock to "work around their bugs" and do not advice other of potential harm this could do to the device, leaving quite a few losing their other game progress and work progress. On another instance is how to create a new village. One would assume that you can create the new village if you have new game center, but the server still remember the device if it was once log in. Like atm, i have 1 village on my iphone 5, and im thinking of making a new village on my ipad, but when i installed the game on my ipad, i forgot to log out of the gc, and it continually loading my iphone 5 village on my ipad. I have tried log out, delete, reinstall, etc. one should not have that much trouble trying to get a new village on a new device. Now i have two device logging each other off because of this issue, and still can't get it to give me new village.
This is bad if i log on my friend's phone to check my village, and she can't create a new game because she is stuck with my village, and i can not play mine if she open the app. This is really stupid coding. Not only these two issuse, the company constantly producing new updates, and pay no attention whatsoever on quality assurance. And i'm fed up with it, as they are continually violating apple rules.
<Edited by Host>

Contact the developer.

Question about BADI FI_AUTHORITY_ITEM in ECC 6.0

Dear all,
To control the authorizations of users to display the document line items, I have created a Business Add-In Implementation "Z_FI_AUTHORITY_ITEM" with BADI FI_AUTHORITY_ITEM in SAP R/3 4.7.
The BADI worked correctly in SAP R/3 4.7.
Recently, we are upgrading my SAP from 4.7 to ECC 6.0. After upgraded, I found that the BADI doesn't called when displaying the documentline item. The status of the BADI is active. I have also tested in debug mode, it seems that it doesn't get into the BADI coding.
Can I ask how to solve this problem?
Thanks
Sunny

Hi Sunny,
I hope the following links should be able to answer your questions:
http://wiki.sdn.sap.com/wiki/display/Snippets/CreatealinkbetweenClassicBAdIandEnhancementspot
http://www.sapdev.co.uk/enhance/eframework/ef_implicit.htm
http://blog.csdn.net/conworld/archive/2009/04/01/4040658.aspx
Regards,
Warren.

Coding Practice(GV$SESSION)

Hi
Recently there was an issue of 1 procedure running in parallel through 2 different sessions and causing some irregular results.
So, I changed the code in such a way that when the procedure runs then it sets the module and action in the GV$SESSION view.
exec DBMS_APPLICATION_INFO.SET_MODULE ('MOD', 'ACT3000');
So whenever the procedure runs it first checks in GV$SESSION whether ACTION with the name ACT3000 is running or not, if not it runs,else it exits.
The question I have here is that is it a bad coding practice to select from the view GV$SESSION or any other system views in a procedure or an anonymous block?
Regards
Ankit

The question I have here is that is it a bad coding practice to select from the view GV$SESSION or any other system views in a procedure or an anonymous block?Probably there's no general answer to this. Sometimes it is just necessary to to query system views, sometimes you might think it over again - in particular for performace reasons.
In your case you also have the alternative of querying sys_context to get the information you wanted:
SQL> select sys_context('userenv','module') module, sys_context('userenv','action') action from dual;
MODULE ACTION
SQL*Plus
SQL>..whereby dual itself is a system view/table ;)

SRM - BADI debug

Hi gurus,
how can I debug a SRM BADI setting an external break-point? It seems impossible!
I'am not an expert ...
- I have set the parameter in SICF sap\bc\gui\sap\its ... ~GENERATEDYNPRO 1 ...
- I have set in utilities, settings, debugging, external debugging, in the field USER the name of the user I am using to approve the shopping cart
- I have set the break point in the BADI
But it does not stop!
Thanks a lot
Guido

Hi Guido,
sometimes its not clear, which user really calls the function.
Therefore it might be the problem, that SRM in your case uses the system user within this Badi (WF-Batch for example).
It might be helpful (as Atul mentioned before) to set a "hard" breakpoint within the BAdi coding.
Best possibility from my point of view:
Set an endless "loop" within your active implementation, for example:
DATA: debug type c.
While debug is initial.
endwhile.
Now start your transaction and check via SM50 if you can find the "endless" process.
Just mark it and debug it directly from SM50.
Best regards
Andreas

Error ERRµOR bugs crash latency and nothing ALL THIQ IQ CREATIVE BAD PRODUCT situation

I have the error :7
'' NT users should logon with administrators rights, if enable restart app. etc.. "
this when I load my X2 even if reinstall the eror still remai,ns and X2 crash at startup
+ having problems wiyh EMU SINCE Day one
Im pro audio video composer for a long time having serious deadlines vut EMU is forr the supêrmarkets not for seriopus musicians
but uts the price ... *
how can be a victim and a murder??
**bleep** my zeeoe coede is a big mistakes $*but its just one in a million emu s bad coding programmers

That error is due to a service called Cdilla (it must be running otherwise the software won't run).
Message Edited by steelboy1982 on 09-28-200703:05 PM

Encore2 Preview Bad Stutter - AVIs Play in PP2 & WMP

Ive encountered a problem in EncoreDVD 2 with Preview playback. Im getting a very heavy stutter in both Audio & Video. If this were a mechanical player, and not a software one, Id check that nothing was hanging up the CTI. The CTI seems to hang, lurch ahead, then come back a few frames, before repeating the process. Four frames forward, two steps back. (Note: numbers in the previous sentence are totally arbitrary and used as an example only.) All files play smoothly in PP2 and WMP.
Project: NTSC 720x480 PAR 0.9, 1 main Timeline - 15;03;02, 2 transition Timelines - 00;24;03 (identical, except for the elements that come into the frame, 1 test Timeline for calibrating the system, especially Audio volume - 00;45;15, 2 Menus - 1 with 2 Buttons: Test Timeline and 1 button to next Menu, which has sound source selection: Stereo, DD 5.1 Surround and DTS. This button goes to the main Timeline (15;03;02) w/ 3 Audio Tracks. Both Menus have Audio linked, but no Motion of any kind. All Buttons are just arrows with no thumbnails. Even the text on them is static and is not part of the Button. There are two transitions, one is Play First and leads to the Test/Sound Select Menu (basically graphics of the Buttons and the text glide into view), the other is linked to the Sound Select Button to play before the Sound Select Menu comes in. Both have Audio. Both are made from Photoshop PSDs of the respective Menus and the animation of the Buttons and text is done in PP2. Obviously, the buttons are not active, until these transitions play and the real Menu comes up.
All Video material is Exported from PP2 as DV-AVI to be transcoded in Encore2. Audio assets are mostly AC3s, Exported from PP2, and there is 1 PCMWAV (the Stereo Audio file), and one DTS, Exported from the SurCode DTS encoder. So all of these assets are elemental streams.
Everything looks good on the Timelines - Audio & Video are the same length when Zoomed in. Check Project shows no errors.
System: Intel Duo-Core 3.2GHz, 4 GB Corsair Pro RAM, 4x500GB SATAII HDDs, 1x750GB ATA-100 HDD, nVidia Quadro 4500-512MB VRAM, Realtec AC97chipSB Live! 24-bit w/ AISO4All, XP-Pro/SP-2, Adobe Production Studio CS2, dual Hitachi 21" monitors. All unnecessary processes are shut down with EndItAll2 prior to any editing and HDDs are defragged daily (as soon as this started, I did a fresh defrag, as that is what it looked like to me). Other than the Adobe products, only other SW involved has been SurCode 5.1 (PP2 plug-in) and SurCode DTS (stand-alone). This is the first DTS Project that I have done, but nearly every other one had 5.1 Surround Sound from the SurCode via AC3.
This is the first problem that I have had in Encore2. It has played nicely with every asset that I have handed it. Ive done over 100 Projects with only two tiny hiccups, and all of these Projects were much, much larger with dozens of Timelines and multiple menus, many with Motion Backgrounds and animated Buttons. Ive used transition Video assets to go to Menus that were a lot more complex than in this Project.
The stutter is with all assets. Preview for here shows this problem, regardless of where I am previewing from. Again, all Video assets are DV-AVI from PP2 and play smoothly in PP2 and WMP. All Audio assets are PCMWAV, AC3 or DTS. They play smoothly in PP2 and WMP too. It is like Encores Preview Player hangs, breaks away, then bounces back a bit, before it hangs and breaks away again.
Right now, I am burning a DVD+RW to test and will also start this Project from the ground up, to test as well. Luckily, its a simple Project.
Has anyone else had this sort of behavior? Does anybody see anything in the above specs. to indicate any sort of problem with Preview? Did I just miss something critical, because the Project seemed so simple and I could do it in my sleep? If the DVD+RW burns OK, and tests fine, and the final DVD-5 does too, then its almost moot, except that I would love to find ou

Joe,
I did try switching off Automatic, per manual and posts here, but it had no effect. There is/was obviously some small difference between the playback engines, but so long as it's working now... Earlier posts here indicated that the E2 and PP2 playback engines were the same, so that had me puzzled. One thing that I did check was ver. of DirectX (still 9c), because I had a program a couple of months back that wanted to install 8a. Bad coding in that installer, in my book.
Neil,
I used to upgrade and update religiously, but app. by app. I am turning more to your way of thinking. If it works, do not touch it. Main reason that I did not want to do anything with Production Studio. It was all (well, almost all) working perfectly, and even with major Registry cleaning, programs have a way of leaving little nuggets behind that foul one up later.
Normally, my video driver would have been first guess, except that every other application, even some video-intensive ones, ran perfectly. Took a while, but maybe it'll benefit someone else in the future.
And yes, I had to turn off Apple's Automatic Update feature twice already today, but it probably has already resset itself. I need a check list of things like that to look at every time I boot the machine up!
Neil,
In a few days I may have a couple more DTS/5.1 questions, that I'll post in the Audio Assets forum. Almost done, but not quite.
Thanks,
Hunt

Wht is ment by coding standards?

hi,
Can any one tell me wht is ment by coding standards. Wht r the tips to be followed when we r developing a application. so tht the application consists of good coding standards...
thanks
[email protected]

Wht r the tips to be followed when
we r developing a application. so tht the application
consists of good coding standards...There are many books out there and through the generations of code, they only change slightly. When you read the books on 'coding standards', keep in mind at some point you will probably want someone to pay you for coding--at that point you will have to adhear to their corporate coding standards, if they officially exist or are implied by the project lead.
I don't know of much else that will frost the attitude of a lead quicker t'ward a very compitent developer than one that insists the corporate standard is "not appropriate" or "bad coding practice". It may be, but until it is officially changed, or you are fired, they are paying you to make it their way.

90% cpu load on ubuntu 8.04

Hello all,
I made a visualization for sorting algorithms. (The code is to long to post it here)
I developed the app under this system:
Windows Vista Home x64
Dualcore ~2.6GHz
Java Version: 1.6.0 Update 7 32bit
and i have a cpu load of ~10% when i run the app.
I asked my friend to test the app under his OS:
Ubuntu 8.04
Dualcore ~2.2Ghz
Java Version: 1.6.0 Update 7 32bit
and he got a cpu load of over 90%!
We both had no running tasks in background. It was only the java app.
Are there any known issues about this problem or could could it be a coding problem?
Btw the programm uses round about 8 Threads.
TIA

mod235711 wrote:
I'm sry.
Ok i try to specify a little bit more.
e.g.: I have this code snippet to check whenever the algorithm has finished.
while (!algorithm.isIdle())
                              try
                                   sleep(1);
                              catch (InterruptedException e)
                                   clockRefresh.interrupt();
                                   setIdle();
                         }Without the sleep I have a cpu load of 50% (of course, because it is an endless loop until the algorithm has finished).
But with the sleep time it's just 1 or 2%.
I want to know if there is a known issue in the JVM that causes threads on some systems to use to much cpu load.
Or could it be a coding problem?
What do you think about the sleep time in this loop?
Or could the high cpu load be caused by bad coding?After reading this post I could not read further. There is the problem. You're doing a sleep(1) .....
Even in C that will most likely kill any cpu. Try to use joins: elegant and faster ;)

Mobile List Bind aggregation - repeated values?

Hi all, i'm new to SAPui5 so please forgive me if this is already discussed.
I'm calling a odata service (http://h03zdb.hcc.uni-magdeburg.de:8003/workshop/sessiona/12/Services/msgTab.xsodata/MSGTABLE?$filter=FROM%20eq%20%27STU…) and I get the values stored in a table in json. I want to show this in a list but there are repeated values created for the list. Is it because of bindAggregation?

Here is the whole code.
I used split app and added two models for the detail and master page.
I'm very new to this so sorry for bad coding
<html>
<head>
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>SRH Chat</title>
<script src="/sap/ui5/1/resources/sap-ui-core.js"
id="sap-ui-bootstrap"
data-sap-ui-libs="sap.m"
data-sap-ui-theme="sap_bluecrystal">
</script>

<script type="text/javascript">
var sessionKey = "STUDENT01";
// Login user to get session id
var oDetailPage2 = new sap.m.Page("detail2");
var url = "http://h03zdb.hcc.uni-magdeburg.de:8003/workshop/sessiona/12/Services/msgTab.xsodata/MSGTABLE?$filter=TO%20eq%20%27"+sessionKey+"%27%20&%20FROM%20eq%20%27"+sessionKey+"%27%20&$format=json";
$.get( url, function(data1) {
// create JSON model instance
var oModel = new sap.ui.model.json.JSONModel();
// set the data for the model
oModel.setData(data1);
// set the model to the core
oMasterPage1.setModel(oModel);
var contactList = new sap.m.List("newlist2",{
title : "{FROM}",
mode: sap.m.ListMode.SingleSelectMaster,
            select: function(oEv) {
var item = oEv.getParameter("listItem");
var desc = item.getTitle();
retrieveMsgs(desc);
function retrieveMsgs(desc)
var aurl = "http://h03zdb.hcc.uni-magdeburg.de:8003/workshop/sessiona/12/Services/msgTab.xsodata/MSGTABLE?$filter=FROM%20eq%20%27"+desc+"%27%20&$format=json";
$.get( aurl, function( data ) {
// // create JSON model instance
var oModel1 = new sap.ui.model.json.JSONModel();
// // set the data for the model
oModel1.setData(data);
// set the model to the core
oDetailPage2.setModel(oModel1);
var contactList1 = new sap.m.List("newlist");
var inputField = new sap.m.TextArea();
var but1 = new sap.m.Button({text: "Send", tap: function(){
// Send button press functionality
var msg = inputField.getValue();
var murl = "http://h03zdb.hcc.uni-magdeburg.de:8003/workshop/sessiona/12/WebContent/InsertMsg.xsjs?from="+desc+"&to="+sessionKey+"&msg="+msg;
$.ajax({
        url: murl,
        type: 'POST',
        async: false,
        timeout: 30000,
        success : function (data2){
        var empty = "";
        inputField.setValue(empty);    // clear text area
//Populate the List with Data from the Model (Set in the Controller of this View)
contactList1.bindAggregation("items", {
path : "/d/results", //Reference to the JSON structure
template: new sap.m.StandardListItem({
title: "{FROM}", //Refer the name field in the JSON data
description: "{MSG}", //Address Field in the data
type: sap.m.ListType.Navigation //Specify what to do while clicking/tapping an item in the list, in this example navigate to another view
oDetailPage2.addContent(contactList1);
oDetailPage2.addContent(inputField);
oDetailPage2.addContent(but1);
oSplitApp.to("detail2");
//Populate the List with Data from the Model (Set in the Controller of this View)
//oModel.createBindingContext("/d/results", null, {select: "FROM"},function(a){});
contactList.bindAggregation("items", {
path : "/d/results", //Reference to the JSON structure
template: new sap.m.StandardListItem({
title: "{FROM}", //Refer the name field in the JSON data
//description: "{FROM}", //Address Field in the data
//select: "FROM,TO",
type: sap.m.ListType.Navigation //Specify what to do while clicking/tapping an item in the list, in this example navigate to another view
var oMasterPage1 = new sap.m.Page("master1",{
    title : "Master"
// adding the list to master
oMasterPage1.addContent(contactList);
// //add the master pages to the splitapp control
oSplitApp.addMasterPage(oMasterPage1);
//   .addMasterPage(oMasterPage1);
//add the detail pages to the splitapp control
oSplitApp.addDetailPage(oDetailPage2);
//oSplitApp.setInitialDetail("detail");
//oSplitApp.setInitialMaster("master");
oSplitApp.placeAt("body");
</script>
</head>
<body class="body">
<div id="body">
</div>
</body>
</html>

Bad coding

Similar Messages

Maybe you are looking for