Beginner - trying to create a stored procedure.

Question

I want to create a stored procedure, where the person calling the procedure only has to up date the date_key :
The procedure is just creating a table and will be ran every couple days.
Create or replace procedure WklyHVCReport (date_transaction number)
Is
Begin
EXECUTE_IMMEDIATE
create table reporting_dept.HVC_Weekly
as
select a.msisdn, sum(d.amt_gross * -1.0) as Amt
from clarity_mis.dim_subscriber_vw a
join clarity_mis.dim_customer_account_vw b on a.customer_account_id = b.customer_account_id
join clarity_mis.fact_balance_transaction_vw c on a.subscriber_key = c.subscriber_key
join clarity_mis.dim_transaction_vw d on c.transaction_key = d.transaction_key
where a.flag_is_last_msisdn_owner = 'Y'
and a.sub_base_group = 'ACTIVE'
and (b.data_protection != 'No Contact Preferred' or b.data_protection is null)
and c.date_transaction_key >= || date_transaction ||
and d.transaction_sub_cat = 'Purchased Credit'
group by a.msisdn having sum(d.amt_gross * -1.0) >= 80
end;
I keep getting this error,
Error(6,1): PLS-00103: Encountered the symbol "?" when expecting one of the following: := . ( @ % ;
- can you point me in the right direction ?

Answer 1

Hello
Sorry to jump in but I think it would be worth you having a look at packages. Packages allow you to group together stored procedures and functions that have a common purpose - similar idea to libraries, DLL etc.
In your example, if you have several different reports for HVC (I'm making a big guess that HVC has some sort of relevance to the business or a peice of software), you could have a sinlge package that contains all of them. They are then logically grouped and you can potentially share logic between them.
A package is formed of a specification and a body. In the specification you are defining procedures that are "publicly" callable and in the body you are writing the implementation of those procedures.
You can also specify procedures that can only be called within the package body and are not visible outside. So for example if you wanted to log how often each report is run and by whom, you could have a procedure only declared in the body that will record those details in a separate table.
CREATE TABLE hvc_report_log
(   report_name     VARCHAR2(100) NOT NULL,
    username        VARCHAR2(30) NOT NULL,
    used_date       DATE NOT NULL
--This is the specification
CREATE OR REPLACE PACKAGE hvcreports
AS
    PROCEDURE p_Weekly (date_transaction number);
    PROCEDURE p_Monthly (date_transaction number);
END;
--This is the implementation in the body.
CREATE OR REPLACE PACKAGE BODY hvcreports
AS
    --This procedure can only be called from within the package body
    PROCEDURE p_LogUsage( p_report_name    hvc_report_log.report_name%TYPE)
    IS
    BEGIN
        INSERT
        INTO
            hvc_report_log
            (   report_name,
                username,
                used_date
        VALUES
            (   p_report_name,
                USER,       --Built in function that returns
                            --the currently logged in oracle user
                SYSDATE     --Returns the current date and time
    END;
    PROCEDURE p_Weekly (date_transaction number)
    IS
     begin
      p_LogUsage('hvc_weekly');
       insert into hvc_weekly (msisdn, amt)
         select   a.msisdn,
               sum (d.amt_gross * -1.0) as amt
         from    clarity_mis.dim_subscriber_vw a
              join clarity_mis.dim_customer_account_vw b
                on a.customer_account_id = b.customer_account_id
              join clarity_mis.fact_balance_transaction_vw c
                on a.subscriber_key = c.subscriber_key
              join clarity_mis.dim_transaction_vw d
                on c.transaction_key = d.transaction_key
         where        a.flag_is_last_msisdn_owner = 'Y'
               and a.sub_base_group = 'ACTIVE'
               and (b.data_protection != 'No Contact Preferred'
                 or b.data_protection is null)
               and c.date_transaction_key >= date_transaction
               and d.transaction_sub_cat = 'Purchased Credit'
         group by a.msisdn
         having   sum (d.amt_gross * -1.0) >= 80;
     end ;   
    PROCEDURE p_Monthly (date_transaction number)
    IS
    begin
      p_LogUsage('hvc_monthly');   
      insert into hvc_monthly (msisdn, amt)
        select   a.msisdn,
             sum (d.amt_gross * -1.0) as amt
        from    clarity_mis.dim_subscriber_vw a
            join clarity_mis.dim_customer_account_vw b
              on a.customer_account_id = b.customer_account_id
            join clarity_mis.fact_balance_transaction_vw c
              on a.subscriber_key = c.subscriber_key
            join clarity_mis.dim_transaction_vw d
              on c.transaction_key = d.transaction_key
        where        a.flag_is_last_msisdn_owner = 'Y'
             and a.sub_base_group = 'ACTIVE'
             and (b.data_protection != 'No Contact Preferred'
              or b.data_protection is null)
             and c.date_transaction_key >= date_transaction
             and d.transaction_sub_cat = 'Purchased Credit'
        group by a.msisdn
        having   sum (d.amt_gross * -1.0) >= 80;
    end ;     
END;
/You can then call them in pretty much the same way as with stand alone stored procedures
BEGIN
    hvcreports.p_Weekly(1);
    hvcreports.p_Monthly(1);
END;
EXEC hvcreports.p_Weekly(1);
EXEC hvcreports.p_Monthly(1);Hopefully I've not muddied the water too much. Here's some links to the documentation...
Documentation hope page for 11gR2
http://www.oracle.com/pls/db112/homepage
PL/SQL language reference
http://download.oracle.com/docs/cd/E11882_01/appdev.112/e25519/toc.htm
PL/SQL development guide
http://download.oracle.com/docs/cd/E11882_01/appdev.112/e10766/toc.htm
SQL Language reference
http://download.oracle.com/docs/cd/E11882_01/server.112/e26088/toc.htm
HTH
David