Best way to write Pl/Sql

Question

Dear all,
Can someone say the best way writing below stored proc:
procedure missing_authorized_services is
v_truncate_sql varchar2(200);
v_sql varchar2(2000);
BEGIN
v_truncate_sql := 'truncate table missing_authorized_services';
     execute immediate v_truncate_sql;
     commit;
v_sql := 'INSERT into missing_authorized_services select distinct trim(service_group_Cd) as service_group_Cd, trim(service_cd) as service_cd from stage_1_mg_service_request
where (service_group_cd, service_cd) not in (
                    select distinct service_group_cd, service_cd from stage_3_servcd_servgrp_dim)';
execute immediate v_sql;
     commit;
END missing_authorized_services;
/* I am doing select from table and then try to Insert into a different table the result set */
Please guide,
Thanks
J

Answer 1

Hi,
The best way to write PL/SQL (or any code) is in very small increments.
Start with a very simple procedure that does something (anything), just enough to test that it's working.
Add lots of ouput statments so you can see what the procedure is doing. Remember to remove them after testing is finished.
For example:
CREATE OR REPLACE procedure missing_authorized_services IS
        v_truncate_sql  VARCHAR2 (200);
BEGIN
     v_truncate_sql := 'truncate table missing_authorized_services';
     dbms_output.put_line (  v_truncate_sql
                    || ' = v_truncate_sql inside missing_authorized_services'
END      missing_authorized_services;If you get any errors (for example, ORA-00955, becuase you're trying to give the same name to a procedure that you're already using for a table), then fix the error and try again.
When it worls perfectly, then add another baby step. For example, you might add the one line
EXECUTE IMMEDIATE v_truncate_sql;and test again.
Don't use dynamic SQL (EXECUTE IMMEDIATE) unless you have to.
Is there any reason to use dynamic SQL for the INSERT?