Bulk collect with Nested loops

Question

Hi I've a requirement like this
I need to pull request nos from table a(Master table)
For every request no I need to pull request details from table b(Detail Table)
For every request no I need to pull contact details from table c
For every request no I need to pull customer data table d and I need to create a flat file with that data so I'm using utl_file in normal query criterion because of nested loops it's taking lot of time so I want to use bulk collect with dynamic query option:
Sample code
=======
create or replace procedure test(region varchar2) as
type tablea_request_typ is table of varchar2(10);
tablea_data tablea_request_typ;
type tableb_request_typ is table of varchar2(1000);
tableb_data tableb_request_typ;
type tablec_request_typ is table of varchar2(1000);
tablec_data tablec_request_typ;
type tabled_request_typ is table of varchar2(1000);
tabled_data tabled_request_typ;
stmta varchar2(32000);
stmtb varchar2(32000);
stmtc varchar2(32000);
stmtd varchar2(32000);
rcura SYS_REFCURSOR;
rcurb SYS_REFCURSOR;
rcurc SYS_REFCURSOR;
rcurd SYS_REFCURSOR;
begin
stmta:='select  request_no from tablea where :region'||'='NE';
stmtb:='select  request_no||request_detail1||request_detail2 stringb  from table b where :region'||'='NE';
stmtc:='select contact1||contact2||contact3||contact4  stringc from table c where :region'||'='NE';
stmtd:='select customer1||customer2||customer3||customer4  stringd  from table c where :region'||'='NE';
OPEN rcura for stmta;
  LOOP
  FETCH rcura BULK COLLECT INTO request_no
  LIMIT 1000;
  FOR  f in 1..request_no.count
LOOP
--Tableb
    OPEN rcurb for stmtb USING substr(request_no(f),1,14);
  LOOP
  FETCH rcurb BULK COLLECT INTO tableb_data
for i in 1..tableb_data.count
LOOP
utl_file(...,tableb_data(i));
END LOOP;
    EXIT WHEN rcurb%NOTFOUND;
  END LOOP;
-- Tablec
OPEN rcurc for stmtc USING substr(request_no(f),1,14);
  LOOP
  FETCH rcurb BULK COLLECT INTO tablec_data
for i in 1..tablec_data.count
LOOP
utl_file(...,tablec_data(i));
END LOOP;
    EXIT WHEN rcurc%NOTFOUND;
  END LOOP;
-- Tabled
OPEN rcurd for stmtd USING substr(request_no(f),1,14);
  LOOP
  FETCH rcurd BULK COLLECT INTO tabled_data
for i in 1..tabled_data.count
LOOP
utl_file(...,tabled_data(i));
END LOOP;
    EXIT WHEN rcurd%NOTFOUND;
  END LOOP;
  END LOOP;
    EXIT WHEN rcura%NOTFOUND;
  END LOOP;
exception
when other then
dbms_output.put_line(sqlerrm);
end;I 'm using code mentioned above but request nos are repeating as if it's an infinete loop ?for ex if request no is 222 It should run once but here it's running more than once?
How to pass bind parameters say in my case region?
Are there any alternate solutions to run it faster apart from using bulk collect?
Right now I'm using explicit cursor with for loop which is taking lot of time ?so is this better sol?
Thanks,
Mahender
Edited by: BluShadow on 24-Aug-2011 08:52
added {noformat}{noformat} tags. Please read {message:id=9360002} to learn to format your code/data yourself.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   

Answer 1

    Use Parameterized cursor :
CREATE OR REPLACE PROCEDURE test(region varchar2)
AS
  type tablea_request_typ is table of varchar2(10);
  type tableb_request_typ is table of varchar2(1000); 
  type tablec_request_typ is table of varchar2(1000);
  type tabled_request_typ is table of varchar2(1000);
  tablea_data tablea_request_typ;
  tableb_data tableb_request_typ;
  tablec_data tablec_request_typ;
  tabled_data tabled_request_typ;
   CURSOR rcura(v_region  VARCHAR2(100))
   IS
   select  request_no from tablea where region = v_region;
   CURSOR rcurb(v_input  VARCHAR2(100))
   IS
   select  request_no||request_detail1||request_detail2 stringb  from table b where request_num = v_input;
   CURSOR rcurc(v_input  VARCHAR2(100))
   IS
   select  select contact1||contact2||contact3||contact4  stringc from table c where request_num = v_input;
   CURSOR rcurd(v_input  VARCHAR2(100))
   IS
   select  select customer1||customer2||customer3||customer4  stringd  from table c where request_num = v_input;
BEGIN
OPEN rcura('NE');
LOOP
    FETCH rcura BULK COLLECT INTO request_no  LIMIT 1000;
    FOR  f in 1..request_no.count
    LOOP
       --Tableb
       OPEN rcurb(substr(request_no(f),1,14));
       LOOP
          FETCH rcurb BULK COLLECT INTO tableb_data
          for i in 1..tableb_data.count
          LOOP
              utl_file(...,tableb_data(i));
          END LOOP;
          EXIT WHEN rcurb%NOTFOUND;
       END LOOP;
       -- Tablec
       OPEN rcurc (substr(request_no(f),1,14));
       LOOP
          FETCH rcurb BULK COLLECT INTO tablec_data
          for i in 1..tablec_data.count
          LOOP
             utl_file(...,tablec_data(i));
          END LOOP;
          EXIT WHEN rcurc%NOTFOUND;
       END LOOP;
       -- Tabled
       OPEN rcurd ( substr(request_no(f),1,14) );
       LOOP
          FETCH rcurd BULK COLLECT INTO tabled_data
          for i in 1..tabled_data.count
          LOOP
           utl_file(...,tabled_data(i));
          END LOOP;
          EXIT WHEN rcurd%NOTFOUND;
       END LOOP;
  END LOOP;
EXIT WHEN rcura%NOTFOUND;
END LOOP;
EXCEPTION
WHEN OTHERS THEN
   dbms_output.put_line(dbms_utility.format_error_backtrace);
END;
/Hope this helps. If not, post your table structures...