Calling a function from procedure

Question

Please someone let me know if I'm going in the right direction or am I making it too difficult for myself. I'm only using the exam guide on programming units which assumes the reader already has a firm grasp on the material. I am entry level and need guidance.
The problem:
write a calling procedure and a function that will accomplish the following: The calling procedure will find all employees on the EMP table who's hire date is between Jan 01 and Apr 30, 1981. The function will then a 5% pay raise for each of the selected employees. The calling procedure will then display the employee number, employee name, and the new salary for each of the selected employees. Logically, then, the calling procedure will find the first employee within the date range, pass the employee current salary to the function, the function will compute the 5% pay raise and return the new salary to the calling procedure. The calling procedure will then display the required results..
//Function
create or replace function func_calc_emp_raise
(p_sal IN OUT NUMBER)
RETURN NUMBER
IS
BEGIN
p_sal := p_sal * 1.05;
RETURN p_sal;
END;
//procedure
CREATE OR REPLACE PROCEDURE PROC_EMP_RAISES
(p_empno VARCHAR2,
p_ename VARCHAR2,
p_sal NUMBER)
IS
v_empno emp.empno%type;
v_ename emp.ename%type;
v_sal emp.sal%type;
CURSOR cur_raise
IS
SELECT empno, ename, sal
FROM emp
where hiredate between
TO_DATE('JAN-01-1981','MON-DD-YYYY') and
TO_DATE('APR-30-1981','MON-DD-YYYY');
BEGIN
open cur_raise;
LOOP
FETCH cur_raise INTO v_empno, v_ename, v_sal;
EXIT WHEN (cur_raise%NOTFOUND);
v_sal:= func_calc_emp_raise(v_sal);
END LOOP;
close cur_raise;
end proc_emp_raises;
Both compile correctly but how do I get output?
Dee

Answer 1

I am not getting the error that you are. Did you create the function as originally posted? What version of Oracle are you using? I am using Oracle 8.1.7. Although it seems to tolerate the parameter passed to the function as IN OUT and allows modifictaion of the p_sal parameter, earlier versions of Oracle may require that it only be IN and that you not modify the input parameter. I have listed an alternate function below:
SQL> CREATE OR REPLACE FUNCTION func_calc_emp_raise
  2    (p_sal IN NUMBER)
  3    RETURN      NUMBER
  4  IS
  5  BEGIN
  6    RETURN p_sal * 1.05;
  7  END func_calc_emp_raise;
  8  /
Function created.
SQL> SHOW ERRORS
No errors.
SQL> -- Procedure:
SQL> CREATE OR REPLACE PROCEDURE proc_emp_raises
  2  AS
  3  BEGIN
  4    FOR rec IN
  5        (SELECT empno, ename, sal
  6         FROM      emp
  7         WHERE  hiredate BETWEEN TO_DATE ('JAN-01-1981','MON-DD-YYYY')
  8                   AND       TO_DATE('APR-30-1981','MON-DD-YYYY'))
  9    LOOP
10        DBMS_OUTPUT.PUT_LINE
11          (rec.empno              || ' '
12           || RPAD (rec.ename, 20)
13           || ' '
14           || TO_CHAR (func_calc_emp_raise (rec.sal)));
15    END LOOP;
16  END proc_emp_raises;
17  /
Procedure created.
SQL> SHOW ERRORS
No errors.
SQL> -- Execution:
SQL> SET SERVEROUTPUT ON SIZE 500000
SQL> EXECUTE proc_emp_raises
7499 ALLEN                1680                                                 
7521 WARD                 1312.5                                               
7566 JONES                3123.75                                              
PL/SQL procedure successfully completed.