Calling function in before insert trigger

Question

HELLO,
**TRIGGER IS NOT DISPLAYING THE DATA ACCURATELY**
**PLZ HELP ITS URGENT...**
THE CODE IS BELOW.....
create or replace TRIGGER GENSTUDYID
BEFORE INSERT
ON ER_PATPROT
REFERENCING NEW AS NEW OLD AS OLD
FOR EACH ROW
DECLARE
     lPatStudyID varchar2(30);
     lSiteCode number(10);
     lStudyCode number(10);
     lpk_patprot     Number(10);     
     lpatprot_enroldt date;
     lFK_PER number(20);
     lIPADD varchar2(15);
     lfk_protocol number(20);
     llast_modified_by number;
     lgencal_status number;
BEGIN
     lSiteCode := :New.fk_site_enrolling;
     lStudyCode := :new.fk_study;
     lpk_patprot := :new.pk_patprot;
     lpatprot_enroldt := :new.patprot_enroldt;
     lFK_PER := :new.fk_per;      
     lIPADD :=NULL;                
     lPatStudyID:=GenerateStudyID(lSiteCode,lStudyCode,lFK_PER);
     IF lPatStudyID IS NOT NULL then
          :NEW.patprot_patstdid := lpatstudyid;
     END IF;
END;
-----------FUNCTION CODE STARTS
create or replace
function GenerateStudyID (sitecode number,studycode number,pid number) RETURN VARCHAR IS
     lfield_name varchar2(10);
     lfield_format varchar2(10);
     lfield_length number(2);
     lfield_deftext varchar2(500);
     lparam1 varchar2(30):=sitecode;
     lparam2 varchar2(30):=studycode;
     lresult varchar2(30);
     lstudyid varchar2(30);
     lPATPROT_PATSTDID     varchar2(20);
CURSOR studyid_def_cur is select field_name, field_format, field_length, field_deftext from bayatree.studyid_definition
where study_code = studycode and site_code=sitecode order by field_seqno;
     CURSOR patprot_patstdid_cur is select PATPROT_PATSTDID from eres.er_patprot where fk_study=studycode and fk_per=pid;
BEGIN
     lstudyid := NULL;
dbms_output.put_line('studycode: '||studycode);
     dbms_output.put_line('pid; '||pid);
     FOR disp_studyid in patprot_patstdid_cur
     LOOP
          lPATPROT_PATSTDID:=disp_studyid.PATPROT_PATSTDID;
          dbms_output.put_line('lPATPROT_PATSTDID: '||lPATPROT_PATSTDID);
     END LOOP;
          IF lPATPROT_PATSTDID IS NULL THEN
          OPEN studyid_def_cur;
          LOOP
          FETCH studyid_def_cur INTO lfield_name, lfield_format, lfield_length, lfield_deftext;
          EXIT WHEN studyid_def_cur%NOTFOUND;
lfield_deftext:= replace(lfield_deftext,'param1',lparam1);
          lfield_deftext:= replace(lfield_deftext,'param2',lparam2);
     if (instr (lfield_deftext, 'select',1) > 0) then
               execute immediate lfield_deftext into lresult;
          else
               execute immediate lfield_deftext;
               lresult := null;
          end if;
          if lfield_format is not null and lresult is not null and lfield_length is not null then
               lresult := lpad(lresult, lfield_length, 0);
          end if;
          if lfield_name is not null and lresult is not null then
               lstudyid := lstudyid || lresult;
          end if;
     END LOOP;
     return (lstudyid);
     ELSE
          lstudyid:=lPATPROT_PATSTDID;
          Dbms_output.put_line('Study Id: '||lstudyid);
          return (lstudyid);
     END IF;
END;

Answer 1

Your post is not quiet readable, please include your program in tags, Include sample data and sample output, table and other objects creation and insert scripts.
What error are you getting anyway post the Oracle error code
SS