Connection Pooling in JDBC

Question

I have written a jdbc connectivity calss called SQL.java. Here its using normal JDBC connectivity mode
public Connection getConnection() throws SQLException { try { Class.forName(bundle.getString("driver")); } catch (ClassNotFoundException e) { e.printStackTrace(); } try { con = DriverManager.getConnection(new StringBuilder(bundle.getString("url").trim()).append( bundle.getString("ip").trim()).append(bundle.getString("database")).toString().trim(), bundle.getString( "userName").trim(), bundle.getString("password")); con.setAutoCommit(false); } catch (SQLException e) { throw e; } return con; }
We have a web application using this sql api. What is happening is for one login it will create one connection. That way we have wired. When logging out this connection is closed. So if 100 useres are loggin in 100 Connection will be created. Is that a good practice ...or i need to use connection pooling for that.

Answer 1

public class ConnectionSQL implements Serializable {
     private static final long serialVersionUID = -732705131170728886L;
     private static Connection con;
     private String databaseName = "";
     private DataSource dataSource;
     private static ConnectionSQL connectionSQL;
     private ConnectionSQL(String databaseName, ResourceBundle bundle) {
          this.databaseName = databaseName;
          String driver = bundle.getString("driver");
          String connectURI = new StringBuilder(bundle.getString("url").trim()).append(bundle.getString("ip").trim()).append(
                    bundle.getString("database")).toString().trim();
          String userName = bundle.getString("userName").trim();
          String password = bundle.getString("password").trim();
          dataSource = getDataSource(driver, connectURI, userName, password);
     public static ConnectionSQL getConnectionSQL(String databaseName, ResourceBundle bundle) {
          if (connectionSQL == null) {
               connectionSQL = new ConnectionSQL(databaseName, bundle);
          return connectionSQL;
     public synchronized Connection getConnection() throws SQLException {
          try {
               printDataSourceStats(dataSource);
               if(con != null && !con.isClosed()) {
                    return con;
               con = dataSource.getConnection();               
               con.setAutoCommit(false);
          catch (SQLException e) {
               throw e;
          return con;
     public static DataSource getDataSource(String driver, String connectURI, String userName, String password) {
          BasicDataSource ds = new BasicDataSource();
          ds.setInitialSize(5);
          ds.setDriverClassName(driver);
          ds.setUsername(userName);
          ds.setPassword(password);
          ds.setUrl(connectURI);
          ds.setMaxOpenPreparedStatements(-1);
          ds.setMaxActive(10);
          ds.setMaxIdle(5);
          ds.setMaxWait(10000);
          ds.setMinEvictableIdleTimeMillis(1000 * 60 * 30);
          return ds;
}What im currently using is like this ... i know its bad .. im not using the advantage of the connection pooling of dbcp .. Its in the developing stage