Criticisms? First package for r5u870-svn

Question

NOTE: see below for finished product
So I'm building a Pkgbuild for the fun of learning how to do so.
In particular this one is for the r5u870 webcam driver which downloads from the svn and not a static source.
Thus far I have this:
# contributor: orionfyre <OrionFyre on ARCH Forums>
pkgname=r5u870-svn
pkgver=88
pkgrel=1
pkgdesc="r5u870 webcam driver"
arch=('i686' 'x86_64')
url="http://wiki.mediati.org/R5u870"
license=('unknown')
depends=()
makedepends=()
provides=(r5u870)
conflicts=()
source=()
md5sums=()
_svntrunk="http://svn.mediati.org/svn/r5u870/trunk"
_svnmod=r5u870
build() {
cd $startdir/src
msg "Connecting to SVN server...."
if [ -d $_svnmod/.svn ]; then
(cd $_svnmod && svn up -r $pkgver)
else
svn co $_svntrunk --config-dir ./ -r $pkgver $_svnmod
fi
msg "SVN checkout done or server timeout"
msg "Starting make..."
svn export $_svnmod $_svnmod-build
cd $_svnmod-build
# BUILD
sed -i 's/\/lib\/firmware/$pkgdir\/lib\/firmware/g' $startdir/src/r5u870/Makefile
# NOTE: need to send "$pkgdir/lib/firmare" without messing up the
# regex line with a bunch of extra '/' reserved characters.
make || return 1
make DESTDIR=$pkgdir install || return 1
The Makefile has a section like this:
install::
install -m 0644 -o root -g root $(FWFILES) $(FWDIR)
/sbin/depmod -a
which installs all the firmware.
FWFILES= a list of the files
FWDIR = /lib/firmware
I of course want to change the variable from '/lib/firmware' to '$pkgdir/lib/firmware'
The first method that came to mind was to use sed to edit the text contained within the Makefile
the only problem is the regex:
sed -i 's/\/lib\/firmware/$pkgdir\/lib\/firmware/g' $startdir/src/r5u870/Makefile
however $pkgdir will contain the reserved / with no character escapes '\' before it.
I'm stumped and tired. here's the relevant parts from the Makefile:
V ?= 0
MDIR := extra
KVER ?= $(shell uname -r)
KDIR ?= /lib/modules/$(KVER)/build
DESTDIR ?= /lib/firmware ## Firmware location
FWFILES = r5u870_1830.fw r5u870_1832.fw r5u870_1833.fw r5u870_1834.fw r5u870_1835.fw r5u870_1836.fw r5u870_1870_1.fw r5u870_1870.fw r5u870_1810.fw r5u870_183a.fw r5u870_183b.fw r5u870_1839.fw r5u870_1841.fw
<BIG SNIP...>
install::
install -m 0644 -o root -g root $(FWFILES) $(FWDIR)
/sbin/depmod -a
<SNIPS...>
So if you could school me on some sed regex or point me in the direction of another way of achieving the same I would be grateful.
Last edited by OrionFyre (2008-06-16 15:19:23)

Answer 1

OK. here goes.
pkgbuild:
# contributor: orionfyre <OrionFyre on ARCH Forums>
pkgname=r5u870-svn
pkgver=88
pkgrel=1
pkgdesc="r5u870 webcam driver"
arch=('i686' 'x86_64')
url="http://wiki.mediati.org/R5u870"
license=('unknown')
depends=()
makedepends=()
provides=(r5u870)
conflicts=()
source=()
md5sums=()
install=$pkgname.install
_svntrunk="http://svn.mediati.org/svn/r5u870/trunk"
_svnmod=r5u870
build() {
cd $startdir/pkg
mkdir lib
cd lib
mkdir firmware
cd $startdir/src
msg "Connecting to SVN server...."
if [ -d $_svnmod/.svn ]; then
(cd $_svnmod && svn up -r $pkgver)
else
svn co $_svntrunk --config-dir ./ -r $pkgver $_svnmod
fi
msg "SVN checkout done or server timeout"
msg "Starting make..."
svn export $_svnmod $_svnmod-build
cd $startdir/src/r5u870
sed -i 's/\/sbin\/depmod\ \-a/ /g' Makefile
cd $_svnmod-build
# BUILD
make || return 1
make DESTDIR=$pkgdir FWDIR=$pkgdir/lib/firmware install || return 1
and the install:
# arg 1: the new package version
post_install() {
# updating module dependencies
echo ">>> Updating module dependencies. Please wait ..."
depmod -a > /dev/null 2>&1
modprobe r5u870
/bin/true
# arg 1: the new package version
# arg 2: the old package version
post_upgrade() {
# updating module dependencies
echo ">>> Updating module dependencies. Please wait ..."
depmod -a > /dev/null 2>&1
modprobe r5u870
/bin/true
# arg 1: the old package version
post_remove() {
# updating module dependencies
echo ">>> Updating module dependencies. Please wait ..."
KERNEL_VERSION=2.6.25-ARCH
depmod -a > /dev/null 2>&1
/bin/true
op=$1
shift
$op $*
I know it's messy. my first real attempt. any help at cleaning up that mkdir at the top of build{ couldn't seem to get to work any other way, would be appreciated.
Kudos? praise? criticisms? lambastes?