Cursor based on variable?

Question

I posted this issue in the APEX forum since I call my procedure through APEX, but I'm including it in here as well since the issue is with my cursor/loop:
In APEX, I have a process that calls apex_mail. I have a cursor/loop that pulls records meeting my criteria and lists them in the body of the mail. This all works. However, I added another field (field b) which in the app is dependent on field a. Rather than having 11 cursors defined that run according to my 'if' statements, I would like one cursor that is equal to the end result of my variable (v_sql). When I run the code below, I receive the following error: ORA-06550: line 11, column 22: PLS-00382: expression is of wrong type ORA-06550: line 11, column 3: PL/SQL: Statement ignored ORA-06550: line 68, column 18: PLS-00221: 'GATHER_USRS_CUR' is not a procedure or is undefined ORA-06550: line 68, column 3: PL/SQL: Statement ignored.
Code:
declare
e_body_1 CLOB;
e_body_2 CLOB;
j_sql CLOB :=null;
v_sql varchar2(2000);
-- Define cursor as SYS_REFCURSOR?
gather_usrs_cur SYS_REFCURSOR;
BEGIN
-- make cursor equal to variable of v_sql
gather_usrs_cur := v_sql;
-- Generate body of e-mail
e_body_1 := 'This e-mail is being generated to inform you that ... Those users are: '||utl_tcp.crlf||utl_tcp.crlf;
e_body_1 := e_body_1||'USER ID, FIRST, LAST, PHONE, E-MAIL'||utl_tcp.crlf;
e_body_1 := e_body_1||'==================================='||utl_tcp.crlf;
e_body_2 := utl_tcp.crlf||'Please review the accounts identified above and inform us .... We appreciate your follow-up regarding the account activity in your State.'||utl_tcp.crlf||utl_tcp.crlf;
e_body_2 := e_body_2||'Should you have any concerns/questions, please respond to the e-mail members on this e-mail.'||utl_tcp.crlf||utl_tcp.crlf;
e_body_2 := e_body_2||' Sincerely,'||utl_tcp.crlf||utl_tcp.crlf;
e_body_2 := e_body_2||' Team'||utl_tcp.crlf;
-- Conditions for determing value of v_sql which would ultimately be reflected in cursor, gather_usrs_cur
v_sql := 'select Q_APEX_ID,
USER_ID,
Q_USER_TYPE,
Q_FIRST,
Q_LAST,
C_PHONE,
C_EMAIL,
C_STATE
from Q_AUDIT
where MATCH = ''Y'' and
UPDT_ID is null and
UPDT_TS is null and
COMMENTS is null and
Q_USER_TYPE = :P32_USER_TYPE ';
if :P32_RO_USER_TYPE <> 'ALL' then
if :P32_RO_USER_TYPE = 1 then
v_sql := v_sql ||' and C_STATE in (''CT'',''MA'',''ME'',''NH'',''RI'',''VT'') ';
end if;
if :P32_RO_USER_TYPE = 2 then
v_sql := v_sql ||' and C_STATE in (''NJ'',''NY'',''PR'',''VI'') ';
end if;
if :P32_RO_USER_TYPE = 3 then
v_sql := v_sql ||' and C_STATE in (''DE'',''DC'',''MD'',''PA'',''VA'',''WV'') ';
end if;
if :P32_RO_USER_TYPE = 4 then
v_sql := v_sql ||' and C_STATE in (''AL'',''FL'',''GA'',''KY'',''MS'',''NC'',''SC'',''TN'') ';
end if;
if :P32_RO_USER_TYPE = 5 then
v_sql := v_sql ||' and C_STATE in (''IL'',''IN'',''MI'',''MN'',''OH'',''WI'') ';
end if;
if :P32_RO_USER_TYPE = 6 then
v_sql := v_sql ||' and C_STATE in (''AR'',''LA'',''NM'',''OK'',''TX'') ';
end if;
if :P32_RO_USER_TYPE = 7 then
v_sql := v_sql ||' and C_STATE in (''IA'',''KS'',''MO'',''NE'') ';
end if;
if :P32_RO_USER_TYPE = 8 then
v_sql := v_sql ||' and C_STATE in (''CO'',''MT'',''ND'',''SD'',''UT'',''WY'') ';
end if;
if :P32_RO_USER_TYPE = 9 then
v_sql := v_sql ||' and C_STATE in (''AZ'',''CA'',''HI'',''NV'') ';
end if;
if :P32_RO_USER_TYPE = 10 then
v_sql := v_sql ||' and C_STATE in (''AK'',''ID'',''OR'',''WA'') ';
end if;
end if;
-- call and loop through cursor for body of e-mail
for usr_rec in gather_usrs_cur
loop
begin
j_sql := j_sql ||usr_rec.user_id||', '||usr_rec.Q_first||', '||usr_rec.Q_last||', '||usr_rec.C_phone||', '||usr_rec.C_email||utl_tcp.crlf;
end;
end loop;
commit;
-- Call mail procedure
apex_mail.send(
P_TO => :P32_E_RECIPIENT,
P_CC => '[email protected], [email protected]',
P_FROM => '[email protected]',
P_BODY => e_body_1||j_sql||e_body_2,
P_SUBJ => 'Q Accounts Requiring Review');
end;
Is it possible to create one cursor that is equal to the 11 possible combinations, based on v_sql? Note that the :P32_X variables are set via buttons/fields in my APEX application. Thanks in advance for your help.

Answer 1

I went ahead and rewrote this for you. Obviously I can't test it so no guarantees....
Are you putting this code directly in APEX? If so, notice how I took ":P32_USER_TYPE" out from being a literal in your string and put in a bind variable.
DECLARE
e_body_1 CLOB;
e_body_2 CLOB;
j_sql CLOB := NULL;
v_sql VARCHAR2 (2000);
usr_rec q_audit%ROWTYPE;
TYPE auditcurtype IS REF CURSOR;
v_audit_cur auditcurtype;
BEGIN
-- Generate body of e-mail
e_body_1 :=
'This e-mail is being generated to inform you that ... Those users are: '
|| UTL_TCP.crlf
|| UTL_TCP.crlf;
e_body_1 :=
e_body_1 || 'USER ID, FIRST, LAST, PHONE, E-MAIL' || UTL_TCP.crlf;
e_body_1 :=
e_body_1 || '===================================' || UTL_TCP.crlf;
e_body_2 :=
UTL_TCP.crlf
|| 'Please review the accounts identified above and inform us .... We appreciate your follow-up regarding the account activity in your State.'
|| UTL_TCP.crlf
|| UTL_TCP.crlf;
e_body_2 :=
e_body_2
|| 'Should you have any concerns/questions, please respond to the e-mail members on this e-mail.'
|| UTL_TCP.crlf
|| UTL_TCP.crlf;
e_body_2 := e_body_2 || ' Sincerely,' || UTL_TCP.crlf || UTL_TCP.crlf;
e_body_2 := e_body_2 || ' Team' || UTL_TCP.crlf;
-- Conditions for determing value of v_sql which would ultimately be reflected in cursor, gather_usrs_cur
v_sql :=
'select *
from Q_AUDIT
where MATCH = ''Y'' and
UPDT_ID is null and
UPDT_TS is null and
COMMENTS is null and
Q_USER_TYPE = :1';
IF :p32_ro_user_type <> 'ALL'
THEN
IF :p32_ro_user_type = 1
THEN
v_sql :=
v_sql
|| ' and C_STATE in (''CT'',''MA'',''ME'',''NH'',''RI'',''VT'') ';
END IF;
IF :p32_ro_user_type = 2
THEN
v_sql := v_sql || ' and C_STATE in (''NJ'',''NY'',''PR'',''VI'') ';
END IF;
IF :p32_ro_user_type = 3
THEN
v_sql :=
v_sql
|| ' and C_STATE in (''DE'',''DC'',''MD'',''PA'',''VA'',''WV'') ';
END IF;
IF :p32_ro_user_type = 4
THEN
v_sql :=
v_sql
|| ' and C_STATE in (''AL'',''FL'',''GA'',''KY'',''MS'',''NC'',''SC'',''TN'') ';
END IF;
IF :p32_ro_user_type = 5
THEN
v_sql :=
v_sql
|| ' and C_STATE in (''IL'',''IN'',''MI'',''MN'',''OH'',''WI'') ';
END IF;
IF :p32_ro_user_type = 6
THEN
v_sql :=
v_sql || ' and C_STATE in (''AR'',''LA'',''NM'',''OK'',''TX'') ';
END IF;
IF :p32_ro_user_type = 7
THEN
v_sql := v_sql || ' and C_STATE in (''IA'',''KS'',''MO'',''NE'') ';
END IF;
IF :p32_ro_user_type = 8
THEN
v_sql :=
v_sql
|| ' and C_STATE in (''CO'',''MT'',''ND'',''SD'',''UT'',''WY'') ';
END IF;
IF :p32_ro_user_type = 9
THEN
v_sql := v_sql || ' and C_STATE in (''AZ'',''CA'',''HI'',''NV'') ';
END IF;
IF :p32_ro_user_type = 10
THEN
v_sql := v_sql || ' and C_STATE in (''AK'',''ID'',''OR'',''WA'') ';
END IF;
END IF;
OPEN v_audit_cur FOR v_sql using :P32_USER_TYPE;
LOOP
FETCH v_audit_cur
INTO usr_rec;
EXIT WHEN v_audit_cur%NOTFOUND;
j_sql :=
j_sql
|| usr_rec.user_id
|| ', '
|| usr_rec.q_first
|| ', '
|| usr_rec.q_last
|| ', '
|| usr_rec.c_phone
|| ', '
|| usr_rec.c_email
|| UTL_TCP.crlf;
END LOOP;
CLOSE v_audit_cur;
-- No need for this, you aren't changing anything
-- COMMIT;
-- Call mail procedure
apex_mail.send (p_to => :p32_e_recipient,
p_cc => '[email protected], [email protected]',
p_from => '[email protected]',
p_body => e_body_1 || j_sql || e_body_2,
p_subj => 'Q Accounts Requiring Review'
END;
Hope this helps,
Steve
Alliance Technologies