DataTable in dataTable fix details (JSF 1.1)

Question

I posted a message yesterday indicating that some of the problems with nested dataTables had not been fixed in the JSF 1.1 release. Since that posting, I have done some more research, and have more specific information regarding the remaining problems and a way to fix them. The remaining problems are:
1) Values from inputText fields in the inner dataTable are ignored on submit (except for the last row of the table). The problem is that processDecodes is called on the inner table component multiple times (once per row of the outer table), and the "saved = new HashMap();" statement effectively wipes out any values that were decoded from the previous row, so that at the end of the process, the only decoded values that remain are those from the last row. My suggested fix for that problem is:
a) to create a "boolean isOuterTable()" method on UIData that determines whether or not this table is the outermost table (i.e. go up through the parent chain and see if there are any UIData ancestors).
b) create a "clearSaved" method on UIData as follows:
protected void clearSaved() {
    saved = new HashMap();
}c) create a "clearDescendants" method on UIData that goes visits all of the UIData's descendants (i.e. facets and children, and their facets and children, recursively), and calls clearSaved on any UIData components that are found
d) in the processDecodes method for UIData, replace:
saved = new HashMap();with
if (isOuterTable()) {
    clearSaved();
    clearDescendants();
}2) When a commandButton in the inner dataTable is clicked, actions are fired for all rows of the outer dataTable. This is one case of a larger problem. The implementation of getClientId in UIComponentBase uses a cached value, if the ID has been computed previously. For components within dataTables, this is a problem because these components are referenced multiple times for different rows of the outer table, and the row number of the outer table is part of the client ID. To fix this, I suggest the following (maybe overkill, but it works):
a) Create a "clearCachedValues" method on UIData, which visits all of the UIData's descendants, and sets their clientId to null. A hack to do this is:
descendant.setId(descendant.getId())It would be better to have a method on UIComponent for this. NOTE: I have also found that if I come across a descendant that is a UIData, I also need to set that component's "model" attribute to null, because the calculation of this model refers to that dataTable's value valueBinding, which may be defined in terms of the current row of the outer table.
b) Add a call to clearCachedValues to the end of the setRowIndex method on UIData.
There may be other, better ways to fix these problems, but I thought it might be helpful to describe my fixes in detail, so that whoever is responsible for fixing the reference implementation can at least have the benefit of my research.
I would like to see a bug opened for these problems, and I would like to be able to see the descriptions of known JSF bugs. Before JSF 1.1 came out I was worried that the nested dataTables bug (C026) description (which I was unable to find) might not be complete, and that as a result, the problems with nested dataTables would not be completely fixed in JSF 1.1. As it turned out my worries were not unfounded.

Answer 1

JD> 2) When a commandButton in the inner dataTable is clicked, actions
JD> are fired for all rows of the outer dataTable. This is one case of a
JD> larger problem. The implementation of getClientId in UIComponentBase
JD> uses a cached value, if the ID has been computed previously. For
JD> components within dataTables, this is a problem because these
JD> components are referenced multiple times for different rows of the
JD> outer table, and the row number of the outer table is part of the
JD> client ID. To fix this, I suggest the following (maybe overkill, but
JD> it works):
I've fixed part 1). I've essentially done as you suggested.
I can't reproduce part 2). I've posted the webapp where I try to do
this at
http://blogs.sun.com/roller/resources/edburns/jsf-nested-datatables.war
Please put the JSF 1.1 jars in common lib, or WEB-INF/lib in this war
and then visit
http://host:port/jsf-nested-datatables/faces/test2.jsp
Click on the outer buttons, you'll see that the outer listener fires
once.
Click on the inner buttons, you'll see that the inner listener once.
Can you please help me reproduce this?
Ed