Date & hour in stored procedure

Question

create or replace PROCEDURE library_portal_home(ldt portal_home_non_login_log.logdatetime%TYPE,   COT portal_home_non_login_log.counter%TYPE) IS
lv_count NUMBER;
BEGIN
  SELECT COUNT(1)
  INTO lv_count
  FROM portal_home_non_login_log
  WHERE to_date(logdatetime,   'dd-mon-yyyy hh24') = to_date(sysdate,   'dd-mon-yyyy hh24');
  IF lv_count > 0 THEN
    UPDATE portal_home_non_login_log
    SET counter = counter + 1
    WHERE to_date(logdatetime,   'dd-mon-yyyy hh24') = to_date(sysdate,   'dd-mon-yyyy hh24');
  ELSE
    INSERT
    INTO portal_home_non_login_log(logdatetime,   counter)
    VALUES(to_date(sysdate,   'dd-mon-yyyy hh24'),   1);
    DBMS_OUTPUT.PUT_LINE('FIRST NEW RECORD IS ADDED......!');
  END IF;
  COMMIT;
END;Result
================
LOGDATETIME COUNTER
06-JUL-07      4I have created a procedure which will stored the date and also the counter.
How do I stored hour together with the date ?
Which part of my coding should I change such that
when I run the procedure,the LOGDATETIME
will have date plus the hour of time.
E.g. Result 2 (below).
Result 2
=======================
LOGDATETIME COUNTER
06-JUL-07 13      4
06-JUL-07 14      9
06-JUL-07 15      3
06-JUL-07-16      4

Answer 1

There are a couple of things wrong in this procedure:
- A select count(*) to do a check for a value is not the most efficient way. If you suspect more updates than inserts, you could do the update and check SQL%ROWCOUNT for being 0 to do an insert. Or better yet, use "merge" as Nicolas suggested.
- Your input variables are named different than what is used in your procedure.
- Your counter input variable is not used and can be removed
- A commit inside a procedure is generally not recommended, because it makes it less reusable. Ideally you would let the caller decide about how a transaction is defined.
- As already said, a date has a time component, you just need to truncate or round it to get date + hours without minutes and seconds.
See this example:
SQL> create table portal_home_non_login_log
  2  ( logdatetime date
  3  , counter     number
  4  )
  5  /
Tabel is aangemaakt.
SQL> create or replace procedure library_portal_home
  2  ( ldt portal_home_non_login_log.logdatetime%type
  3  , cot portal_home_non_login_log.counter%type
  4  ) is
  5  lv_count number;
  6  begin
  7  select count(1)
  8  into lv_count
  9  from portal_home_non_login_log
10  where trunc(logdatetime) = trunc(sysdate);
11
12  if lv_count > 0 then
13
14  update portal_home_non_login_log
15  set counter = counter + 1
16  where trunc(logdatetime) = trunc(sysdate);
17  else
18  insert
19  into portal_home_non_login_log(logdatetime, counter)
20  values(sysdate, 1);
21  dbms_output.put_line('FIRST NEW RECORD IS ADDED......!');
22  end if;
23
24  end;
25  /
Procedure is aangemaakt.
SQL> exec library_portal_home(sysdate,5)
FIRST NEW RECORD IS ADDED......!
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/48,5)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/24,5)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/6,5)
PL/SQL-procedure is geslaagd.
SQL> select * from portal_home_non_login_log
  2  /
LOGDATETIME                                        COUNTER
09-07-2007 10:22:47                                      4
1 rij is geselecteerd.
SQL> rollback
  2  /
Rollback is voltooid.
SQL> create or replace procedure library_portal_home
  2  ( p_logdatetime in portal_home_non_login_log.logdatetime%type
  3  )
  4  is
  5  begin
  6    update portal_home_non_login_log
  7       set counter = counter + 1
  8     where trunc(logdatetime,'hh24') = trunc(p_logdatetime,'hh24')
  9    ;
10    if sql%rowcount = 0
11    then
12      insert into portal_home_non_login_log
13      ( logdatetime
14      , counter
15      )
16      values
17      ( trunc(p_logdatetime,'hh24')
18      , 1
19      );
20    end if;
21  end;
22  /
Procedure is aangemaakt.
SQL> exec library_portal_home(sysdate)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/48)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/24)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/6)
PL/SQL-procedure is geslaagd.
SQL> select * from portal_home_non_login_log
  2  /
LOGDATETIME                                        COUNTER
09-07-2007 10:00:00                                      1
09-07-2007 09:00:00                                      2
09-07-2007 06:00:00                                      1
3 rijen zijn geselecteerd.
SQL> rollback
  2  /
Rollback is voltooid.
SQL> create or replace procedure library_portal_home
  2  ( p_logdatetime in portal_home_non_login_log.logdatetime%type
  3  )
  4  is
  5  begin
  6    merge into portal_home_non_login_log
  7    using ( select p_logdatetime ldt from dual )
  8       on ( trunc(logdatetime,'hh24') = trunc(ldt,'hh24') )
  9     when matched then
10          update set counter = counter + 1
11     when not matched then
12          insert (logdatetime,counter) values (trunc(ldt,'hh24'),1)
13    ;
14  end;
15  /
Procedure is aangemaakt.
SQL> exec library_portal_home(sysdate)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/48)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/24)
PL/SQL-procedure is geslaagd.
SQL> exec library_portal_home(sysdate-1/6)
PL/SQL-procedure is geslaagd.
SQL> select * from portal_home_non_login_log
  2  /
LOGDATETIME                                        COUNTER
09-07-2007 10:00:00                                      1
09-07-2007 09:00:00                                      2
09-07-2007 06:00:00                                      1
3 rijen zijn geselecteerd.Regards,
Rob.