Dynamic update in Oracle 9i Release 9.2

Question

Hi all,
The update statement I want to execute depends on three variables. The statement is like this :
update fichier_tempo
               set flag = 0
               where substr(texte,7,2) = pcode_enreg
               and flag = 1
               and v_id = vcode;
In this statement : pcode_enreg , v_id and vcode are variables.
The statement may affect many rows.
I have already thought about using the execute immediate statement but it requires that the update affects only one row with the returning into clause.
So how to execute this dynamic update ?
Thank you very much indeed.

Answer 1

You have lots of errors in that code.
One of them is indeed the dynamic update where you say that the string "substr(texte,20,13)" should be equal to the string that's in vcode (in my example below: abcdefghijklm). This is probably not what you want.
First I'll show you a variant of your code, which lots of areas in it to improve on, but hey: it works ;-)
Then I'll show you one merge statement that does it all in once.
Hope it helps.
SQL> create table fichier_tempo
  2  as
  3  select 'xxxxxx50xxxxxxxxxxxabcdefghijklm' texte, 1 flag, 5 num from dual union all
  4  select 'xxxxxx50xxxxxxxxxxxabcdefghijklm', 1, 4 from dual union all
  5  select 'xxxxxx50xxxxxxxxxxxabcdefghijklm', 0, 3 from dual union all
  6  select 'xxxxxx50xxxxxxxxxxxabcdefghijklm', 1, 2 from dual union all
  7  select 'xxxxxx53xxxxxxxxxxxzyxwvutsrqpon', 0, 11 from dual union all
  8  select 'xxxxxx53xxxxxxxxxxxzyxwvutsrqpon', 1, 12 from dual union all
  9  select 'xxxxxx53xxxxxxxxxxxzyxwvutsrqpon', 0, 13 from dual
10  /
Tabel is aangemaakt.
SQL> create or replace procedure p_test397(pcode_enreg varchar2)
  2  is
  3    --vmotif conrej_fic.crf_lib_err%type := get_motif_rejet('397');
  4    v_id varchar2(40);
  5    vsql varchar2(4000);
  6    c_div sys_refcursor;
  7    vcode varchar2(13);
  8    nb number;
  9    vsql_div varchar2(4000);
10    updt_div sys_refcursor;
11  begin
12    select case pcode_enreg
13    when '50' then 'substr(texte,20,13)'
14    when '53' then 'substr(texte,20,4)'
15    when '56' then 'substr(texte,20,4)'
16    end
17    into v_id
18    from dual;
19
20    vsql := 'select '||v_id||',count(*) '||
21    'from fichier_tempo '||
22    'where flag = 1 '||
23    'and substr(texte,7,2) = '||pcode_enreg||' '||
24    'and num > 0 '||
25    'having count(*) > 1 '||
26    'group by '||v_id;
27
28    open c_div for vsql;
29
30    loop
31      fetch c_div into vcode,nb;
32      exit when c_div%notfound;
33
34      -- This is the dynamic update
35      execute immediate
36      'update fichier_tempo ' ||
37      'set flag = 0 ' ||
38      'where substr(texte,7,2) = ' || pcode_enreg || ' ' ||
39      'and flag = 1 ' ||
40      'and '||v_id||' = '''||vcode||''''
41      ;
42    end loop;
43    close c_div;
44  end;
45  /
Procedure is aangemaakt.
SQL> select * from fichier_tempo
  2  /
TEXTE                                                              FLAG                                 NUM
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      1                                   5
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      1                                   4
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   3
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      1                                   2
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  11
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      1                                  12
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  13
7 rijen zijn geselecteerd.
SQL> exec p_test397('50')
PL/SQL-procedure is geslaagd.
SQL> select * from fichier_tempo
  2  /
TEXTE                                                              FLAG                                 NUM
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   5
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   4
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   3
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   2
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  11
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      1                                  12
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  13
7 rijen zijn geselecteerd.
SQL> exec p_test397('53')
PL/SQL-procedure is geslaagd.
SQL> select * from fichier_tempo
  2  /
TEXTE                                                              FLAG                                 NUM
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   5
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   4
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   3
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   2
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  11
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      1                                  12
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  13
7 rijen zijn geselecteerd.
SQL> rollback
  2  /
Rollback is voltooid.
SQL> create procedure mytest397 (pcode_enreg in varchar2)
  2  is
  3  begin
  4    merge into fichier_tempo f1
  5    using ( select a, rid
  6              from ( select count(*) over
  7                            ( order by
  8                                case pcode_enreg
  9                                when '50' then substr(texte,20,13)
10                                when '53' then substr(texte,20,4)
11                                when '56' then substr(texte,20,4)
12                                end
13                            ) a
14                          , rowid rid
15                       from fichier_tempo
16                      where flag = 1
17                        and num > 0
18                        and substr(texte,7,2) = pcode_enreg
19                   )
20             where a > 1
21          ) f2
22    on (f1.rowid = f2.rid)
23    when matched then
24      update set flag = 0
25    when not matched then
26      insert values (null,null,null)  -- dummy line for version 9i
27    ;
28  end;
29  /
Procedure is aangemaakt.
SQL> select * from fichier_tempo
  2  /
TEXTE                                                              FLAG                                 NUM
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      1                                   5
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      1                                   4
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   3
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      1                                   2
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  11
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      1                                  12
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  13
7 rijen zijn geselecteerd.
SQL> exec mytest397('50')
PL/SQL-procedure is geslaagd.
SQL> select * from fichier_tempo
  2  /
TEXTE                                                              FLAG                                 NUM
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   5
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   4
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   3
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   2
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  11
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      1                                  12
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  13
7 rijen zijn geselecteerd.
SQL> exec mytest397('53')
PL/SQL-procedure is geslaagd.
SQL> select * from fichier_tempo
  2  /
TEXTE                                                              FLAG                                 NUM
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   5
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   4
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   3
xxxxxx50xxxxxxxxxxxabcdefghijklm                                      0                                   2
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  11
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      1                                  12
xxxxxx53xxxxxxxxxxxzyxwvutsrqpon                                      0                                  13
7 rijen zijn geselecteerd.Regards,
Rob.