Error in My Procedure

Question

Hi Guys,
Error is my stord Proc still not yet resolved, though it my proc not efficient way to write but at the moment I have only this option write it.
create or replace
PROCEDURE PROC_SEC_SYNCH3 IS
DATATYP CHAR(10);
BEGIN
FOR LR_UPDATE IN (SELECT SSM_ID,CYCLE_DATE,DESTINATION_TABLE,COLUMN_NAME,NEW_DATA,COLUMN_TYPE
FROM TEST_SYNCH
ORDER BY DESTINATION_TABLE, COLUMN_NAME)
LOOP
EXECUTE IMMEDIATE 'SELECT DATA_TYPE INTO DATATYP FROM ALL_TAB_COLUMNS WHERE TABLE_NAME = '||LR_UPDATE.DESTINATION_TABLE|| 'AND COLUMN_NAME ='|| LR_UPDATE.COLUMN_NAME;
IF DATATYP ='VARCHAR2' THEN
EXECUTE IMMEDIATE 'UPDATE ' || lr_Update.destination_table ||' AS dest SET dest.'||lr_Update.column_name||' =
cast( (select src.new_data from test_synch src where src.ssm_id = '||lr_Update.destination_table||'.ssm_id;) as varchar2)
where src.ssm_id = '||lr_Update.destination_table||'.ssm_id';
END IF;
END LOOP;
COMMIT; --
END PROC_SEC_SYNCH3;
Error is
ORA-00933: SQL command not properly ended
ORA-06512: at "SCOTT.PROC_SEC_SYNCH3", line 9
ORA-06512: at line 2
not really sure why it is occuring, plz help me out.
Cheers.

Answer 1

Your code has lot of errors. I have modified. Go through the code and see if you can understand the changes i have done.
Let me know if you have any questions.
create or replace procedure proc_sec_synch3
is
     datatyp char(10);
     lSqlString varchar2(30000);
begin
     for lr_update in (
                  select ssm_id,cycle_date,destination_table,column_name,new_data,column_type
                    from test_synch
                   order by destination_table, column_name
     loop
          select data_type into datatyp
            from all_tab_columns
           where table_name = upper(lr_update.destination_table)
            and column_name = upper(lr_update.column_name);
          if datatyp ='varchar2' then
               lSqlString := 'update #TABLE# as dest
                           set #COLUMN# = cast(
                                          select src.new_data
                                            from test_synch src
                                           where src.ssm_id = #TABLE#.ssm_id
                                        ) as varchar2
                         where src.ssm_id = #TABLE#.ssm_id';          
               lSqlString := REPLACE(lSqlString, '#TABLE#', lr_update.destination_table);
               lSqlString := REPLACE(lSqlString, '#COLUMN#', lr_update.column_name);
               execute immediate lSqlString;
          end if;
     end loop;
     commit; 
end proc_sec_synch3;