ERROR IN PROCEDURE

Question

I'm trying to write a procedure that will compute the start and end dates of the weeks within a period, etc. Number of business days in a week is 5; that is, Monday to Friday.
The first part of the code I have to write is giving me problems please help. The table below was created:
Wrote file afiedt.buf
1 CREATE TABLE WEEKS
2 (WEEKID VARCHAR2(20),
3 TRANSACTION_YEAR VARCHAR2(20),
4 START_DATE DATE,
5 END_DATE DATE,
6 DAYS VARCHAR2(20),
7* WEEK_NUMBER VARCHAR2(20))
SQL> /
Table created.
SQL> --- Code To Generate start date, end date weekid, week number, etc in A financial Year
SQL> Create OR REPLACE PROCEDURE Weeksinyear IS
2 BEGIN
3 declare
4 sdate_v weeks.start_date%type;
5 edate_v weeks.end_date%type;
6 ndays_v weeks.days%type;
7 nweek_v Weeks.week_number%type;
8 weekid_v weeks.weeksid%type;
9 transyear_v weeks.weeks.transaction_year%type;
10 numbweeks_v number;
11 fyearst_v date;
12 fyeared_v date;
13 totaldays_V number;
14 i number;
15 d number;
16 begin
17 fyearst_v := '05-jan-2004';
18 fyeared_v := '26-jan-2004';
19 sdate := fyearst_v;
20 transyear_v := to_char('05-jan-2004','yyyy');
21 nweek_v :=1;
22 ndays_v := 5;
23 totaldays_v := to_number(to_date(fyeared) - to_date(fyearst));
24 nweekid_v :=1;
25 i := 1;
26 loop
27 If to_char(fyearst_v,'DAY') ='MONDAY ' then
28 loop
29 i := i + 4;
30 if i < totaldays_v then
31 d := to_number(totaldays_v - i);
32 edate_v := (sdate_v + (d - 1));
33 elseif i = totaldays_v then
34 edate_v := sdate_v + 4;
35 elseif i < totaldays then
36 edate := (sdate + 4);
37 endif;
38 weekid_v := (i||'000'||'i');
39 insert into weeks(weekid, transaction_year, start_date, end_date, days, week_number)
40 values(weekid_v,transyear, sdate_v, ndays, nweek_v);
41 if totaldays_V > 7 then
42 weekid_v := weekid + 1;
43 sdate_v := sdate_v + 7;
44 transyear_V := transyear_v;
45 nweek_v := nweek_v + 1;
46 ndays_v := ndays_v;
47 totaldays_v := to_number(totaldays_v - 7);
48 else exit;
49 end loop;
50 else exit;
51 end loop;
52 end;
53 END;
54 /
Warning: Procedure created with compilation errors.
SQL> sho err;
Errors for PROCEDURE WEEKSINYEAR:
LINE/COL ERROR
33/35 PLS-00103: Encountered the symbol "I" when expecting one of the
following:
:= . ( @ % ;
35/35 PLS-00103: Encountered the symbol "I" when expecting one of the
following:
:= . ( @ % ;
49/23 PLS-00103: Encountered the symbol "LOOP" when expecting one of
the following:
if
LINE/COL ERROR
51/17 PLS-00103: Encountered the symbol "LOOP" when expecting one of
the following:
if
SQL>

Answer 1

So many things, I don't really know where to start.
At line 32
IF TO_CHAR(fyearst,'DAY') ='MONDAY ' then
Will never be true it needs to be either
IF TO_CHAR(fyearst,'DAY') ='MONDAY ' THEN -- A total of 9 characters (padded to the length of WEDNESDAY) or
IF TRIM(TO_CHAR(fyearst,'DAY')) ='MONDAY' THEN
Fixing this leads to a second problem in the inner loop. At line 35
IF i < totaldays THEN
is logically incorrect. The variable i will take the values 5, 9, 13, 17 and enter the if condition, but will not be equal to totaldays at line 38. On the fifth iteration i = 21 so the conditional at line 35 fails and you have an infinite loop, so the test needs to be:
IF i <= totaldays THEN
to even get into any of your processing. Now, on the fifth pass, the conditional on line 38 (IF i = totaldays THEN ) will be true, so edate gets set, but the condition on line 40 (IF i > totaldays THEN) can never be true, so we're back to an infinite loop.
So change line 40 to
IF i >= totaldays THEN
Now, the insert gets done, and the test at line 45 (IF totaldays > 7 THEN) passes and totaldays gets reset, and we go back to the top of the inner loop. Now, i = 21 and totaldays = 14, so the condition at line 35 fails, and again, we're in an infinite loop, so lets reset i as well as totaldays.
Now i still goes 5, 9, 13, 17, 21 but totaldays = 14, so the test at line 38 is never true, and once more, an infinite loop.
At this point I gave up and put an explicit exit after the insert statement, just to see what should be inserted, and got another infinite loop in the outer loop because there is no terminating condition on the loop since fyearst never gets changed. Having seen some output, I think what you are looking for is something more like:
INSERT INTO weeks
SELECT rownum, TO_CHAR(TO_DATE('05-jan-2004','dd-mon-yyyy'),'YYYY'),
       NEXT_DAY(TO_DATE('05-jan-2004','dd-mon-yyyy') - 7,'MONDAY') + ((rownum - 1) * 7),
       NEXT_DAY(TO_DATE('05-jan-2004','dd-mon-yyyy') + 1,'FRIDAY') + ((rownum - 1) * 7),
       '5', TO_CHAR(rownum)
FROM all_objects
WHERE rownum <= 52or, if you really want a procedure:
CREATE OR REPLACE PROCEDURE weeksinyear (p_start IN DATE, p_end IN DATE) AS
   num_weeks NUMBER;
BEGIN
   num_weeks := (NEXT_DAY(p_end,'MONDAY') - NEXT_DAY(p_start - 7,'MONDAY')) /7;
   INSERT INTO weeks
   SELECT rownum, TO_CHAR(p_start,'YYYY'),
          NEXT_DAY(p_start - 7,'MONDAY') + ((rownum - 1) * 7),
          NEXT_DAY(p_start + 1,'FRIDAY') + ((rownum - 1) * 7),
          '5', TO_CHAR(rownum)
   FROM all_objects
   WHERE rownum <= num_weeks;
   COMMIT;
END;If you will always want to do this for an entire year, then the procedure could be simplified to:
CREATE OR REPLACE PROCEDURE weeksinyear (p_start IN DATE) AS
BEGIN
   INSERT INTO weeks
   SELECT rownum, TO_CHAR(p_start,'YYYY'),
          NEXT_DAY(p_start - 7,'MONDAY') + ((rownum - 1) * 7),
          NEXT_DAY(p_start + 1,'FRIDAY') + ((rownum - 1) * 7),
          '5', TO_CHAR(rownum)
   FROM all_objects
   WHERE rownum <= 52;
   COMMIT;
END;TTFN
John