Error in VBA Code

Question

Hey.
I have Record those 2 macro's
the first one WORKS Fine.
but when running the second macro it came with error....
Sub IndsætUdeblevet()
'Macro 1
' IndsætUdeblevet Makro
    ActiveWindow.SmallScroll Down:=15
    ActiveSheet.Shapes.AddShape(msoShapeHorizontalScroll, 74.25, 440.25, 408.75, _
        153).Select
    Selection.ShapeRange.ShapeStyle = msoShapeStylePreset7
    ActiveSheet.Shapes.AddTextbox(msoTextOrientationHorizontal, 103.5, 471, 367.5, _
        92.25).Select
    Selection.ShapeRange.TextFrame2.TextRange.Font.Size = 18
    Selection.ShapeRange.TextFrame2.TextRange.ParagraphFormat.Alignment = _
        msoAlignCenter
    Selection.ShapeRange(1).TextFrame2.TextRange.Characters.Text = _
        "Udeholdet" & Chr(13) & "Udeblevet Fra Kamp uden AFBUD..." & Chr(13) & ""
    With Selection.ShapeRange(1).TextFrame2.TextRange.Characters(1, 10). _
        ParagraphFormat
        .FirstLineIndent = 0
        .Alignment = msoAlignCenter
    End With
    With Selection.ShapeRange(1).TextFrame2.TextRange.Characters(1, 10).Font
        .NameComplexScript = "+mn-cs"
        .NameFarEast = "+mn-ea"
        .Fill.Visible = msoTrue
        .Fill.ForeColor.RGB = RGB(0, 0, 0)
        .Fill.Transparency = 0
        .Fill.Solid
        .Size = 18
        .Name = "+mn-lt"
    End With
    With Selection.ShapeRange(1).TextFrame2.TextRange.Characters(11, 33). _
        ParagraphFormat
        .FirstLineIndent = 0
        .Alignment = msoAlignCenter
    End With
    With Selection.ShapeRange(1).TextFrame2.TextRange.Characters(11, 33).Font
        .NameComplexScript = "+mn-cs"
        .NameFarEast = "+mn-ea"
        .Fill.Visible = msoTrue
        .Fill.ForeColor.RGB = RGB(0, 0, 0)
        .Fill.Transparency = 0
        .Fill.Solid
        .Size = 18
        .Name = "+mn-lt"
    End With
End Sub
Sub FJernSkilt()
'Macro 2
' FJernSkilt Makro
    ActiveSheet.Shapes.Range(Array("Horizontal Scroll 23")).Select
    Selection.Delete      
    ActiveSheet.Shapes.Range(Array("TextBox 24")).Select
    Selection.Delete
    Range("BY26").Select
    ActiveWindow.SmallScroll Down:=-21
    Range("F6:N6").Select
End Sub
your regards Henrik-1

Answer 1

The reason that the second on errors is that it could not find the shapes by the names. Each time you run the code to create a new shape then the default name changes the suffix number and the second macro is always referencing the same name.
If you want to be able to reference the shapes later then it is necessary to give them a name when they are created like the following immediately after the line of code to add the shape or text box.
There are better ways of editing the code but because it appears you are a beginner, I will not to confuse you at this stage with more advanced programming.
    ActiveSheet.Shapes.AddShape(msoShapeHorizontalScroll, 74.25, 440.25, 408.75, _
        153).Select
    Selection.Name = "My Scroll"
    ActiveSheet.Shapes.AddTextbox(msoTextOrientationHorizontal, 103.5, 471, 367.5, _
        92.25).Select
    Selection.Name = "My Text Box"
then in the second macro use those same names like the following.
Sub FJernSkilt()
 'Macro 2
 ' FJernSkilt Makro
     ActiveSheet.Shapes.Range(Array("My Scroll")).Select
    Selection.Delete
     ActiveSheet.Shapes.Range(Array("My Text Box")).Select
     Selection.Delete
     Range("BY26").Select
     ActiveWindow.SmallScroll Down:=-21
     Range("F6:N6").Select
 End Sub
Regards, OssieMac