Error: java.lang.OutOfMemoryError when uploading CSV files to web server

Question

Hi experts,
I have made a JSP page from which clients load csv files to web server. I am using Tomca 4.1 as my web server and JDK 1.3.1_09.
The system works fine when uploadiing small csv files, but it crashes when uploading large CSV files.
It gives me the following error:
java.lang.OutOfMemoryError
     <<no stack trace available>>
This is the code that I used to load files....
<%
String saveFile = "";
String contentType = request.getContentType();
if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0))
     DataInputStream in = new DataInputStream(request.getInputStream());
     int formDataLength = request.getContentLength();
     byte dataBytes[] = new byte[formDataLength];
     int byteRead = 0;
     int totalBytesRead = 0;
     while (totalBytesRead < formDataLength)
          byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
          totalBytesRead += byteRead;
     String file = new String(dataBytes);
     saveFile = file.substring(file.indexOf("filename=\"") + 10);
     saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
     saveFile = saveFile.substring(saveFile.lastIndexOf("\\") + 1,saveFile.indexOf("\""));
     int lastIndex = contentType.lastIndexOf("=");
     String boundary = contentType.substring(lastIndex + 1,contentType.length());
     int pos;
     pos = file.indexOf("filename=\"");
     pos = file.indexOf("\n", pos) + 1;
     pos = file.indexOf("\n", pos) + 1;
     pos = file.indexOf("\n", pos) + 1;
     int boundaryLocation = file.indexOf(boundary, pos) - 4;
     int startPos = ((file.substring(0, pos)).getBytes()).length;
     int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;
     String folder = "f:/Program Files/Apache Group/Tomcat 4.1/webapps/broadcast/file/";
     //String folder = "10.28.12.58/bulksms/";
     FileOutputStream fileOut = new FileOutputStream(folder + saveFile);
     //out.print("Saved here: " + saveFile);
     //fileOut.write(dataBytes);
     fileOut.write(dataBytes, startPos, (endPos - startPos));
     fileOut.flush();
     fileOut.close();
     out.println("File loaded successfully");
//f:/Program Files/Apache Group/Tomcat 4.1/webapps/sms/file/
%>
Please can anyone help me solve this problem for me...
Thanx...
Deepak

Answer 1

I know it may be hard to throw away all this code, but consider using the jakarta fileupload component.
I think it would simplify your code down to
// Create a factory for disk-based file items
FileItemFactory factory = new DiskFileItemFactory();
// Create a new file upload handler
ServletFileUpload upload = new ServletFileUpload(factory);
// Parse the request
List /* FileItem */ items = upload.parseRequest(request);
// Process the uploaded items
Iterator iter = items.iterator();
while (iter.hasNext()) {
    FileItem item = (FileItem) iter.next();
    if (item.isFormField()) {
        processFormField(item);
    } else {
        // item is a file.  write it
        File saveFolder = application.getRealPath("/file");          
        File uploadedFile = new File(saveFolder, item.getName());
        item.write(uploadedFile);
}Most of this code was hijacked from http://jakarta.apache.org/commons/fileupload/using.html
Check it out. It will solve your memory problem by writing the file to disk temporarily if necessary.
Cheers,
evnafets