Error on a simple function to fill an array plz hlp

Question

Hi guys.
I'm trying to fill in an array with a simple function, here is the code
public class rekener {
    int getal;
    int counter=-1;
    int[] getallen= new int[5];
    StringBuffer buffer= new StringBuffer();
    public void getGetal(int getal){
        this.getal= getal;
        counter++;
        getallen[counter]= getal;
    public String getArray(){
       for(int i: getallen){
           buffer.append(i);
       return buffer.toString();
}i'm calling this function from a console application in this way....
import java.util.Scanner;
class venster{
   public static void main(String args[]){
       int getal;
       rekener rekener= new rekener();
       Scanner input= new Scanner(System.in);
       System.out.println("Voeg toe een nummer A.U.B");
       getal= input.nextInt();
       rekener.getGetal(getal);
       System.out.println("voeg nog een nummer toe");
       getal= input.nextInt();
       rekener.getGetal(getal);
       System.out.println("voeg nog een nummer toe");
       getal= input.nextInt();
       rekener.getGetal(getal);
       System.out.println("voeg nog een nummer toe");
       getal= input.nextInt();
       rekener.getGetal(getal);
       System.out.println("voeg nog een nummer toe");
       getal= input.nextInt();
       rekener.getGetal(getal);
       System.out.println("voeg nog een nummer toe");
       getal= input.nextInt();
       rekener.getGetal(getal);
       String list= rekener.getArray();
       System.out.println(""+list);
}the problem is that the last function "getGetal();" which should deliver the StrinBuffer in a string format, does not do so, but gives me this error
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 5
        at rekener.getGetal(rekener.java:22)
        at venster.main(venster.java:37)
Java Result: 1the line 22 is this :
getallen[counter]= getal;this makes me think that the function that should fill the array isn't really doing it,
Even if i change the volume of the array to 4 or 6 "even though 5 is the correct ammount since i'm inserting 6 integers", keeps on giving me the same error
Do you now any other solution in order to fill in an array from an external function?
Thank you and have a nice day
Edited by: classboy on Dec 12, 2009 11:01 PM

Answer 1

classboy wrote:
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 5
at rekener.getGetal(rekener.java:22)
at venster.main(venster.java:37)The error message is telling you exactly what's wrong. On linke 22 of rekener.java (should be Rekener--class names conventionally start with uppercase), you are trying to access the 6th element, at index 5, of an array that has at more 5 elements, at indices 0..4
the line 22 is this :
getallen[counter]= getal;
So counter is 5. But getallen has only 5 elements at indices 0..4, or fewer.
this makes me think that the function that should fill the array isn't really doing it, It has nothing to do with whether the array is being "filled." Rather, it's just that the size of the array is less than what you're trying to access.
Even if i change the volume of the array to 4 or 6 "even though 5 is the correct ammount since i'm inserting 6 integers", keeps on giving me the same errorNo idea what you're saying here, but the compiler doesn't lie. You're trying to access an array element that doesn't exist.
Put print statements in your code so you can see what's happening at each step of the way, and figure out what you did to tell it to access elements that don't exist.