Error while compling a Function:

Question

Hi,
I am unable to complie a function as shown below:
CREATE OR REPLACE FUNCTION GET_SUBS_TYPE_KEY(
SUBNO VARCHAR2 DEFAULT NULL
RETURN SUBS_TYPE_KEY_1 PIPELINED AS
V_SUBNO VARCHAR2(40);
V_PAID VARCHAR2(10);
V_SUBS_TYP_KEY VARCHAR2(10);
V_VAL1 VARCHAR2(255);
CURSOR C1_REC IS SELECT SUBNO,PREPOST_PAID,SUBS_TYPE_KEY
FROM CTVA_ETL.RA_CRM_USER_INFO,DIM_SUBSCRIBER_TYPE
WHERE SUBSTR(DIM_SUBSCRIBER_TYPE.SUBS_TYPE_DESC,1,4)=RA_CRM_USER_INFO.PREPOST_PAID
--WHERE MSISDN='8615025400109'
--WHERE MSISDN IN ('8615025400068','8615025400083','8615025400101','8615025400132','8615025400109')
GROUP BY SUBNO,PREPOST_PAID,SUBS_TYPE_KEY;
BEGIN
OPEN C1_REC;
LOOP
FETCH C1_REC INTO V_SUBNO SUBNO_TYP_1,V_PAID,V_SUBS_TYP_KEY SUBS_TYP_KEY;
--DBMS_OUTPUT.PUT_LINE('THE MSISDN VALUE'||V_MSISDN);
EXIT WHEN C1_REC%NOTFOUND;
IF V_PAID='PREP' THEN
V_SUBS_TYP_KEY ='2';
ELSIF V_PAID='POST' THEN
V_SUBS_TYP_KEY ='2';
ELSE
V_SUBS_TYP_KEY ='-99';
LOOP
PIPE ROW ( SUBS_TYPE_KEY(C1_REC.SUBNO_TYP_1 ,C1_REC.SUBS_TYP_KEY ));
END LOOP;
END LOOP;
RETURN;
CLOSE C1_REC;
END;
its giving error in the SUBNO_TYP_1 Type

Answer 1

Un-formatted code is nothing but garbage. So always format your code.
CREATE OR REPLACE FUNCTION get_subs_type_key(
                         subno VARCHAR2 DEFAULT NULL) RETURN subs_type_key_1 pipelined
AS
     v_subno      VARCHAR2(40);
     v_paid           VARCHAR2(10);
     v_subs_typ_key  VARCHAR2(10);
     v_val1           VARCHAR2(255);
     CURSOR c1_rec
     IS
     SELECT subno,
            prepost_paid,
            subs_type_key
       FROM ctva_etl.ra_crm_user_info,
            dim_subscriber_type
      WHERE SUBSTR(dim_subscriber_type.subs_type_desc, 1, 4) = ra_crm_user_info.prepost_paid
      GROUP BY subno,
            prepost_paid,
            subs_type_key;
BEGIN
     OPEN c1_rec;
     LOOP
          FETCH c1_rec INTO v_subno subno_typ_1, v_paid, v_subs_typ_key; <<-- Here i removed subs_typ_key Only god knows why you had it there.
          --DBMS_OUTPUT.PUT_LINE('THE MSISDN VALUE'||V_MSISDN);
          EXIT WHEN c1_rec % NOTFOUND;
          IF v_paid = 'PREP'
          THEN
               v_subs_typ_key = '2';
          ELSIF v_paid = 'POST'
          THEN
               v_subs_typ_key = '2';
          ELSE
               v_subs_typ_key = '-99';
               LOOP
                    pipe ROW(subs_type_key(c1_rec.subno_typ_1,   c1_rec.subs_typ_key));
               END LOOP;
          ENDIF; <<-- Here i closed your IF statement
     END LOOP;
     RETURN;
     CLOSE c1_rec;
END;