Event Table won't work

Question

This is my tables and data:
CREATE TABLE Client
(Client_Code CHAR (4) PRIMARY KEY,
Client_Name CHAR (15),
Client_Address CHAR (20),
Client_City CHAR (22),
Client_State CHAR (2),
Client_Zip CHAR (5),
Client_Phone CHAR (10) );
CREATE TABLE Event
(Event_Code (2) PRIMARY KEY,
Client_Code CHAR (4),
Event_Day CHAR (20),
Event_Date DATE,
Event_Menu CHAR (35) );
CREATE TABLE Supply
(Supply_Code CHAR (5) PRIMARY KEY,
Supply_Name CHAR (25),
Supply_Quantity CHAR (5),
Supply_Cost CHAR (6) );
CREATE TABLE Provider
(Provider_Code CHAR (7) PRIMARY KEY,
Supply_Code CHAR (5),
ProviderName CHAR (15) );
INSERT INTO Client
VALUES ('1000', 'Tom Kane', '1019 Dungan St', 'Philadelphia', 'PA', '19152', '2156732216');
INSERT INTO Client
VALUES ('1001', 'Mark Rocca', '343 Capital Way', 'Washington', 'DC', '62359', '4646932668');
INSERT INTO Client
VALUES ('1002', 'Larry Cone', '7275 Dennis Road', 'Santa Monica', 'CA', '49215', '6095576339');
INSERT INTO Client
VALUES ('1003', 'Sally Finegan', '6628 Lynford St', 'Wildwood', 'NJ', '23462', '2678923650');
INSERT INTO Client
VALUES ('1004', 'Hal Romero', '8620 Colony Dr', 'Tampa', 'FL', '73068', '7639958636');
INSERT INTO Event
VALUES ('00', '1000', 'Friday', '12-MAY-2010', 'Steak and Lobster');
INSERT INTO Event
VALUES ('01', '1001', 'Monday', '22-MAY-2010', 'Deli Sandwiches');
INSERT INTO Event
VALUES ('02', '1002', 'Saturday', '30-MAY-2010', 'Pancakes and Eggs');
INSERT INTO Event
VALUES ('03', '1003', 'Tuesday', '11-JUNE-2010', 'Roast Beef and Pork');
INSERT INTO Event
VALUES ('04', '1004', 'Sunday', '26-JUNE-2010', 'Meatballs and Pasta');
INSERT INTO Supply
VALUES ('10001', 'Golden Quality', '100', '12050');
INSERT INTO Supply
VALUES ('10002', 'Market Fresh', '125', '14199');
INSERT INTO Supply
VALUES ('10003', 'Pantry Fresh', '150', '9687');
INSERT INTO Supply
VALUES ('10004', 'Gold Quality', '175', '10567');
INSERT INTO Supply
VALUES ('10005', 'America Choice', '200', '8623');
INSERT INTO Provider
VALUES ('50001', '10001', 'Walmart');
INSERT INTO Provider
VALUES ('50002', '10002', 'Target');
INSERT INTO Provider
VALUES ('50003', '10003', 'Pathmark');
INSERT INTO Provider
VALUES ('50004', '10004', 'Acme');
INSERT INTO Provider
VALUES ('50005', '10005', 'Superfresh');
I having everything working correctly except the Event Data. I am getting the following error:
CREATE TABLE Event
(Event_Code (2) PRIMARY KEY,
Client_Code CHAR (4)
Event_Day CHAR (20),
Event_Date DATE,
Event_Menu CHAR (35) )
ORA-00902: invalid datatype

Answer 1

You never specified a data type for your EVENT_CODE.
CREATE TABLE Event
(Event_Code <MISSING DATA TYPE> (2) PRIMARY KEY,
Client_Code CHAR (4)
Event_Day CHAR (20),
Event_Date DATE,
Event_Menu CHAR (35) )Also after taking a look at this model I have a question. How come there are no foreign keys? For example I would assume that the CLIENT_CODE in the EVENT_TABLE references the CLIENT table?
What's the purpose of EVENT_DAY? What does that store. If it is the day of the week or something like that then you don't need that column and you can use TO_CHAR() function against the EVENT_DATE to get that information.
Finally, I see you are using a lot of CHAR based columns. Any particular reason? Unless your column values are always going to be the maximum you should consider using VARCHAR2 instead.
Edited by: Centinul on Apr 26, 2010 2:50 PM