First PKGBUILD (gsplit) - can you check ??

Question

Hello
I wrote my first PKGBUILD, for the gsplit program. But before uploading it to AUR I wonder if someone experienced could check it ?
Thank you in advance
(PS : sorry for my bad english)
# $Id: PKGBUILD, 2009/02/22$
# Maintainer: IDontWantToBeSpamed <IDontWantToBeSpamed>
# Contributor: IDontWantToBeSpamed <IDontWantToBeSpamed>
pkgname=gsplit-svn
pkgver=20090222
pkgrel=1
pkgdesc="frontend for split, written in java"
arch=(i686 x86_64)
url="http://www.respawner.fr/gsplit/"
license=('GPL3')
groups=
provides=('gsplit')
depends=('java-runtime' 'java-gnome')
makedepends=('subversion' 'apache-ant')
source=()
md5sums=()
build() {
name=gsplit
cd $startdir/src
svn co http://www.respawner.fr/$pkgname/trunk/$name/
cd $name
mkdir libs
CLASSPATH=/usr/local/share/java/gtk.jar ant dist
cd build
mkdir -p $startdir/pkg/usr/share/$name
mkdir -p $startdir/pkg/usr/share/java/$name
mkdir -p $startdir/pkg/usr/bin
mv data $startdir/pkg/usr/share/$name
mv po $startdir/pkg/usr/share/$name
mv gsplit.jar $startdir/pkg/usr/share/java/$name
echo '#! /bin/sh' > $startdir/pkg/usr/bin/$name
echo 'java -classpath /usr/local/share/java/gtk.jar:/usr/share/java/gsplit/gsplit.jar gsplit.GSplit' >> $startdir/pkg/usr/bin/$name
chmod +x $startdir/pkg/usr/bin/$name

Answer 1

OK Thanks ... I will modify the PKGBUILD.
new version :
# $Id: PKGBUILD, 2009/02/22$
# Maintainer: ***** <***>
# Contributor: ***** <***>
pkgname=gsplit-svn
pkgver=148
pkgrel=1
pkgdesc="frontend for split, written in java"
arch=(i686 x86_64)
url="http://www.respawner.fr/gsplit/"
license=('GPL3')
groups=
provides=('gsplit')
depends=('java-runtime' 'java-gnome')
makedepends=('subversion' 'apache-ant')
source=(gsplit.desktop)
md5sums=('430bf9e6c3eb824edbaa886e4ce1c482')
_svntrunk="http://www.respawner.fr/$pkgname/trunk/gsplit"
_svnmod="gsplit"
build() {
name=gsplit
mkdir -p $startdir/pkg/usr/share/$name
mkdir -p $startdir/pkg/usr/share/java/$name
mkdir -p $startdir/pkg/usr/bin
mkdir -p $startdir/pkg/usr/share/icons
mkdir -p $startdir/pkg/usr/share/applications
cd $startdir/src
mv $name.desktop $startdir/pkg/usr/share/applications
svn co $_svntrunk $_svnmod
cd $name
mkdir libs
CLASSPATH=/usr/local/share/java/gtk.jar ant dist
cd build
cp data/logo.png $startdir/pkg/usr/share/icons/gsplit.png
mv data $startdir/pkg/usr/share/$name
mv po $startdir/pkg/usr/share/$name
mv gsplit.jar $startdir/pkg/usr/share/java/$name
echo '#! /bin/sh' > $startdir/pkg/usr/bin/$name
echo 'java -classpath /usr/local/share/java/gtk.jar:/usr/share/java/gsplit/gsplit.jar gsplit.GSplit' >> $startdir/pkg/usr/bin/$name
chmod +x $startdir/pkg/usr/bin/$name
desktop :
[Desktop Entry]
Encoding=UTF-8
Name=gsplit
Comment=frontend for split
GenericName=
Type=Application
TryExec=gsplit
Exec=gsplit
Icon=gsplit.png
Terminal=false
X-MultipleArgs=false
Categories=GTK;Application;Utility;
Last edited by akira86 (2009-02-22 23:15:54)