Fixing this TRIGGER Syntax

Question

I am practicing Triggers in SQL Server 2012.  Please help me correct this Trigger Syntax for this practice question below.
 Build a trigger on the emp table after insert that adds a record into the emp_History table and marks IsActive column to 1
CREATE TRIGGER trgAfterInsert ON [dbo].[emp_triggers] 
FOR INSERT
AS
declare @empid int;
declare @empname varchar(100);
       declare @isactive int;
select @empid=i.empid from inserted i;
select @empname=i.empname from inserted i;
set   @isactive= 1;
insert into emphistory
           (empid, empname) 
values(@empid, @empname, @isactive) ;
PRINT 'AFTER INSERT trigger fired.'

Answer 1

Your trigger does not work if an insert statement inserts multiple rows into your emp_triggers table.  Never write triggers that only work correctly when 1 row is inserted, updated, or deleted by one command.  You want
CREATE TRIGGER trgAfterInsert ON [dbo].[emp_triggers]
FOR INSERT
AS
insert into emphistory
(empid, empname, isactive)
select empid, empname, 1 from inserted ;
which will work correctly no matter how many rows (0, 1, or many) are inserted by one INSERT command.
Tom