[Function] -Query in result

Question

Hi,
I write the below function to display the bonus of employees
create or replace function Bonus_val (description in varchar2) return number
is
v_bonus number;
cursor j1 is
select description,salary from employee_290512;
begin
for v1 in j1 loop
if v1.description='Tester' then
v_bonus := v1.salary*15;
elsif v1.description='Manager' then
v_bonus := v1.salary*30;
elsif v1.description='Programmer' then
v_bonus := v1.salary*45;
return v_bonus;
end if;
end loop;
end;
whose having a salary range like below
6544.78
1234.56
6661.78
2344.78
2334.78
4322.78
7897.78
1232.78
But while testing the above function it's showing the same values for all category, i"m confused could any one clarify on this please.
Regards
Thelak

Answer 1

I'm not entirely sure what you are trying to accomplish here, but the logic is definitely flawed.
The function as written will attempt to read all of the rows from the employee_29051 table. since there is no predicate in the query, it will very likely do it through a full table scan. When the first row of the table is read from the cursor, it will assign a value to v_bonus based on the description field in the first row, and return that to the caller. given a full table scan every time, it is extremely likely that it will do that based on the same row everytime.
Further, the passed parameter description, is never used. It is also a really bad idea to give parmeters the same name as the columns in your tables.
If you post some sample data form the table, and the expected output from the function call based on that data, perhaps someone could sort you out.
John