Grant execute to all custom stored procedures, not quite working

Question

I would like to grant execute permissions on all custom stored procedures to a group and have tried using this:
USE myDB
select 'GRANT EXECUTE ON ['+name+'] TO [mydomain\mydb] '  from sys.objects  where type ='P' and is_ms_shipped = 0
It seems to execute without error, I see the full list of stored procedures I've created listed like this:
GRANT EXECUTE ON [procUserInsert] TO [mydomain\mydb]
However the stored procedure I added earlier, which didn't have any explicit rights set for it, does not show that the execute permission has been granted. Other stored procedures, where I had already granted execute to the group, remain as they were (which
is expected). I'm viewing permissions via ssms, selecting the new stored procedure, then properties, permissions. If the grant failed there ought to be an error message...I don't get it. This is sql server 2005.

Answer 1

It seems like you were only printing the statement (SELECT), but it is unclear if you executed them.
You could try granting EXECUTE permission at either the DB scope or SCHEMA scope. That would grant EXECUTE on all modules (i.e. SPs, UDFs, etc.) at the chosen scope, including modules created in the future. For example:
-- Grant EXECUTE permission on all DB
GRANT EXECUTE TO [myDomain\mydbGroup1]
go
-- Grant EXECUTE permission on schema mySchema
GRANT EXECUTE ON SCHEMA::[mySchema] TO [myDomain\mydbGroup2]
go
I hope this helps.
BTW. The way you were creating the dynamic SQL for granting permissions to SPs individually is subject to 2^nd order injection attacks. You should use quotename(name) in order to escape object names.
-Raul Garcia
 SQL Server Security
This posting is provided "AS IS" with no warranties, and confers no rights.