Hashing Passwords

Question

Ok, Here's my code that I recieved from a friend...but....My
DB isn't updating. Am I missing a step?
<!--- Retrieve the existing users so we can loop them and
update their password
with its equivalent hashed value. --->
<cfquery name="myQuery" datasource="myDatasource">
SELECT Username, Password
FROM MyUserTable
</cfquery>
<!--- Loop the query results. --->
<cfloop query="myQuery">
UPDATE MyUserTable
SET Password = '#Hash(myQuery.Password)#'
WHERE Username = '#myQuery.Username#'
</cfloop>

Answer 1

Not sure if it will make a difference, but since you are
using query="myQuery" in your cfloop, you don't have to repeat
myQuery in your variable names within the second cfquery.
(Also, you can use cfoutput instead of cfloop. Not sure which one
is more efficient.)
<!--- Retrieve the existing users so we can loop them and
update their password
with its equivalent hashed value. --->
<cfquery name="myQuery" datasource="myDatasource">
SELECT Username, Password
FROM MyUserTable
</cfquery>
<!--- Loop the query results. --->
<cfoutput query="myQuery">
UPDATE MyUserTable
SET Password = '#Hash(Password)#'
WHERE Username = '#Username#'
</cfoutput>
Phil