Help on moving specific files using folder actions

Question

so i want to move all downloaded files that have the extension .pdf to a folder in my docs but it doesnt always work and if i download 2 at once it fails. im new to applescripts so please help!
this is what i have:
on adding folder items to this_folder after receiving added_items
tell application "Finder"
repeat with all_items in this_folder
if the name extension of any_item is "pdf" then
move item to folder "Macintosh HD:Users:Campbell:Documents:Printing"
end if
end repeat
end tell
end adding folder items to

Answer 1

As written, you are referring to different variables in your repeat loop for the added items (all_items, any_item, etc). The loop variable you define in the repeat statement is the one to use.
Snow Leopard added a time delay to check if items are still being downloaded, but in Leopard you will need to do it yourself. The following script adds a wait handler that will wait for files to be downloaded (I also threw in a run handler for testing):
<pre style="
font-family: Monaco, 'Courier New', Courier, monospace;
font-size: 10px;
font-weight: normal;
margin: 0px;
padding: 5px;
border: 1px solid #000000;
width: 720px; height: 340px;
color: #000000;
background-color: #DAFFB6;
overflow: auto;"
title="this text can be pasted into the Script Editor">
property destination : "Macintosh HD:Users:Campbell:Documents:Printing"
property someTime : 60 -- time (in seconds) to allow files to copy/download
on run -- application double-clicked or run from the Script Editor
set theFolder to (choose folder)
tell application "Finder" to set theItems to files of theFolder as alias list
adding folder items to theFolder after receiving theItems -- process entire folder contents
end run
on adding folder items to this_folder after receiving added_items -- folder action
if (waitForFilesToCopy into this_folder for someTime) then
doStuff for added_items
else
display alert "Folder Action error" message "File copy/download into folder " & quoted form of POSIX path of this_folder & " did not complete in the time allowed."
end if
end adding folder items to
to doStuff for someFiles
do stuff with each file in someFiles
parameters - someFiles [list]: a list of files to do stuff with
returns nothing
repeat with anItem in someFiles
tell application "Finder"
if the name extension of anItem is "pdf" then
move anItem to folder destination
-- move anItem to (path to desktop) -- testing
end if
end tell
end repeat
end doStuff
to waitForFilesToCopy into someFolder for timeToWait
checks every interval seconds up to timeToWait for files to be copied/downloaded to theFolder
the test is based on the size of the folder not changing after interval seconds
parameters - someFolder [mixed]: the folder to check
timeToWait [integer]: a maximum timeout value in seconds
returns [boolean]: true if copy/download finished, false if timeout
set interval to 2 -- adjust as desired
set someFolder to quoted form of POSIX path of someFolder
set currentSize to first word of (do shell script "du -s " & someFolder) -- get initial size
repeat with timer from timeToWait to 1 by -interval
delay interval
set newSize to first word of (do shell script "du -s " & someFolder) -- recheck size
if (newSize is equal to currentSize) then
return true -- success
else -- update size
set currentSize to newSize
end if
end repeat
return false -- timed out
end waitForFilesToCopy
</pre>