Help requested in spotting error in build.xml

Question

Hi
I am unable to get my ant build.xml to run.
the build.xml file is as follows:
<property name="war.name" value="concepts"></property>
  <property file="../common.properties"></property> 
<!-- Main Target -->
<target name="init">
   <mkdir dir="${build.dir}"></mkdir>
    <mkdir dir="${classes.dir}"></mkdir>
    <mkdir dir="${dist.dir}"></mkdir>
  </target>
  <target name="compile" depends="clover-yes,clover-no"/>
     <javac classpath="${libs}" compiler="${compiler}" debug="on" deprecation="on" destdir="${classes.dir}" optimize="on" srcdir="${src.dir}">
     <src>
        <pathelement location="${src.dir}"></pathelement>
      </src>
      <classpath>
        <fileset dir="${lib.dir}">
          <include name="**/*.jar">
          </include>
        </fileset>
        </classpath>
  <include name="${src.dir}/org/apache/commons/fileupload/**/*.java"></include>
  <include name="${src.dir}/com/portalbook/portlets/**/*.java"></include>
  <include name="${src.dir}/com/portalbook/portlets/content/**/*.java"></include>
  </javac>
  </target>
<!--
  <target depends="init" name="compile">
    <javac debug="true" deprecation="true" destdir="${classes.dir}" optimize="false">
      <src>
        <pathelement location="${src.dir}"></pathelement>
      </src>
      <classpath>
        <fileset dir="${lib.dir}">
          <include name="*.jar">
          </include>
        </fileset>
        </classpath>
    </javac>
  </target>
    -->
  <target depends="compile" name="buildwar">
    <war destfile="${dist.dir}/${war.name}.war" webxml="WEB-INF/web.xml">
         <classes dir="${classes.dir}"></classes>
         <lib dir="${lib.dir}"></lib>
         <webinf dir="${web-inf.dir}"></webinf>
    </war>
  </target>
  <!-- create concepts-lib.jar  -->
  <jar jarfile="${build.lib}/concepts-lib.jar">
    <fileset dir="${classes.dir}"></fileset>
   </jar>
   <!-- create concepts.war -->
   <jar jarfile="${build.lib}/concepts.war" manifest="${build.etc}/concepts-war.mf">
   <fileset dir="${build.resources}/concepts-war"></fileset>
   </jar>
   <!-- concepts.ear -->
   <copy todir="${build.resources}/concepts-ear">
   <fileset dir="${build.lib}" includes="concepts.war,concepts-lib.jar">
   </fileset>
   </copy>
   <copy todir="${build.resources}/concepts-ear/META-INF">
   <fileset dir="${build.resources}/etc" includes="application.xml">
   </fileset>
   </copy>
   <jar jarfile="${build.lib}/concepts.ear">
   <fileset dir="${build.resources}/concepts-ear" includes="concepts.war,concepts-lib.jar">
   </fileset>
   </jar>
    <target depends="buildwar" name="explode">
  <taskdef classname="org.jboss.nukes.common.ant.Explode" classpath="${libs}" name="explode"></taskdef>
  <explode file="${build.lib}/concepts.ear" name="concepts.ear" todir="${build.lib}/exploded"></explode>
  </target>
  <target name="clean">
    <delete dir="${build.dir}">
    </delete>
    <delete dir="${dist.dir}">
    </delete>
  </target>
</project>----------
On this xml file the editor says" end tag without start-tage"..
I am trying all the suggestions which the kind folks here have given me before. But I am still stuck.
TIA

Answer 1

Hi Dr.Clap
I tried incorporating your suggestions. I am learning.
I tried to make the script more readable. I tried putting in /> instead of "fileset/>
But it did not work. The editor complains.
I have the reworked XML file with me. Now the editor does not complain at all, but I can't get my classes to compile at all.
<project basedir="." default="deploy" name="PortalMar28">
  <property name="src.dir" value="src"></property>
    <property name="build.dir" value="${basedir}/build"></property>
  <property name="build.lib" value="${build.dir}/lib"></property>
   <property name="dist.dir" value="dist"></property>
  <property name="classes.dir" value="${build.dir}/classes"></property>
  <property name="build.etc" value="${src.dir}/etc"></property>
  <property name="build.resources" value="${src.dir}/resources"></property>
  <property name="lib.dir" value="lib"></property>
  <property name="web-inf.dir" value="WEB-INF"></property>
  <property name="war.name" value="concepts"></property>
  <property file="../common.properties"></property> 
  <property name="libs.ant" value="${lib.dir}/explode.jar;${lib.dir}/portal-common-lib.jar;${lib.dir}/portal-core-lib.jar"></property>
   <property name="libs" value="${libs.api};${libs.ant}"></property>
<available classname="org.apache.tools.ant.taskdefs.CloverCompilerAdapter" property="clover.available"></available>
<!-- Main Target -->
  <target depends="prepare" if="clover.available" name="clover-yes">
      <property name="compiler" value="org.apache.tools.ant.taskdefs.CloverCompilerAdapter"></property>
   </target>
   <target depends="prepare" name="clover-no" unless="clover.available">
      <property name="compiler" value="modern"></property>
   </target>
     <target name="prepare">
      <mkdir dir="${build.dir}"></mkdir>
    <mkdir dir="${classes.dir}"></mkdir>
    <mkdir dir="${dist.dir}"></mkdir>
  </target>
     <target depends="clover-yes, clover-no" name="deploy">
     <javac classpath="${libs}" compiler="${compiler}" debug="on" deprecation="on" destdir="${classes.dir}" optimize="on" srcdir="${src.dir}">
     <src>
        <pathelement location="${src.dir}"></pathelement>
      </src>
      <classpath>
        <fileset dir="${lib.dir}">
          <include name="**/*.jar">
          </include>
        </fileset>
        </classpath>
  <include name="${src.dir}/org/apache/commons/fileupload/**/*.java"></include>
  <include name="${src.dir}/com/portalbook/portlets/**/*.java"></include>
  <include name="${src.dir}/com/portalbook/portlets/content/**/*.java"></include>
  </javac>
    <war destfile="${dist.dir}/${war.name}.war" webxml="WEB-INF/web.xml">
         <classes dir="${classes.dir}"></classes>
         <lib dir="${lib.dir}"></lib>
         <webinf dir="${web-inf.dir}"></webinf>
    </war>
  <!-- create concepts-lib.jar  -->
  <jar jarfile="${build.lib}/concepts-lib.jar">
    <fileset dir="${classes.dir}"></fileset>
   </jar>
   <!-- create concepts.war -->
   <jar jarfile="${build.lib}/concepts.war" manifest="${build.etc}/concepts-war.mf">
   <fileset dir="${build.resources}/concepts-war"></fileset>
   </jar>
   <!-- concepts.ear -->
   <copy todir="${build.resources}/concepts-ear">
   <fileset dir="${build.lib}" includes="concepts.war,concepts-lib.jar">
   </fileset>
   </copy>
   <copy todir="${build.resources}/concepts-ear/META-INF">
   <fileset dir="${build.resources}/etc" includes="application.xml">
   </fileset>
   </copy>
   <jar jarfile="${build.lib}/concepts.ear">
   <fileset dir="${build.resources}/concepts-ear" includes="concepts.war,concepts-lib.jar">
   </fileset>
   </jar>
</target>
    <target depends="deploy" name="explode">
  <taskdef classname="org.jboss.nukes.common.ant.Explode" classpath="${libs}" name="explode"></taskdef>
  <explode file="${build.lib}/concepts.ear" name="concepts.ear" todir="${build.lib}/exploded"></explode>
  </target>
  <target name="clean">
    <delete dir="${build.dir}">
    </delete>
    <delete dir="${dist.dir}">
    </delete>
  </target>
</project>-------------------------------------
thanks a lot. It is greatly appreciated.