Help with inserting values to sql database

Question

Hello everyone I am having this problem with how to fill my values in my sql statement, if you look below you will notice i have set up the values to be the length of the arr (arrayList).
could someone please let me now how i should put there values in.
thanks for yr time
piper3
  try {
                                                String data = "jdbc:odbc:myProject";
                                                    Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
                                                    Connection con = DriverManager.getConnection(data,"","");
                                             StringBuffer sb = new StringBuffer();
                                             Iterator it1 = arr.iterator();
                                             while (it1.hasNext())
                                                  if (sb.length() > 0)
                                                       sb.append(",");
                                                       sb.append(it1.next());
                                                  //takes the items of the arInterim
                                                  //int iCountInterim = arInterim.size();
                                                  int er = arr.size();
                                                  String sInterim = new String();
                                                  String sql = new String();
                                                  for(int i2 = 0; i2 < er; i2++){
                                                       sInterim = sInterim + sQuestion;
                                                       if(i2 < (er-1)){
                                                            sInterim = sInterim + sComma;
                                                       sql = "INSERT into Ben (" + sb.toString() + ") values (" + sInterim + ")";
                                                       System.out.println(sql);
                                                       PreparedStatement prepStmt = con.prepareStatement(sql);
                                                       /*prepStmt.setString(1, "hello");
                                                       prepStmt.setString(2, "hi");
                                                       prepStmt.setString(3, "bye");
                                                       prepStmt.executeUpdate();
                                                       prepStmt.close();*/
                                                  con.close();               
                                             } catch (Exception e1) {
                                                         System.err.println("Got an exception! ");
                                                         System.err.println(e1.getMessage());
                                                  //System.out.println();//.size());//tempkey+"\n"+tempvalue);

Answer 1

you should write a prepared statement like this:
PreparedStatement updateSales = con.prepareStatement(
"UPDATE COFFEES SET SALES = ? WHERE COF_NAME LIKE ?");
where "?" is a placeholder for the values you want to use.
Then later when you want to actually update your database, first set the placeholders to your values (stored in your array for example) using a statement like this:
updateSales.setString(2, "Colombian");
//sets the 2. placeholder in the statement to the value "Colombian"
after having set all placeholders to a specific value, execute your statement:
updateSales.executeUpdate();
your code should like:
sql = "INSERT into Ben values (?,?,?)";
PreparedStatement prepStmt = con.prepareStatement(sql);
prepStmt.setString(1, "hello");
prepStmt.setString(2, "hi");
prepStmt.setString(3, "bye");
prepStmt.executeUpdate();
prepStmt.close();
HTH
Christine