How can i minimize this trigger code

Question

Hi,
I've written the following trigger ,based on the requirement...
Requirement is following:
After updating the src table(EMPS) corresponding data need to be replicated to dest (REP_EMPS)
While UPDATING ('STATUS') the following conditions to be matched
*(1) updating from any char to 'V then modtp= 'I' AND 'D'*
*(2) updating from 'V r to any char then modtp= 'I' AND 'D'*
*(3) ANY TO ANY THEN modtp='U'*
*(4) while deleting modtp='D'*
So the following trigger is working fine ..
But my doubt is can i even be minimize the code so as to achieve the requirement
CREATE TABLE TEST.EMPS
  EMPNO   NUMBER,
  ENAME   VARCHAR2(11 BYTE),
  STATUS  CHAR(1 BYTE)
CREATE TABLE TEST.REP_EMPS
  ENO    NUMBER,
  ENM    VARCHAR2(11 BYTE),
  STS    CHAR(1 BYTE),
  MODTP  CHAR(1 BYTE)
)Trigger:
CREATE OR REPLACE TRIGGER TEST.EMP_UDAR1
AFTER UPDATE OR DELETE
OF ENAME,STATUS
ON TEST.EMPS  REFERENCING NEW AS NEW OLD AS OLD
FOR EACH ROW
DECLARE
nmodtp char(1):='U';
omodtp char(1):='D';
nempno EMPS.EMPNO%TYPE:=:NEW.EMPNO;
oempno EMPS.EMPNO%TYPE:=:OLD.EMPNO;
nename EMPS.ENAME%TYPE:=:NEW.ENAME;
oename EMPS.ENAME%TYPE:=:OLD.ENAME;
nstatus EMPS.STATUS%TYPE:=:NEW.STATUS;
ostatus EMPS.STATUS%TYPE:=:OLD.STATUS;
docon number:=0;
dodiscon number:=0;
BEGIN
IF (UPDATING('STATUS') AND (:NEW.STATUS='V' OR :OLD.STATUS='V')) THEN
  docon:=1;
  nmodtp:='I';
ELSIF (NOT DELETING) THEN
  docon:=1;
END IF;
IF DELETING or (UPDATING('STATUS') AND (:NEW.STATUS='V' OR :OLD.STATUS='V')) THEN
  dodiscon:=1;
    END IF;
INSERT ALL
WHEN (docon=1) THEN
INTO REP_EMPS(ENO,ENM,STS,modtp)
VALUES(nempno,nename,nstatus,nmodtp)
WHEN (dodiscon=1) THEN
INTO REP_EMPS(ENO,ENM,STS,modtp)
VALUES(oempno,oename,ostatus,omodtp)
SELECT nempno AS nempno,
       oempno AS oempno,
       nename AS nename,
       oename AS oename,
       nstatus AS nstatus,
       ostatus AS ostatus,
       nmodtp AS modtp,
       omodtp AS modtp
FROM DUAL;
END;
/i tried with following in the if condition but not getting the required output
IF (UPDATING('STATUS') AND (:NEW.STATUS='V' OR :OLD.STATUS='V')) THEN
  docon:=1;
  nmodtp:='I';
ELSIF (DELETING) or (UPDATING('STATUS') AND (:NEW.STATUS='V' OR :OLD.STATUS='V')) THEN
  dodiscon:=1;
ELSE
  docon:=1;
END IF;thank you,
josh.....

Answer 1

Hope this helps you
create or replace
TRIGGER EMP_UDAR1
AFTER UPDATE OR DELETE
OF ENAME,STATUS
ON EMPS  REFERENCING NEW AS NEW OLD AS OLD
FOR EACH ROW
DECLARE
-- no need to declaer other variables here.
nmodtp char(1):='U';
omodtp char(1):='D';
docon number:=0;
dodiscon number:=0;
BEGIN
  IF (UPDATING('STATUS') AND (:NEW.STATUS='V' OR :OLD.STATUS='V')) THEN
    docon:=1;
    nmodtp:='I';
  ELSIF (NOT DELETING) THEN
    docon:=1;
  END IF;
  IF DELETING or (UPDATING('STATUS') AND (:NEW.STATUS='V' OR :OLD.STATUS='V'))
  THEN
    dodiscon:=1;
  END IF;
INSERT ALL
    WHEN (docon=1) THEN
      INTO REP_EMPS(ENO,ENM,STS,modtp)
      VALUES(:New.empno,:New.ename,:New.status,:New.modtp) -- Use the :NEW.column values available
    WHEN (dodiscon=1) THEN
      INTO REP_EMPS(ENO,ENM,STS,modtp)
      VALUES(:OLD.empno,:OLD.ename,:OLD.status,:OLD.modtp)-- Use the :OLD.column values available
SELECT *  FROM DUAL; -- You can do this
END;