How to convert the following FORALL Update to direct SQL UPDATE statement

Question

I have a FORALL loop to update a table. It is taking too long. I want to rewrite the code to a direct UPDATE sql. Also, any other tips or hints which can help run this proc faster?
CURSOR cur_bst_tm IS
SELECT listagg(tm, ' ') WITHIN GROUP(ORDER BY con_addr_id) best_time,
       con_addr_id
   FROM   (select Trim(Upper(con_addr_id)) con_addr_id,
                  ||decode(Initcap(start_day),
                                  'Monday', 'm',
                                'Tuesday', 'tu',
                                'Wednesday', 'w',
                                'Thursday', 'th',
                                'Friday', 'f',
                                 Initcap(start_day))
                  ||'='
                  ||trunc(( ( TO_DATE(start_tm,'HH12:MI:SS PM') - trunc(TO_DATE(start_tm,'HH12:MI:SS PM')) ) * 24 * 60 ))
                  ||','
                  ||trunc(( ( TO_DATE(end_tm,'HH12:MI:SS PM') - trunc(TO_DATE(end_tm,'HH12:MI:SS PM')) ) * 24 * 60 )) tm
           FROM   (SELECT DISTINCT * FROM ODS_IDL_EDGE_OFFC_BST_TM)
             WHERE con_addr_id is not null)
  GROUP  BY con_addr_id
  ORDER BY con_addr_id;
TYPE ARRAY IS TABLE OF cur_bst_tm%ROWTYPE;
l_data ARRAY;
BEGIN
OPEN cur_bst_tm;
     LOOP
    FETCH cur_bst_tm BULK COLLECT INTO l_data LIMIT 1000;
    FORALL i IN 1..l_data.COUNT
      UPDATE ODS_CONTACTS_ADDR tgt
      SET best_times = l_data(i).best_time,
      ODW_UPD_BY = 'IDL - MASS MARKET',
       ODW_UPD_DT = SYSDATE,
      ODW_UPD_BATCH_ID = '0'
      WHERE Upper(edge_id) = l_data(i).con_addr_id
       AND EXISTS (SELECT 1 FROM ods_idl_edge_cont_xref src
                   WHERE tgt.contacts_odw_id = src.contacts_odw_id
                      AND src.pc_flg='Y')  
    EXIT WHEN cur_bst_tm%NOTFOUND;
    END LOOP;
  CLOSE cur_bst_tm;Record count:-
select count(*) from
ODS_IDL_EDGE_OFFC_BST_TM;
140,000
SELECT count(*)
FROM ods_idl_edge_cont_xref src
WHERE src.pc_flg='Y';
118,000
SELECT count(*)
FROM ODS_CONTACTS_ADDR;
671,925
Database version 11g.
Execution Plan for the update:
Operation     Object Name     Rows     Bytes     Cost     Object Node     In/Out     PStart     PStop
UPDATE STATEMENT Optimizer Mode=ALL_ROWS          6 K          8120                     
UPDATE     ODW_OWN2.ODS_CONTACTS_ADDR                                   
HASH JOIN SEMI          6 K     256 K     8120                     
TABLE ACCESS FULL     ODW_OWN2.ODS_CONTACTS_ADDR     6 K     203 K     7181                     
TABLE ACCESS FULL     ODW_OWN2.ODS_IDL_EDGE_CONT_XREF     118 K     922 K     938
Edited by: user10566312 on May 14, 2012 1:07 AM

Answer 1

The code tag should be in lower case like this {noformat}{noformat}. Otherwise your code format will be lost.
Here is a update statementupdate ods_contacts_addr tgt
set (
          best_times, odw_upd_by, odw_upd_dt, odw_upd_batch_id
     ) =
          select best_time, odw_upd_by, odw_upd_dt, odw_upd_batch_id
          from (
               select listagg(tm, ' ') within group(order by con_addr_id) best_time,
                    'IDL - MASS MARKET' odw_upd_by,
                    sysdate odw_upd_dt,
                    '0' odw_upd_batch_id,
                    con_addr_id
               from (
                         select Trim(Upper(con_addr_id)) con_addr_id,
                              ||decode(Initcap(start_day), 'Monday', 'm', 'Tuesday', 'tu', 'Wednesday', 'w', 'Thursday', 'th', 'Friday', 'f', Initcap(start_day))
                              ||'='
                              ||trunc(((TO_DATE(start_tm,'HH12:MI:SS PM')-trunc(TO_DATE(start_tm,'HH12:MI:SS PM')))*24*60 ))
                              ||','
                              ||trunc(((TO_DATE(end_tm,'HH12:MI:SS PM')-trunc(TO_DATE(end_tm,'HH12:MI:SS PM')))*24*60)) tm
                         FROM (
                              select distinct * from ods_idl_edge_offc_bst_tm
                         WHERE con_addr_id is not null
               group
               by con_addr_id
          where upper(tgt.edge_id) = con_addr_id
where exists
          SELECT 1
          FROM ods_idl_edge_cont_xref src
          WHERE tgt.contacts_odw_id = src.contacts_odw_id
          AND src.pc_flg='Y'
and exists
          select null
          from (
               SELECT listagg(tm, ' ') WITHIN GROUP(ORDER BY con_addr_id) best_time,
                    'IDL - MASS MARKET' odw_upd_by,
                    SYSDATE odw_upd_dt,
                    '0' odw_upd_batch_id,
                    con_addr_id
               FROM (
                         select Trim(Upper(con_addr_id)) con_addr_id,
                              ||decode(Initcap(start_day), 'Monday', 'm', 'Tuesday', 'tu', 'Wednesday', 'w', 'Thursday', 'th', 'Friday', 'f', Initcap(start_day))
                              ||'='
                              ||trunc(((TO_DATE(start_tm,'HH12:MI:SS PM')-trunc(TO_DATE(start_tm,'HH12:MI:SS PM')))*24*60 ))
                              ||','
                              ||trunc(((TO_DATE(end_tm,'HH12:MI:SS PM')-trunc(TO_DATE(end_tm,'HH12:MI:SS PM')))*24*60)) tm
                         FROM (
                              SELECT DISTINCT * FROM ODS_IDL_EDGE_OFFC_BST_TM
                         WHERE con_addr_id is not null
               GROUP
               BY con_addr_id
          where upper(tgt.edge_id) = con_addr_id
This is an untested code. If there is any syntax error then please fix it and try.