How to do proper group by when joining two tables ?

Question

Hi all,
Using the below join query, I would like to get output based on number of "Classes" ( For eg: If I want result for 15 classes then , it should return 16 rows from 0 to 16).
I n below query , I use group by as
"GROUP BY report_parameters.report_parameter_value  ".
Error says "its not group by expression".
If I commented out group by , then it reurns 320 rows instead of 16 rows.
Could anyone help me?
SELECT 'SUM('
    || 'CASE '
    || 'WHEN edr_class_by_gvw_report_data.bin_id >= ' || report_range_parameters.report_parameter_min_value || '
         AND edr_class_by_gvw_report_data.bin_id  < ' || report_range_parameters.report_parameter_max_value || '
        THEN edr_class_by_gvw_report_data.bin_value '   
    || 'ELSE 0 '
    || 'END '
    || ') "Class ' || report_parameters.report_parameter_value || '" '   
      FROM report_parameters
      JOIN report_range_parameters
        ON report_parameters.report_parameter_id = report_range_parameters.report_parameter_id
     WHERE report_range_parameters.report_parameter_id    = 2316   
       AND report_range_parameters.report_parameter_group = 'GVW_GROUP'
       AND report_range_parameters.report_parameter_name  = 'GVW_NAME'
       AND report_parameters.report_parameter_group = 'CLASS'
       AND report_parameters.report_parameter_name  = 'CLASS'
     GROUP BY
      report_parameters.report_parameter_value 
     ORDER BY  report_range_parameters.report_parameter_min_value ASC;Thanks .
Edited by: user10641405 on Jun 11, 2009 12:23 PM
Edited by: user10641405 on Jun 11, 2009 12:30 PM

Answer 1

Hi Frank,
Thank you so much for your reply.
Yes it is the same query.
Okay, here I will explain what i actually want.
Below is my final output(No doubt)
veh weight    class 0    class 1   class 2
0->5               0          5        10
5-> 10             0          22       32
10->15             0          12       67
In final dynamic sql(which have to generate the above final output), we use 2 functions(called my_class_select_text and my_class_sum_text) to genearte two types of sql strings as below:so the output that I asked is regards this functions' output not the final output.
"The below  output( is the one I asked previously) is from the my_class_select_text function"
SUM(CASE WHEN edr_class_by_gvw_report_data.gvw >= 0 AND edr_class_by_gvw_report_data.gvw  < 5 THEN edr_class_by_gvw_report_data.gvw_count ELSE 0 END ) "Class 0"
SUM(CASE WHEN edr_class_by_gvw_report_data.gvw >= 5 AND edr_class_by_gvw_report_data.gvw  < 10 THEN edr_class_by_gvw_report_data.gvw_count ELSE 0 END ) "Class 1"
SUM(CASE WHEN edr_class_by_gvw_report_data.gvw >= 10 AND edr_class_by_gvw_report_data.gvw  < 15 THEN edr_class_by_gvw_report_data.gvw_count ELSE 0 END ) "Class 2"
SUM(CASE WHEN edr_class_by_gvw_report_data.gvw >= 15 AND edr_class_by_gvw_report_data.gvw  < 20 THEN edr_class_by_gvw_report_data.gvw_count ELSE 0 END ) "Class 3"
SUM(CASE WHEN edr_class_by_gvw_report_data.gvw >= 20 AND edr_class_by_gvw_report_data.gvw  < 25 THEN edr_class_by_gvw_report_data.gvw_count ELSE 0 END ) "Class 4"
"The below output is from the function my_class_sum_text"
SUM("0->5") "0->5" 
SUM("5->10") "5->10"
SUM("10->15") "10->15"
SUM("15->20") "15->20"
"here i have pasted those functions.so you could have some better idea"
FUNCTION edr_rpt_get_class_select_text
     in_report_parameter_id   IN      NUMBER
RETURN VARCHAR2
IS
   my_class_select_text  VARCHAR2(32676);
   my_class_select_value VARCHAR2(32676);
   CURSOR class_select_text IS      
      SELECT 'SUM('
    || 'CASE '
    || 'WHEN edr_class_by_gvw_report_data.gvw >='|| report_range_parameters.report_parameter_min_value ||'
         AND edr_class_by_gvw_report_data.gvw  <'|| report_range_parameters.report_parameter_max_value ||'
        THEN edr_class_by_gvw_report_data.gvw_count '   
    || 'ELSE 0 '
    || 'END '
    || ') "Class ' || report_parameters.report_parameter_value || '" '   
      FROM report_parameters
      JOIN report_range_parameters
        ON report_parameters.report_parameter_id = report_range_parameters.report_parameter_id
     WHERE report_parameters.report_parameter_id    = in_report_parameter_id
       AND report_parameters.report_parameter_group = 'CLASS'
       AND report_parameters.report_parameter_name  = 'CLASS'
       AND report_range_parameters.report_parameter_group = 'GVW_GROUP'
       AND report_range_parameters.report_parameter_name  = 'GVW_NAME'
     ORDER BY CAST(report_parameters.report_parameter_value AS NUMBER) ASC;
BEGIN
  my_class_select_text := '';
  OPEN class_select_text;
  LOOP
    FETCH class_select_text INTO my_class_select_value;
    EXIT WHEN class_select_text%NOTFOUND;
    my_class_select_text := my_class_select_text || ', ' || my_class_select_value;
  END LOOP;
  CLOSE class_select_text;
  RETURN my_class_select_text;
END edr_rpt_get_class_select_text;
FUNCTION edr_rpt_get_class_sum_text
     in_report_parameter_id   IN   NUMBER
RETURN VARCHAR2
IS
  my_class_sum_text     VARCHAR2(32676);
  my_class_sum_value    VARCHAR2(32676);
CURSOR class_sum_text IS
      SELECT  'SUM("' || report_range_parameters.report_parameter_min_value || '->' || report_range_parameters.report_parameter_max_value || '")
          "Class ' || report_parameters.report_parameter_value || '"  '        
       FROM report_range_parameters
      JOIN report_parameters
        ON report_range_parameters.report_parameter_id = report_parameters.report_parameter_id
     WHERE report_range_parameters.report_parameter_id    = in_report_parameter_id   
       AND report_range_parameters.report_parameter_group = 'GVW_GROUP'
       AND report_range_parameters.report_parameter_name  = 'GVW_NAME'
       AND report_parameters.report_parameter_group = 'CLASS'
       AND report_parameters.report_parameter_name  = 'CLASS'
     ORDER BY report_range_parameters.report_parameter_min_value ASC;
BEGIN
  my_class_sum_text := '';
  OPEN class_sum_text;
  LOOP
    FETCH class_sum_text INTO my_class_sum_value;
    EXIT WHEN class_sum_text%NOTFOUND;
    my_class_sum_text := my_class_sum_text || ', ' || my_class_sum_value;
  END LOOP;
  CLOSE class_sum_text;
  RETURN my_class_sum_text;
END edr_rpt_get_class_sum_text;Here I'm using one more table called edr_class_by_gvw_report_data.
gvw                         |  gvw_count
(veh weight in kips)     (count of veh )
5                                       3
12                                    10
13                                    5
sample insert statement
INSERT INTO EDR_CLASS_BY_REPORT_DATA(GVE,GVW_COUNT) VALUES(5,3)
INSERT INTO EDR_CLASS_BY_REPORT_DATA(GVE,GVW_COUNT) VALUES(12,10)
INSERT INTO EDR_CLASS_BY_REPORT_DATA(GVE,GVW_COUNT) VALUES(13,5)Below i have pasted portion of my dynamic sql (this is sample from "class by hour report" . It includes "Hour"(That I highlighted in red.It will generate output as
0-1
1-2
2-3
etc )
In this place, I need to replace by weight ranges as "Kips" because now the report that I'm working is called "class by gross veh weight".
    || '         SELECT 1 "Rank", '
    || '                ''Data Row'' "Row Type", '
    || '                TRUNC(edr_rpt_tmp_bin_periods.bin_start_date_time ) "Date", '
    || '                edr_rpt_tmp_bin_periods.bin_start_date_time "Date/Time", '
    || '                '''' "Lane", '
  "  || '                TO_CHAR(edr_rpt_tmp_bin_periods.bin_start_date_time, ''hh24'') '"
  "  || '                || '' - '' || ' "
  "  || '                DECODE(TO_CHAR(edr_rpt_tmp_bin_periods.bin_end_date_time, ''hh24''), ''00'', ''24'', TO_CHAR(edr_rpt_tmp_bin_periods.bin_end_date_time, ''hh24'')) "Hour" ' "
    ||                  my_class_sum_text || ', '  "<------------- function generates sql string"
    || '                SUM(NVL(" ", 0)) "Total" '
    || '           FROM ( '
    || '                  SELECT edr_class_by_gvw_report_data.bin_start_date_time start_date_time '
    ||                           my_class_select_text || ', ' "<------------------function generates sql string"
    || '                         SUM(NVL(edr_class_by_gvw_report_data.gvw_count, 0)) " " '
    || '                    FROM edr_class_by_gvw_report_data '
    || '                   GROUP BY edr_class_by_gvw_report_data.bin_start_date_time '
    || '                ) results '
    || '          RIGHT OUTER JOIN edr_rpt_tmp_bin_periods '
    || '             ON results.start_date_time >= edr_rpt_tmp_bin_periods.bin_start_date_time '
    || '            AND results.start_date_time <  edr_rpt_tmp_bin_periods.bin_end_date_time '
    || '          GROUP BY edr_rpt_tmp_bin_periods.bin_start_date_time, '
    || '                edr_rpt_tmp_bin_periods.bin_end_date_time '
    || '          ORDER BY "Date/Time" ASC, '
    || '                "Rank" ASC 'I'm really thankful for your kindness and pain of reading all my blablablaaasss.
Hope you could have some better understnading by this reply.
I'm willing to answer all your questions.
Regards,
Indhu.
Edited by: user10641405 on Jun 15, 2009 4:55 PM
Edited by: user10641405 on Jun 15, 2009 4:59 PM
Edited by: user10641405 on Jun 15, 2009 5:01 PM
Edited by: user10641405 on Jun 15, 2009 5:02 PM
Edited by: user10641405 on Jun 16, 2009 8:29 AM
Edited by: user10641405 on Jun 16, 2009 8:50 AM
Edited by: user10641405 on Jun 16, 2009 11:55 AM