How to execute these insert statements as a batch?

Question

Hello,
I have these three insert sql statements which execute individually. I want to execute them as a batch:
sql = "Insert into FirstTable (MessageId, MsgDate, MsgTitle) values (?, ?, ?)";
insertStatement = connection.prepareStatement(sql);
insertStatement.setInt(1, jmsgid);
insertStatement.setString(2, jlogdate);
insertStatement.setString(3, jmsgtitle);
insertStatement.executeUpdate();
sql = "Insert into SecondTable (MessageId, MsgDate, MsgTitle) values (?, ?, ?)";
insertStatement = connection.prepareStatement(sql);
insertStatement.setInt(1, jmsgid);
insertStatement.setString(2, jlogdate);
insertStatement.setString(3, jmsgtitle);
insertStatement.executeUpdate();
sql = "Insert into ThirdTable (MessageId, MsgDate, MsgTitle) values (?, ?, ?)";
insertStatement = connection.prepareStatement(sql);
insertStatement.setInt(1, jmsgid);
insertStatement.setString(2, jlogdate);
insertStatement.setString(3, jmsgtitle);
insertStatement.executeUpdate();
I tried the following method, but something is wrong. Can somebody help with executing these inserts as a batch?
stmt = connection.createStatement(); // connection pool
sql = "Insert into FirstTable (MessageId, MsgDate, MsgTitle) values (?, ?, ?)";
insertStatement.setInt(1, jmsgid);
insertStatement.setString(2, jlogdate);
insertStatement.setString(3, jmsgtitle);
stmt.addBatch(sql);
sql = "Insert into SecondTable (MessageId, MsgDate, MsgTitle) values (?, ?, ?)";
insertStatement.setInt(1, jmsgid);
insertStatement.setString(2, jlogdate);
insertStatement.setString(3, jmsgtitle);
stmt.addBatch(sql);
sql = "Insert into ThirdTable (MessageId, MsgDate, MsgTitle) values (?, ?, ?)";
insertStatement.setInt(1, jmsgid);
insertStatement.setString(2, jlogdate);
insertStatement.setString(3, jmsgtitle);
stmt.addBatch(sql);
stmt.executeBatch();
Thank you,
Logan

Answer 1

Errr I can't for the life of me understand why you thought that would work. I am bit concerned about how you assembled this code... did you copy and paste and hope for the best?
It should be.....
1) Get a preparedStatement using your sql. Do this step once.
2) For each query you want to batch.... set each of the parameters and call addBatch. Call all this on the prepared statement.
3) Then call executeBatch on the prepared statement.
You do not need the other vanilla statement for anything.
One important thing to note. When you batch parameters for batch prepared statement execution you can only (hopefully obviously) batch for the same SQL query. You can't do one insert and another update in the same query. It has to be all the same query.. just different parameters. This won't effect what you are doing in the above but sometimes it confuses people and they get into trouble later so I thought I would mention it now.