How to make 3 similar fun's does generate different sql string in 1 db call

Question

Hi All,
In my sql package I'm using 3 different functions to create two different sql strings and the 3rd function does some percentage calculations. My Db architect on code review suggest me that those two functions are almost the same except the sql string it does generate. So she asked me to write one function that does everything in one db call.
"_Function 1_"
FUNCTION get_class_select_text
     in_report_parameter_id IN NUMBER
RETURN VARCHAR2
IS
my_class_select_text VARCHAR2(10000);
my_class_select_value VARCHAR2(10000);
CURSOR class_select_text IS
     SELECT 'SUM(DECODE(bin_id, ' || report_parameters.report_parameter_value
                    || ', bin_value, 0)) "Class ' || report_parameters.report_parameter_value || '" '
FROM report_parameters
WHERE report_parameters.report_parameter_id = in_report_parameter_id
AND report_parameters.report_parameter_group = 'CLASS'
AND report_parameters.report_parameter_name = 'CLASS'
GROUP BY
report_parameters.report_parameter_value
ORDER BY
CAST(report_parameters.report_parameter_value AS NUMBER);
BEGIN
my_class_select_text := '';
OPEN class_select_text;
LOOP
FETCH class_select_text INTO my_class_select_value;
EXIT WHEN class_select_text%NOTFOUND;
my_class_select_text := my_class_select_text || ', ' || my_class_select_value;
END LOOP;
CLOSE class_select_text;
RETURN my_class_select_text;
END get_class_select_text;
FUNCTION 2:
FUNCTION get_class_sum_text
     in_report_parameter_id IN NUMBER
RETURN VARCHAR2
IS
my_class_sum_text VARCHAR2(10000);
my_class_sum_value VARCHAR2(10000);
CURSOR class_sum_text IS
     SELECT 'SUM(NVL("Class ' || report_parameters.report_parameter_value || '", 0)) "Class ' || report_parameters.report_parameter_value || '" '
FROM report_parameters
WHERE report_parameters.report_parameter_id = in_report_parameter_id
AND report_parameters.report_parameter_group = 'CLASS'
AND report_parameters.report_parameter_name = 'CLASS'
GROUP BY
report_parameters.report_parameter_value
ORDER BY
CAST(report_parameters.report_parameter_value AS NUMBER);
BEGIN
my_class_sum_text := '';
OPEN class_sum_text;
LOOP
FETCH class_sum_text INTO my_class_sum_value;
EXIT WHEN class_sum_text%NOTFOUND;
my_class_sum_text := my_class_sum_text || ', ' || my_class_sum_value;
END LOOP;
CLOSE class_sum_text;
RETURN my_class_sum_text;
END get_class_sum_text;
FUNCTION 3:
FUNCTION get_class_perc_text
     in_report_parameter_id IN NUMBER
RETURN VARCHAR2
IS
my_class_perc_text VARCHAR2(10000);
my_class_perc_value VARCHAR2(10000);
CURSOR class_perc_text IS
SELECT 'ROUND((("Class ' || report_parameters.report_parameter_value || '" / "Total") * 100), 2) "Class ' || report_parameters.report_parameter_value || '" '
FROM report_parameters
WHERE report_parameters.report_parameter_id = in_report_parameter_id
AND report_parameters.report_parameter_group = 'CLASS'
AND report_parameters.report_parameter_name = 'CLASS'
GROUP BY
report_parameters.report_parameter_value
ORDER BY
CAST(report_parameters.report_parameter_value AS NUMBER);
BEGIN
my_class_perc_text := '';
OPEN class_perc_text;
LOOP
FETCH class_perc_text INTO my_class_perc_value;
EXIT WHEN class_perc_text%NOTFOUND;
my_class_perc_text := my_class_perc_text || ', ' || my_class_perc_value;
END LOOP;
CLOSE class_perc_text;
my_class_perc_text := my_class_perc_text || ', ' || 'DECODE("Total", -1, 0, 100) "Total" ';
RETURN my_class_perc_text;
END get_class_perc_text;
Could anyone help me?
Thanks in advance.

Answer 1

Hi ,
Thanks a lot for your reply and tips how to post the code.
As you know that previously I used 3 different variables called
my_class_select_text,
my_class_sum_text,
my_class_perc_text
to get corresponding values. I'm using these values in a dynamic SQL like below in the code.
      SELECT 3 "Rank", '
    || '            ''Final Row'' "Row Type", '
    || '            TRUNC(edr_rpt_tmp_bin_periods.bin_start_date_time ) "Date", '
    || '            MAX(edr_rpt_tmp_bin_periods.bin_end_date_time) - numtodsinterval(0.000000001, ''SECOND'') "Date/Time", '
    || '            '''' "Lane", '
    || '            ''Total'' "Hour"  '
    ||              my_class_sum_text
    || '                           , '
    || '             SUM(NVL(" ", 0)) " " '
    || '           FROM ( '
    || '                  SELECT edr_class_by_hour_report_data.bin_start_date_time start_date_time '
    ||                               my_class_select_text || ', '
    || '                             SUM(NVL(edr_class_by_hour_report_data.bin_value, 0)) " " '
    || '                    FROM edr_class_by_hour_report_data '
    || '             GROUP BY edr_class_by_hour_report_data.bin_start_date_time '
    || '                ) results '
   As per your new function it returns in a single parameter called 'my_class_perc_text' . Now I dont know how to use single variable in these places?
Hope you could understand my question.
I used to display code. :)
   Thanks once again.
Edited by: user10641405 on May 21, 2009 2:06 PM