How to use bulk in multiple cursors !!

Question

Hello All,
I am having a following program that perfectly runs but its taking very huge time to complete it.
Can any one suggest how i can improve the performace of this code ..
thanks in advance - appreciate your help .
Here's the program.
==============
procedure Proc_Fmly_VehicleTA_Cnt is
CURSOR c_cur_fmly IS SELECT FAMID, NUM_AUTO, NUM_TVAN, VEHQ, VEHQL FROM FMLY;
CURSOR c_cur_eovb_auto IS SELECT FAMID, VEHICIB ,VEHICYB FROM EOVB WHERE VEHICYB = gv_eovb_vehicyb_automobiles ;
CURSOR c_cur_eovb_trucks IS SELECT FAMID, VEHICIB ,VEHICYB FROM EOVB WHERE VEHICYB = gv_eovb_vehicyb_trucks ;
v_total_automobiles number := 0 ;
v_total_trucks number := 0 ;
v_procedure errorlog.procedure_name%TYPE default 'Proc_Fmly_VehicleTA_Cnt';
v_location errorlog.location%TYPE;
BEGIN
v_location := 4 ;
-- global variables gv_eovb_vehicyb_automobiles = 100 gv_eovb_vehicyb_trucks = 110
-- <<Computing the owned vehicles - automobiles >>
-- INNER BLOCK
BEGIN
FOR i IN c_cur_fmly LOOP
FOR j IN c_cur_eovb_auto LOOP
IF ( i.FAMID = j.FAMID ) THEN
v_total_automobiles := v_total_automobiles + chk_notnull_blank( j.vehicib);
END IF;
END LOOP ;
UPDATE FMLY SET NUM_AUTO = v_total_automobiles WHERE famid = i.famid ;
v_total_automobiles := 0;
END LOOP;
EXCEPTION
WHEN OTHERS THEN
raise_application_error(-20001,'An error was encountered - '||SQLCODE||' -ERROR- '||SQLERRM);
v_err_code := SQLCODE;
v_err_msg := substr(SQLERRM, 1, 200);
INSERT INTO audit_table (error_number, error_message) VALUES (v_err_code, v_err_msg);
error_logging(p_error_code => substr(sqlerrm,1,9), p_error_message => substr(sqlerrm,12), p_package => 'PKG_FCI_APP',p_procedure => 'Proc_Fmly_VehicleTA_Cnt' , p_location => v_location);
END;
-- <<Computing the owned vehicles - trucks >>
-- INNER BLOCK
BEGIN
FOR i IN c_cur_fmly LOOP
FOR j IN c_cur_eovb_trucks LOOP
IF ( i.FAMID = j.FAMID ) THEN
v_total_trucks := v_total_trucks + chk_notnull_blank( j.vehicib);
END IF;
END LOOP ;
UPDATE FMLY SET NUM_TVAN = v_total_trucks WHERE famid = i.famid ;
v_total_trucks := 0;
END LOOP;
EXCEPTION
WHEN OTHERS THEN
raise_application_error(-20001,'An error was encountered - '||SQLCODE||' -ERROR- '||SQLERRM);
v_err_code := SQLCODE;
v_err_msg := substr(SQLERRM, 1, 200);
INSERT INTO audit_table (error_number, error_message) VALUES (v_err_code, v_err_msg);
error_logging(p_error_code => substr(sqlerrm,1,9), p_error_message => substr(sqlerrm,12), p_package => 'PKG_FCI_APP',p_procedure => 'Proc_Fmly_Vehicle_Cnt' , p_location => v_location);
END;
-- END OUTER BLOCK
EXCEPTION
WHEN OTHERS THEN
raise_application_error(-20001,'An error was encountered - '||SQLCODE||' -ERROR- '||SQLERRM);
v_err_code := SQLCODE;
v_err_msg := substr(SQLERRM, 1, 200);
INSERT INTO audit_table (error_number, error_message) VALUES (v_err_code, v_err_msg);
error_logging(p_error_code => substr(sqlerrm,1,9), p_error_message => substr(sqlerrm,12), p_package => 'PKG_FCI_APP',p_procedure => 'Proc_Fmly_VehicleTA_Cnt ', p_location => v_location);
END Proc_Fmly_VehicleTA_Cnt;
-- ignore error_logging procedure ; its a part of package.
thanks/kumar
Edited by: kumar73 on Sep 17, 2010 9:36 AM
Edited by: kumar73 on Sep 17, 2010 9:37 AM

Answer 1

btw your exception handler has a couple of problems (I've formatted it for you):
EXCEPTION
   WHEN OTHERS THEN
      RAISE_APPLICATION_ERROR
      ( -20001, 'An error was encountered - '||SQLCODE||' -ERROR- '||SQLERRM );
      v_err_code := SQLCODE;
      v_err_msg  := SUBSTR(SQLERRM, 1, 200);
      INSERT INTO audit_table (error_number, error_message) VALUES (v_err_code, v_err_msg);
      error_logging
      ( p_error_code => substr(sqlerrm,1,9)
      , p_error_message => substr(sqlerrm,12)
      , p_package => 'PKG_FCI_APP'
      , p_procedure => 'Proc_Fmly_VehicleTA_Cnt'
      , p_location => v_location ); When RAISE_APPLICATION_ERROR raises the exception, the procedure will terminate and the error logging steps below it won't get called.
Also if you just want to re-raise an exception without adding any information or your own message etc, then you should use RAISE, not RAISE_APPLICATION_ERROR. If you're going to use RAISE_APPLICATION_ERROR it should be something like:
RAISE_APPLICATION_ERROR
( -20001
, 'Could not set automobile count to ' || v_total_automobiles || ' for family ' || i.famid
, TRUE );Notice the last parameter, TRUE, which tells it to keep the existing error stack (i.e. whatever Oracle error made it fail), which will then appear underneath your custom error message. You should never concatenate SQLERRM into a RAISE_APPLICATION_ERROR message. (And SQLCODE is just the error number that is already part of SQLERRM so there is no point including that anyway.)
Those changes give you something like:
EXCEPTION
   WHEN OTHERS THEN
      INSERT INTO audit_table (error_number, error_message)
      VALUES (SQLCODE, SUBSTR(SQLERRM,1,200));  -- btw why SUBSTR? Why not log the entire message?
      error_logging
      ( p_error_code => substr(sqlerrm,1,9)
      , p_error_message => substr(sqlerrm,12)
      , p_package => 'PKG_FCI_APP'
      , p_procedure => 'Proc_Fmly_VehicleTA_Cnt'
      , p_location => v_location );
      RAISE_APPLICATION_ERROR
      ( -20001
      , 'Could not set automobile count to ' || v_total_automobiles || ' for family ' || i.famid
      , TRUE );