Huge insert and passing insert statement in between in oracle

Question

I need to generate test data , i am making use of level with dual table and want to pass commit let say after 5 records are inserted.. but the problem is that last loop iteration result incorrect inserts.. one can plz help me..
create or replace procedure sp_test_Data_insert (i_no_records number)
as
l_cnt pls_integer:=1;
l_tot pls_integer:=0;
begin
while l_cnt<=i_no_records
loop
insert into test_data
select test_data_seq.nextval
from (select level from dual connect by level <= l_cnt);
dbms_output.put_line (' no.of records in loop : '|| sql%rowcount);
l_tot:=l_tot+sql%rowcount;
l_cnt:=l_cnt+5;
commit;
end loop;
dbms_output.put_line ('Total records : '|| l_tot);
end;
SQL> execute sp_test_Data_insert(10);
no.of records in loop : 1
no.of records in loop : 6
Total records : 7
PL/SQL procedure successfully completed.
issue - since third loop cnt=11, hence incorrect insert... can someone help with this...

Answer 1

knowledgespring wrote:
what if the total number of records is 1m, 10m, would you suggest make db go down or fail with lack of undo!??Clearly you do not know Oracle databases.
10 million records is nothing to an oracle database.
i want to pass commit in between and complete the no.of records count passed to the SP,it may be 1m, 100000,100001, 100005 , 100055, 100099...etc..
what if this is the case!!??
5 is just an example... and it can be 10000, 50000.. plan is to commit after every 25000 records...Committing every X number of records can cause oracle to spawn multiple write processess on the server, and more writer processes = more server resources = slower server.
It's also transactionally inconsistent and can leave you with major headaches if a problem occurs part way through your overall business logical transaction, as you can't rollback etc.
lack of undo is no excuse for committing out of place. resize your undo or scale your hardware according to the needs of the business, but don't write poor code that will break the database even more to try and fudge your way out of it.