I am not able to fill up my output table

Question

I'm fresher to ABAP.
I am  not able to fill up my output internal table. please help in correcting my select statements.
Please help me.
I am pasting my code here.
DATA: BEGIN OF marc_tab OCCURS 0,
       matnr LIKE marc-matnr,    " Material Number
       eislo LIKE marc-eislo,    " Minimum Safety Stock
       mabst LIKE marc-mabst,    " Maximum stock level
       eisbe LIKE marc-eisbe,    " Safety stock
       werks LIKE marc-werks,    " Plant
       ekgrp LIKE marc-ekgrp,    " Purchasing group
       dispo LIKE marc-dispo,    " MRP controller
END OF marc_tab.
DATA: BEGIN OF mard_tab OCCURS 0,
       lgort LIKE mard-lgort,     " Storage Location
       speme LIKE mard-speme,    " Blocked stock
       umlme LIKE mard-umlme,    " Stock in transfer
       insme LIKE mard-insme,    " Stock in quality inspection
       retme LIKE mard-retme,    " Blocked Stock Returns
       labst LIKE mard-labst,    " Valuated stock with unrestricted use
      END OF mard_tab.
DATA: mard_tab1 LIKE STANDARD TABLE OF mard_tab WITH HEADER
LINE.
Material and description
DATA: BEGIN OF mara_makt_tab OCCURS 0,
      matnr LIKE mara-matnr,   "Material number
      maktx LIKE makt-maktx,   "Material description
      END OF mara_makt_tab.
DATA: BEGIN OF eord_lfa1_tab OCCURS 0,
      matnr LIKE eord-matnr,  "Material number
      ebeln LIKE eord-ebeln,  "Scheduling Agreement
      lifnr LIKE eord-lifnr,  "Vendor's account number
      name1 LIKE lfa1-name1,                                "Name 1
      END OF eord_lfa1_tab.
DATA: BEGIN OF mseg_mkpf_tab OCCURS 0,
      budat LIKE mkpf-budat,    "Posting date in the document
      mblnr LIKE mkpf-mblnr,    "Number of material document
      werks LIKE mseg-werks,
      mjahr LIKE mseg-mjahr,     "Material doc. year
      menge LIKE mseg-menge,     "Quantity
      lgort LIKE mseg-lgort,     "Storage location
      bwart1 LIKE mseg-bwart,     " Movement type (inventory management)
      bwart2 LIKE mseg-bwart,    
      lifnr LIKE mseg-lifnr,
      END OF mseg_mkpf_tab.
DATA: mseg_mkpf_tab1 LIKE STANDARD TABLE OF mseg_mkpf_tab WITH HEADER
LINE.
DATA: BEGIN OF mkol_tab OCCURS 0,
      seinm LIKE mkol-seinm,      " Restricted-use consignment stock
      slabs LIKE mkol-slabs,     " Unrestricted-use consignment stock
      sobkz  LIKE mkol-sobkz,     " Special stock indicator         
      END OF mkol_tab.
DATA: BEGIN OF t_werks OCCURS 0,
      werks LIKE t001w-werks,    " plant
      END OF  t_werks.
**DATA: BEGIN OF mkpf_tab OCCURS 0,
     budat LIKE mkpf-budat,    "Posting date in the document
     mblnr LIKE mkpf-mblnr,    "Number of material document
     END OF  mkpf_tab.
DATA: BEGIN OF zresult_tab OCCURS 0,
       matnr LIKE marc-matnr,    " Material Number
       maktx LIKE makt-maktx,   "Material description
       rev_lvl TYPE c,           " Revision level
       ebeln LIKE eord-ebeln,  "Scheduling Agreement
       ekgrp LIKE marc-ekgrp,    " Purchasing group
       dispo LIKE marc-dispo,    " MRP controller
       lifnr LIKE eord-lifnr,  "Vendor's account number
       name1 LIKE lfa1-name1,                               "Name 1
       eislo LIKE marc-eislo,    " Minimum Safety Stock
       mabst LIKE marc-mabst,    " Maximum stock level
       eisbe LIKE marc-eisbe,    " Safety stock
       werks LIKE marc-werks,    " Plant
       bwart LIKE mseg-bwart,     " Movement type (inventory management)
       slabs LIKE mkol-slabs,    " Unrestricted-use consignment stock
       labst LIKE mard-labst,    " Valuated stock with unrestricted use
       speme LIKE mard-speme,    " Blocked stock
       umlme LIKE mard-umlme,    " Stock in transfer
       insme LIKE mard-insme,    " Stock in quality inspection
      retme LIKE mard-retme,    " Blocked Stock Returns /added
     seinm LIKE mkol-seinm,    " Restricted-use consignment stock
     sobkz LIKE mkol-sobkz,   " Special stock indicator         
     lgort LIKE mseg-lgort,     "Storage location
       END OF zresult_tab.
*DATA: zresult_tab1 LIKE STANDARD TABLE OF zresult_tab WITH HEADER LINE.
DATA: BEGIN OF zresult_tab1 OCCURS 0,
       matnr LIKE marc-matnr,    " Material Number
       maktx LIKE makt-maktx,   "Material description
       ebeln LIKE eord-ebeln,  "Scheduling Agreement
       ekgrp LIKE marc-ekgrp,    " Purchasing group
       dispo LIKE marc-dispo,    " MRP controller
       lifnr LIKE eord-lifnr,  "Vendor's account number
       name1 LIKE lfa1-name1,                               "Name 1
       eislo LIKE marc-eislo,    " Minimum Safety Stock
       mabst LIKE marc-mabst,    " Maximum stock level
       eisbe LIKE marc-eisbe,    " Safety stock
       werks LIKE marc-werks,    " Plant
       bwart LIKE mseg-bwart,     " Movement type (inventory management)
       menge LIKE mseg-menge,   
       slabs LIKE mkol-slabs,    " Unrestricted-use consignment stock
       labst LIKE mard-labst,    " Valuated stock with unrestricted use
       speme LIKE mard-speme,    " Blocked stock
       umlme LIKE mard-umlme,    " Stock in transfer
       insme LIKE mard-insme,    " Stock in quality inspection
       lgort LIKE mard-lgort,    
      retme LIKE mard-retme,    " Blocked Stock Returns
       END OF zresult_tab1.
*DATA : begin of zresult_tab1 occurs 0,
*include zresult_tab LIKE zresult_tab.
*end of itab.
and the select statements are like this:
  SELECT matnr
            FROM mara
                INTO  TABLE zresult_tab
                WHERE matnr IN s_matnr.
               and werks in s_werks.
  SELECT mkpfbudat mkpfmblnr
         msegmblnr msegmjahr mseg~menge
         mseglgort msegbwart
        FROM mseg INNER JOIN mkpf
          ON  mkpfmblnr = msegmblnr
            AND  mkpfmjahr = msegmjahr
           INTO CORRESPONDING FIELDS OF
            TABLE mseg_mkpf_tab
            WHERE
            mseg~werks IN s_werks
            AND lgort IN s_lgort1
            AND lgort IN s_lgort2
            AND bwart IN s_bwart1
            AND bwart IN s_bwart2.
          AND budat IN s_usgpid.
  IF sy-subrc EQ 0.
special stocks from vendor/Vendor consignment stock
    SELECT seinm slabs sobkz
            FROM  mkol
              INTO CORRESPONDING FIELDS OF
              TABLE mkol_tab
              FOR ALL ENTRIES IN mseg_mkpf_tab
             WHERE matnr IN s_matnr
            AND werks = mseg_mkpf_tab-werks
          AND lifnr in s_lifnr
            AND sobkz  = 'K'.
  ENDIF.
  SELECT lgort speme umlme insme retme labst
   FROM mard INTO TABLE mard_tab
   WHERE matnr = zresult_tab-matnr
            AND werks IN s_werks
            AND lgort IN s_lgort1
            AND lgort IN s_lgort2.
  IF sy-subrc NE 0.
    MESSAGE i000 WITH 'no data populated!!!'.
  ENDIF.
SELECT matnr ebeln lifnr
                    FROM eord
                        INTO CORRESPONDING FIELDS OF
                        TABLE eord_lfa1_tab
                        WHERE matnr IN s_matnr
                       AND werks IN s_werks.
  IF sy-subrc NE 0.
    MESSAGE i000 WITH 'fgdf'.  ENDIF
  SELECT matnr ebeln lifnr
                FROM eord
                    INTO CORRESPONDING FIELDS OF
                    TABLE eord_lfa1_tab
                    WHERE lifnr IN  s_lifnr
                    AND werks IN s_werks
  IF sy-subrc NE 0.
    MESSAGE i000 WITH 'No  matching material found'.
  ENDIF.
  IF NOT p_endstk  IS INITIAL.
    CLEAR zresult_tab1.
    LOOP AT mard_tab.
      READ TABLE zresult_tab1 WITH KEY lgort = s_lgort1.
      IF sy-subrc EQ 0.
        COLLECT mard_tab INTO mard_tab1.
      ENDIF.
      MOVE mard_tab1-speme TO zresult_tab-speme.
      MOVE mard_tab1-umlme TO zresult_tab-umlme.
      MOVE mard_tab1-insme TO zresult_tab-insme.
      MOVE mard_tab1-retme TO zresult_tab-retme.
      MOVE mard_tab1-labst TO zresult_tab-labst.
      APPEND zresult_tab.
    ENDLOOP.
  ENDIF.
  IF NOT p_otrstk  IS INITIAL.
    CLEAR zresult_tab1.
    LOOP AT mard_tab.
     READ TABLE zresult_tab1 WITH KEY lgort = s_lgort1 lgort = s_lgort2
      IF sy-subrc EQ 0.
        COLLECT mard_tab INTO mard_tab1.
      ENDIF.
      MOVE mard_tab1-speme TO zresult_tab-speme.
      MOVE mard_tab1-umlme TO zresult_tab-umlme.
      MOVE mard_tab1-insme TO zresult_tab-insme.
      MOVE mard_tab1-retme TO zresult_tab-retme.
    move mard_tab1-labst to zresult_tab-labst.
      APPEND zresult_tab.
    ENDLOOP.
  ENDIF.
  IF NOT p_chk IS INITIAL.
    CLEAR :mseg_mkpf_tab,mseg_mkpf_tab1.
    LOOP AT zresult_tab1.
      READ TABLE mseg_mkpf_tab WITH KEY bwart1 = s_bwart1
      lifnr =  s_lifnr budat = s_usgpid.
      IF sy-subrc EQ 0.
        COLLECT mseg_mkpf_tab INTO mseg_mkpf_tab1.
      ENDIF.
      MOVE mseg_mkpf_tab1-menge TO zresult_tab1-menge.
      APPEND zresult_tab1.
    ENDLOOP.
  ENDIF.
and filling the zresult _tab like this:
  LOOP AT zresult_tab1.
    READ TABLE mseg_mkpf_tab.
    IF sy-subrc EQ 0.
      zresult_tab1-bwart = mseg_mkpf_tab-bwart1.
      MODIFY  zresult_tab1.
    ENDIF.
  ENDLOOP.
  LOOP AT zresult_tab1.
    READ TABLE mkol_tab.
    IF sy-subrc EQ 0.
      zresult_tab1-slabs = mkol_tab-slabs.
    ENDIF.
    MODIFY zresult_tab1.
  ENDLOOP.
  LOOP AT zresult_tab1.
    READ TABLE marc_tab.
    IF sy-subrc EQ 0.
      zresult_tab1-eislo = marc_tab-eislo.
      zresult_tab1-mabst = marc_tab-mabst.
      zresult_tab1-eisbe = marc_tab-eisbe.
      zresult_tab1-werks = marc_tab-werks.
      zresult_tab1-ekgrp = marc_tab-ekgrp.
      zresult_tab1-dispo = marc_tab-dispo.
    ENDIF.
    MODIFY zresult_tab1.
  ENDLOOP.
  LOOP AT zresult_tab1.
    READ TABLE mard_tab.
    IF sy-subrc EQ 0.
      zresult_tab1-labst = mard_tab-labst.
      zresult_tab1-lgort = mard_tab-lgort.
      zresult_tab1-speme = mard_tab-speme.
      zresult_tab1-umlme = mard_tab-umlme.
      zresult_tab1-insme = mard_tab-insme.
    ENDIF.
    MODIFY zresult_tab1.
  ENDLOOP.
Thanks
Alekhya

Answer 1

Some comments on your code ---
SELECT lgort speme umlme insme retme labst
FROM mard INTO TABLE mard_tab
WHERE matnr = zresult_tab-matnr
AND werks IN s_werks
AND lgort IN s_lgort1
AND lgort IN s_lgort2.
---> instead of using zresult_tab-matnr u should be using s_matnr...to populate the mard_tab internal table with the records for all material otherwise it would just do it for the last record of zresult_tab-matnr.
IF NOT p_endstk IS INITIAL.
CLEAR zresult_tab1.
LOOP AT mard_tab.
READ TABLE zresult_tab1 WITH KEY lgort = s_lgort1.
IF sy-subrc EQ 0.
COLLECT mard_tab INTO mard_tab1.
ENDIF.
MOVE mard_tab1-speme TO zresult_tab-speme.
MOVE mard_tab1-umlme TO zresult_tab-umlme.
MOVE mard_tab1-insme TO zresult_tab-insme.
MOVE mard_tab1-retme TO zresult_tab-retme.
MOVE mard_tab1-labst TO zresult_tab-labst.
APPEND zresult_tab.
ENDLOOP.
ENDIF.
--> I am quiet puzzled with the above code you are trying to read zresult_tab1 and appending data into zresult_tab. Also, for the read to be successful you should try and fill more key columns otherwise it would just fetch the first record.
--> Also in the final bit of code you are appending and modifying zresult_tab1 table and expecting result in zresult_tab table ?? Can you please check on the code with that respect.
Regards
Anurag