Icon on JButton

Question

I'm having an odd problem. Seemingly, I've done mostly everything correctly, but something must be wrong somewhere.
I'm trying to make JButtons with icon on them. I've made one, but the icon won't show. Here's my code:
          ImageIcon selectedIcon = new ImageIcon("selected.png", "Selected Menu");
          JButton characterScreenIcon = new JButton(selectedIcon);Now, that one actually works. But when I try to use setAction() on it, the icon disappears. This is the setAction line:
          characterScreenIcon.setAction(new ShowCharacterScreen());And here is the ShowCharacterScreen class:
     public class ShowCharacterScreen extends AbstractAction {
          public ShowCharacterScreen() {
               super();
          public void actionPerformed(ActionEvent e) {
               JButton icon = (JButton)(e.getSource());
               icon.setIcon(selectedIcon);
               JOptionPane.showMessageDialog(frame, "Button 1 pressed");
     }Now, it is worth noting that the action does work perfectly fine. I get the Dialog box. It's just the icon disappears when I use setAction() on it.
I would like to know why this happens, so I can figure out how to fix it.

Answer 1

hii,
are you meaning this one ??? --->
import java.awt.*;
import java.awt.event.*;
import java.io.BufferedInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
import javax.swing.*;
class TerraGUI {
    //GUI Fields
    static JFrame frame = new JFrame("TWOReborn");
    JPanel mainPane;
    JPanel characterPane;
    ImageIcon nonSelectedIcon;
    ImageIcon selectedIcon;
    public Container createContentPane() {
        mainPane = new JPanel();
        characterPane = new JPanel();
        characterPane.setPreferredSize(new Dimension(218, 442));
        characterPane.setBorder(BorderFactory.createLineBorder(Color.black));
        Image ViewMmImage = ImageViewMmLoader.getImage(TerraGUI.class, "resources/passed.png");
        Image ViewMmImage1 = ImageViewMmLoader.getImage(TerraGUI.class, "resources/failed.png");
        selectedIcon = new ImageIcon(ViewMmImage);
        nonSelectedIcon = new ImageIcon(ViewMmImage1);
        JPanel controlsAndStatus = new JPanel();
        JButton characterScreenIcon = new JButton();
        characterScreenIcon.setIcon(selectedIcon);
        characterScreenIcon.setMargin(new Insets(0, 0, 0, 0));
        characterScreenIcon.setAction(new ShowCharacterScreen());
        controlsAndStatus.add(characterScreenIcon);
        characterPane.add(controlsAndStatus);
        mainPane.add(characterPane);
        return mainPane;
    private static void createAndShowGUI() {
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setResizable(false);
        TerraGUI terra = new TerraGUI();
        frame.getContentPane().add(terra.createContentPane());
        frame.pack();
        frame.setVisible(true);
    public class ShowCharacterScreen extends AbstractAction {
        private static final long serialVersionUID = 1L;
        public ShowCharacterScreen() {
            super("", selectedIcon);
        public void actionPerformed(ActionEvent e) {
            JButton icon = (JButton) (e.getSource());
            icon.setIcon(null);
            icon.setIcon(nonSelectedIcon);
            JOptionPane.showMessageDialog(frame, "Button 1 pressed");
    public static void main(String[] args) {
        SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                createAndShowGUI();
final class ImageViewMmLoader {
    private ImageViewMmLoader() {
    public static Image getImage(Class<?> relativeClass, String filename) {
        Image returnValue = null;
        InputStream is = relativeClass.getResourceAsStream(filename);
        if (is != null) {
            BufferedInputStream bis = new BufferedInputStream(is);
            ByteArrayOutputStream baos = new ByteArrayOutputStream();
            try {
                int ch;
                while ((ch = bis.read()) != -1) {
                    baos.write(ch);
                returnValue = Toolkit.getDefaultToolkit().createImage(baos.toByteArray());
            } catch (IOException exception) {
                System.err.println("Error loading: " + filename);
        return returnValue;
}... kopik