Inserting data from one table into another table using PL/SQL

Question

HI,
I am trying to insert values from one table into another using PL procedure, the values I want to retrieve from the table riverside1 are charac_id and charac_type and insert these values into another table called riverside2 , the stored procedure zorgs_gorfs(x,y) accepts two parameters which are 2 charac_id's of d characters in riverside1 then using insert statements inserts these characters from riverside1 into riverside2.
CREATE OR REPLACE PROCEDURE zorgs_gorfs(x IN NUMBER, y IN NUMBER) AS
     BEGIN
          INSERT INTO riverside2
               (charac_id)
          VALUES
               (x);
INSERT INTO riverside2
               (charac_id)
          VALUES
               (y);
      END zorgs_gorfs;
/This works but the problem im having is that when I also try to insert the charac_type as well as the charac_id it doesnt work below is the code:
CREATE OR REPLACE PROCEDURE zorgs_gorfs(x IN NUMBER, y IN NUMBER) AS
     BEGIN
          INSERT INTO riverside2
               (charac_id,charac_tye)
          VALUES
               (Select
                    charac_id,
                    charc_type
               FROM
                    riverside1
               WHERE
                    charac_id = x);
      END zorgs_gorfs;
/can someone kindly sort me out

Answer 1

modify this sql
INSERT INTO riverside2
               (charac_id,charac_tye)
          VALUES
               (Select
                    charac_id,
                    charc_type
               FROM
                    riverside1
               WHERE
                    charac_id = x);as
INSERT INTO riverside2
               (charac_id,charac_tye)
          VALUES
               (Select
                    charac_id,
                    charc_type
               FROM
                    riverside1
               WHERE
                    charac_id in ( x,y));But my suggestion would be consider revising your approach. It does not look that good.
Thanks,
karthick.