Internal table(Optimizing the codes)

Question

Dear all,
  Please help me in optimizing the following codes..
FORM fetch_item_data1 .
  CLEAR itab_zsbhdr .
  LOOP AT itab_zsbhdr .
    IF itab_zsbhdr-bedae = 'SPI'.
      SELECT * FROM zioel2 INTO  i_zioel
                    WHERE ordr = itab_zsbhdr-vbeln
                    AND item = itab_zsbhdr-posnr
                    AND vdatu = itab_zsbhdr-vdatu .
        APPEND i_zioel.
        CLEAR i_zioel .
      ENDSELECT .
    ENDIF .
  ENDLOOP .
ENDFORM.                    " FETCH_ITEM_DATA1
MY DOUBT:
For example if you all can see the select statement,,there we can also write as,
data : itab_zsbhdr_dummy like itab_zsbhdr occurs 0 with header line.
CLEAR itab_zsbhdr .
itab_zsbhdr_dummy[] = itab_zsbhdr[].
DELETE itab_zsbhdr_DUMMY[] WHERE bedat NE 'SPI'.
SELECT * FROM zioel2 appending table i_zioel
             for all entries in itab_zsbhdr_DUMMY
                 WHERE ordr = itab_zsbhdr_dummy-vbeln
                 AND item = itab_zsbhdr_dummy-posnr
                 AND vdatu = itab_zsbhdr_dummy-vdatu .
So now we can see there is no append and modify.
So my question is ,,"Is it the right way to go?"
Again i am taking off the loop & instead deleting those date not equals to SPI.
So please help me by either confirming me with this particular optimization or give me some other optimized codes on this regard.
Thanx.

Answer 1

hye..
i am inserting my comments
FORM fetch_item_data1 .
CLEAR itab_zsbhdr .
You have cleared the internal table, so the content is empty.. hence it will not enter into the loop.
LOOP AT itab_zsbhdr .
IF itab_zsbhdr-bedae = 'SPI'.
SELECT * FROM zioel2 INTO i_zioel
WHERE ordr = itab_zsbhdr-vbeln
AND item = itab_zsbhdr-posnr
AND vdatu = itab_zsbhdr-vdatu .
Never use a select in a loop, this means ur hitting the database n number of times which is not at all recommondable.
APPEND i_zioel.
CLEAR i_zioel .
ENDSELECT .
instead of using select and end select it can be directly writen into
select * from [dbtab] into table [itab] for all entreis in it_comparision
where [field] = it_comparision-field.
ENDIF .
ENDLOOP .
ENDFORM. " FETCH_ITEM_DATA1
Yeah ur second code is more recommmended with these modifications.
hope this is useful.
thnks.
imran.